[Rt-commit] rt branch, 3.8-trunk, updated. e38bf1b92a7ba15f2aed08f4db40a8f1030708c5

[Ruslan Zakirov]

The branch, 3.8-trunk has been updated
       via  e38bf1b92a7ba15f2aed08f4db40a8f1030708c5 (commit)
       via  c4644285266b7054665c9416b9b81fc5e5d26c4f (commit)
       via  488901edd95e05f4c5ebada4b9763bfbc1fce13d (commit)
      from  159268587285e931df81e64720b56ed64224b363 (commit)

Summary of changes:
 lib/RT/Condition/UserDefined.pm       |    1 +
 sbin/rt-email-dashboards.in           |    3 ++-
 share/html/Search/Elements/EditFormat |    3 ++-
 3 files changed, 5 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 488901edd95e05f4c5ebada4b9763bfbc1fce13d
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Tue Sep 8 23:21:27 2009 +0400

    grep unique values when displaying columns selector
    
    When a setup has multiple CFs with the same name, we
    should show only one.

diff --git a/share/html/Search/Elements/EditFormat b/share/html/Search/Elements/EditFormat
index bfbb373..9dd6160 100644
--- a/share/html/Search/Elements/EditFormat
+++ b/share/html/Search/Elements/EditFormat
@@ -57,7 +57,8 @@
 <tr>
 
 <td valign="top"><select size="6" name="SelectDisplayColumns" multiple="multiple">
-% foreach my $field ( @$AvailableColumns) {
+% my %seen;
+% foreach my $field ( grep !$seen{lc $_}++, @$AvailableColumns) {
 <option value="<% $field %>"><% loc($field) %></option>
 % }
 </select></td>

commit c4644285266b7054665c9416b9b81fc5e5d26c4f
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Tue Sep 8 23:25:11 2009 +0400

    localize $@ as we don't re-throw error and log instead

diff --git a/lib/RT/Condition/UserDefined.pm b/lib/RT/Condition/UserDefined.pm
index 45534d6..f339e9a 100755
--- a/lib/RT/Condition/UserDefined.pm
+++ b/lib/RT/Condition/UserDefined.pm
@@ -59,6 +59,7 @@ This happens on every transaction. it's always applicable
 
 sub IsApplicable {
     my $self = shift;
+    local $@;
     my $retval = eval $self->ScripObj->CustomIsApplicableCode;
     if ($@) {
         $RT::Logger->error("Scrip ".$self->ScripObj->Id. " IsApplicable failed: ".$@);

commit e38bf1b92a7ba15f2aed08f4db40a8f1030708c5
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Wed Sep 9 03:55:27 2009 +0400

    encode content and set charset when we build MIME::Entity

diff --git a/sbin/rt-email-dashboards.in b/sbin/rt-email-dashboards.in
index 9fbf6b6..caa5535 100644
--- a/sbin/rt-email-dashboards.in
+++ b/sbin/rt-email-dashboards.in
@@ -348,8 +348,9 @@ sub build_email {
     );
 
     $entity->attach(
-        Data        => $content,
+        Data        => Encode::encode_utf8($content),
         Type        => 'text/html',
+        Charset     => 'UTF-8',
         Disposition => 'inline',
     );
 

-----------------------------------------------------------------------