[Rt-commit] rt branch, create-action, updated. fbecdad88ad829c467663bf0a29ad37c522be16f

[sartak at bestpractical.com]

The branch, create-action has been updated
       via  fbecdad88ad829c467663bf0a29ad37c522be16f (commit)
      from  c204e6e4d230c0e7fefcbb5fb73f44a02b4d799e (commit)

Summary of changes:
 lib/RT/Action/QueueBased.pm |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

- Log -----------------------------------------------------------------
commit fbecdad88ad829c467663bf0a29ad37c522be16f
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Tue Sep 22 10:45:29 2009 -0400

    Some comments explaining queue-based actions

diff --git a/lib/RT/Action/QueueBased.pm b/lib/RT/Action/QueueBased.pm
index d74712f..002c08f 100644
--- a/lib/RT/Action/QueueBased.pm
+++ b/lib/RT/Action/QueueBased.pm
@@ -15,6 +15,7 @@ sub arguments {
     my $self = shift;
 
     if (!$self->{_cached_arguments}) {
+        # The blank slate is the parameters provided using Jifty::Param::Schema
         $self->{_cached_arguments} = \%{ $self->PARAMS };
 
         # The two cases are:
@@ -62,6 +63,7 @@ sub set_queue {
 
     $self->fill_parameter(queue => default_value => $queue->name);
 
+    # Let the action invoke all its queue-specific logic
     $self->after_set_queue($queue);
 
     return $queue;
@@ -77,6 +79,7 @@ sub fill_parameter {
     };
 }
 
+# This is empty so that users can always redispatch cleanly
 sub after_set_queue {}
 
 1;

-----------------------------------------------------------------------