[Rt-commit] rt branch, 3.8.8-releng, created. rt-3.8.7-313-g6ac8df1
Ruslan Zakirov
ruz at bestpractical.com
Fri Apr 2 12:48:03 EDT 2010
The branch, 3.8.8-releng has been created
at 6ac8df1d1cfe3597a112d88c04c9d39b155d810e (commit)
- Log -----------------------------------------------------------------
commit f7b88be2cd27f5a4e789b95c0a884030eddb3708
Author: Shawn M Moore <sartak at bestpractical.com>
Date: Tue Mar 30 18:09:27 2010 -0400
use uppercase Classes parameter
diff --git a/share/html/Elements/CollectionAsTable/Row b/share/html/Elements/CollectionAsTable/Row
index 407fb4a..a1af9f3 100644
--- a/share/html/Elements/CollectionAsTable/Row
+++ b/share/html/Elements/CollectionAsTable/Row
@@ -54,10 +54,10 @@ $Depth => undef
$Warning => undef
$ColumnMap => {}
$Class => 'RT__Ticket'
-$classes => ''
+$Classes => ''
</%ARGS>
<%init>
-$m->out( '<tr class="' . $classes . ' '
+$m->out( '<tr class="' . $Classes . ' '
. ( $Warning ? 'warnline' : $i % 2 ? 'oddline' : 'evenline' ) . '" >'
. "\n" );
use HTML::Entities;
diff --git a/share/html/Elements/CollectionList b/share/html/Elements/CollectionList
index 78edd6d..14d5d92 100644
--- a/share/html/Elements/CollectionList
+++ b/share/html/Elements/CollectionList
@@ -124,13 +124,13 @@ while ( my $record = $Collection->Next ) {
$m->flush_buffer unless ++$i % 10;
my $warning = 0;
- my $classes = '';
+ my $Classes = '';
$m->callback(
CallbackName => 'EachRow',
Record => $record,
Warning => \$warning,
- classes => \$classes,
+ Classes => \$Classes,
Format => \@Format,
);
@@ -142,7 +142,7 @@ while ( my $record = $Collection->Next ) {
ColumnMap => $column_map,
Class => $Class,
Warning => $warning,
- classes => $classes,
+ Classes => $Classes,
);
}
commit 7b84cd29b14666b0984bde2e64b693547af64ea6
Author: Jesse Vincent <jesse at bestpractical.com>
Date: Wed Mar 31 14:07:26 2010 -0400
reformatting of the "tools" ui.
diff --git a/share/html/Admin/Tools/Configuration.html b/share/html/Admin/Tools/Configuration.html
index 231eba8..22c846a 100644
--- a/share/html/Admin/Tools/Configuration.html
+++ b/share/html/Admin/Tools/Configuration.html
@@ -58,9 +58,6 @@ unless ($session{'CurrentUser'}->HasRight( Object=> $RT::System, Right => 'Super
current_subtab => 'Admin/Tools/Configuration.html',
Title => $title &>
-<table>
- <tr>
- <td valign="top" width="60%" class="boxcontainer">
<&|/Widgets/TitleBox, title => loc("RT Configuration") &>
<table border="0" cellspacing="0" cellpadding="5" width="100%" class="collection">
<tr class="collection-as-table">
@@ -116,8 +113,9 @@ foreach my $key ( RT->Config->Options( Overridable => undef, Sorted => 0 ) ) {
% }
</table>
</&>
-</td>
-<td valign="top" class="boxcontainer">
+<table width="100%">
+ <tr>
+ <td valign="top" width="60%" class="boxcontainer">
<&|/Widgets/TitleBox, title=> loc("RT core variables") &>
<table border="0" cellspacing="0" cellpadding="5" width="100%" class="collection">
<tr class="collection-as-table">
@@ -179,6 +177,8 @@ for my $type (qw/Tickets Queues Transactions Groups PrivilegedUsers Unprivileged
% }
</table>
</&>
+</td>
+<td valign="top" class="boxcontainer">
<&|/Widgets/TitleBox, title => loc("Mason template search order") &>
<ol>
commit d9f271fd31124b4a6bf24500463cec1ab20269b0
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date: Wed Mar 31 23:07:08 2010 +0400
sort callbacks with a root
We now respect plugins' order, but local callbacks
should be sorted anyway to keep order for old plugins
and local customizations
diff --git a/lib/RT/Interface/Web/Request.pm b/lib/RT/Interface/Web/Request.pm
index 573c69a..4107ca2 100644
--- a/lib/RT/Interface/Web/Request.pm
+++ b/lib/RT/Interface/Web/Request.pm
@@ -164,7 +164,7 @@ sub callback {
# Skip backup files, files without a leading package name,
# and files we've already seen
grep !$seen{$_}++ && !m{/\.} && !m{~$} && m{^/Callbacks/[^/]+\Q$page/$name\E$},
- map $self->interp->resolver->glob_path($path, $_),
+ map sort $self->interp->resolver->glob_path($path, $_),
@roots
);
foreach my $comp (keys %seen) {
commit 294f77da3dd9290387537646d5bbe77ae1fc1221
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date: Thu Apr 1 01:17:39 2010 +0400
fix compilation error
diff --git a/lib/RT/Interface/Web/Request.pm b/lib/RT/Interface/Web/Request.pm
index 4107ca2..ba626a0 100644
--- a/lib/RT/Interface/Web/Request.pm
+++ b/lib/RT/Interface/Web/Request.pm
@@ -164,7 +164,7 @@ sub callback {
# Skip backup files, files without a leading package name,
# and files we've already seen
grep !$seen{$_}++ && !m{/\.} && !m{~$} && m{^/Callbacks/[^/]+\Q$page/$name\E$},
- map sort $self->interp->resolver->glob_path($path, $_),
+ map { sort $self->interp->resolver->glob_path($path, $_) }
@roots
);
foreach my $comp (keys %seen) {
commit ee5b13d1326fca5ebd2ac66ee457da0394be1267
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Wed Mar 31 16:28:27 2010 -0400
Prevent servers using GnuPG from running out of filehandles
RT::Crypt::GnuPG uses File::Temp->tmpfile(UNLINK=>1) to create
temporary files. However, in scalar context, which returns filename
and filehandle, the files aren't actually unlinked, or the filehandles
closed, until the process exits. This poses problems for long-running
server processes. To mitigate this, we explicitly tell File::Temp to
close all pending tempfile handles, and remove the underlying files,
once per request.
diff --git a/lib/RT/Interface/Web/Handler.pm b/lib/RT/Interface/Web/Handler.pm
index 8d1be8d..6a06606 100644
--- a/lib/RT/Interface/Web/Handler.pm
+++ b/lib/RT/Interface/Web/Handler.pm
@@ -219,6 +219,10 @@ sub CleanupRequest {
}
%RT::Ticket::MERGE_CACHE = ( effective => {}, merged => {} );
+
+ # Explicitly remove any tmpfiles that GPG opened, and close their
+ # filehandles.
+ File::Temp::cleanup;
}
# }}}
commit 6ac8df1d1cfe3597a112d88c04c9d39b155d810e
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date: Thu Apr 1 18:01:28 2010 +0400
revert 'not scrubbing tables'
We need code that filters unbalanced tags in the HTML. Until
then this code stays on branch
diff --git a/share/html/Elements/ScrubHTML b/share/html/Elements/ScrubHTML
index ed166e9..7744a85 100644
--- a/share/html/Elements/ScrubHTML
+++ b/share/html/Elements/ScrubHTML
@@ -61,21 +61,12 @@ $scrubber->default(
target => 1,
style => qr{^(?:(?:color:\s*rgb\(\d+,\s*\d+,\s*\d+\))|
(?:text-align:\s*))}ix,
- colspan => qr{^[0-9]+$},
- rowspan => qr{^[0-9]+$},
- align => qr{^(?i:left|center|right|justify|char)$},
- valign => qr{^(?i:top|middle|bottom|baseline)$},
}
);
$scrubber->deny(qw[*]);
-$scrubber->allow(qw(
- A EM P DIV SPAN PRE
- HR BR
- B U I SMALL FONT STRONG SUB SUP STRIKE
- H1 H2 H3 H4 H5 H6
- UL OL LI DL DT DD
- TABLE TR TD TH
-) );
+$scrubber->allow(
+ qw[A B U P BR I HR BR SMALL EM FONT SPAN STRONG SUB SUP STRIKE H1 H2 H3 H4 H5 H6 DIV UL OL LI DL DT DD PRE]
+);
$scrubber->comment(0);
</%ONCE>
<%init>
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list