[Rt-commit] rt branch, 3.8-trunk, updated. rt-3.8.7-328-g0dbbe8a

[Ruslan Zakirov]

The branch, 3.8-trunk has been updated
       via  0dbbe8a30c96c518d80e80ad23625ea56950fb2d (commit)
       via  979eb8c6140ae04becefcaadf32356a63ea1172e (commit)
       via  3e1c3ab6c30bf42aeb16f4f949864e0c55f5cea3 (commit)
       via  ae8837c21cb0b14df6b2c788256cabef5c9a8d85 (commit)
       via  aa892ca4e0003a6405137e4e7961550d3d1273ec (commit)
       via  381bfc0811d942f6cc1a49dca8d2134d13d86a30 (commit)
       via  37752bdaf5edd05355c3425da211351a02a3aff0 (commit)
       via  56ead7bb06097b012362a77988be1ebcb90c2550 (commit)
       via  f545b3456d48ae265778c9f643e092c3d3f6d6ba (commit)
      from  a9f1393c344a8e8f10ead7fd59e0041b5f44acee (commit)

Summary of changes:
 etc/RT_Config.pm.in            |   22 ++++
 lib/RT/Search/Googleish.pm     |  229 ++++++++++++++++++++++++++--------------
 share/html/Search/Results.html |    6 +
 t/web/googleish_search.t       |  136 ++++++++++++++++++++++++
 4 files changed, 313 insertions(+), 80 deletions(-)
 create mode 100644 t/web/googleish_search.t

- Log -----------------------------------------------------------------
commit 979eb8c6140ae04becefcaadf32356a63ea1172e
Merge: a9f1393 3e1c3ab
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Sat Apr 3 00:16:43 2010 +0400

    Merge remote branch 'origin/googleish-refactor' into 3.8-trunk
    
    Conflicts:
    	lib/RT/Search/Googleish.pm


commit 0dbbe8a30c96c518d80e80ad23625ea56950fb2d
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Sat Apr 3 00:17:03 2010 +0400

    we usually don't use Load's return value

diff --git a/lib/RT/Search/Googleish.pm b/lib/RT/Search/Googleish.pm
index 6362c2d..ed28f70 100644
--- a/lib/RT/Search/Googleish.pm
+++ b/lib/RT/Search/Googleish.pm
@@ -196,8 +196,8 @@ sub TranslateQueue {
     my $key  = shift;
 
     my $Queue = RT::Queue->new( $self->TicketsObj->CurrentUser );
-    my ( $ret ) = $Queue->Load($key);
-    if ( $ret && $Queue->Id ) {
+    $Queue->Load($key);
+    if ( $Queue->id ) {
         my $quoted_queue = $Queue->Name;
         $quoted_queue =~ s/'/\\'/g;
         return "Queue = '$quoted_queue'";
@@ -221,8 +221,8 @@ sub TranslateOwner {
     my $key  = shift;
 
     my $User = RT::User->new( $self->TicketsObj->CurrentUser );
-    my ( $ret ) = $User->Load($key);
-    if ( $ret && $User->Privileged ) {
+    $User->Load($key);
+    if ( $User->id && $User->Privileged ) {
         my $name = $User->Name;
         $name =~ s/(['"])/\\$1/g;
         return "Owner = '" . $name . "'";

-----------------------------------------------------------------------