[Rt-commit] rtir branch, 2.4-trunk, updated. 88077233fa4bca2d0da4704bcf026d4482495dba

Ruslan Zakirov ruz at bestpractical.com
Wed Apr 21 16:26:13 EDT 2010


The branch, 2.4-trunk has been updated
       via  88077233fa4bca2d0da4704bcf026d4482495dba (commit)
       via  32b179914aa00db7b58413199eda44500c232299 (commit)
      from  4a33de1b3a9ae7278f1f81edc0bf1e1b543e1c48 (commit)

Summary of changes:
 html/RTIR/Elements/ShowRTIRField |    1 +
 html/RTIR/Tools/Lookup.html      |    4 +++-
 2 files changed, 4 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 32b179914aa00db7b58413199eda44500c232299
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Tue Mar 9 20:45:51 2010 +0300

    explicit return to avoid zeros on the page

diff --git a/html/RTIR/Elements/ShowRTIRField b/html/RTIR/Elements/ShowRTIRField
index 465eec3..8eac09a 100644
--- a/html/RTIR/Elements/ShowRTIRField
+++ b/html/RTIR/Elements/ShowRTIRField
@@ -49,6 +49,7 @@ my $show_cb = sub {
     if ( $linked ) {
         $m->out('</a>');
     }
+    return '';
 };
 </%INIT>
 <%ARGS>

commit 88077233fa4bca2d0da4704bcf026d4482495dba
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Thu Apr 22 00:25:14 2010 +0400

    apply transaction date search only if it's FTS

diff --git a/html/RTIR/Tools/Lookup.html b/html/RTIR/Tools/Lookup.html
index c3a2e27..4e42bef 100644
--- a/html/RTIR/Tools/Lookup.html
+++ b/html/RTIR/Tools/Lookup.html
@@ -254,8 +254,10 @@ if ( $q ) {
             . "OR ContentType = 'text' "
             . "OR ContentType = 'text/html' )"
             . " AND Content LIKE '$q'";
+        # apply transaction date search only if it's FTS as otherwise
+        # it can ruin performance of mysql optimizer rather than help
+        $query = "( $query ) AND TransactionDate > '". $now->ISO ."'"
     }
-    $query = "( $query ) AND TransactionDate > '". $now->ISO ."'";
 
     my ($val, $msg) = $session{'tickets'}->FromSQL( $query );
     $RT::Logger->warning( $msg ) unless $val;

-----------------------------------------------------------------------


More information about the Rt-commit mailing list