[Rt-commit] rt branch, 3.8-trunk, updated. rt-3.8.7-363-g54c62fa

[Ruslan Zakirov]

The branch, 3.8-trunk has been updated
       via  54c62fad22c05437bb5ebc424cd85ab2684d586f (commit)
       via  252006afa1ca848d08cbea1e16754d91e81e8fb1 (commit)
      from  4a2cf501a93e6330d5a36c6f83834c75770da976 (commit)

Summary of changes:
 lib/RT/Date.pm |    2 +-
 lib/RT/Test.pm |   11 +++++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 252006afa1ca848d08cbea1e16754d91e81e8fb1
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Tue Apr 27 21:23:00 2010 +0400

    RFC2616 date formatter was incorrectly respecting timezones

diff --git a/lib/RT/Date.pm b/lib/RT/Date.pm
index fc4c43c..f9405dd 100755
--- a/lib/RT/Date.pm
+++ b/lib/RT/Date.pm
@@ -858,7 +858,7 @@ sub RFC2616 {
                  Seconds => 1, DayOfWeek => 1,
                );
 
-    my $res = $self->RFC2822( @_ );
+    my $res = $self->RFC2822( %args );
     $res =~ s/\s*[+-]\d\d\d\d$/ GMT/ if $args{'Time'};
     return $res;
 }

commit 54c62fad22c05437bb5ebc424cd85ab2684d586f
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Tue Apr 27 21:24:39 2010 +0400

    insert extensions' schemas and acls as DBA

diff --git a/lib/RT/Test.pm b/lib/RT/Test.pm
index b8d1683..3bea324 100644
--- a/lib/RT/Test.pm
+++ b/lib/RT/Test.pm
@@ -389,6 +389,12 @@ sub bootstrap_plugins {
     RT->Config->Set( Plugins => @plugins );
     RT->InitPluginPaths;
 
+    my $dba_dbh;
+    $dba_dbh = _get_dbh(
+        RT::Handle->DSN,
+        $ENV{RT_DBA_USER}, $ENV{RT_DBA_PASSWORD},
+    ) if @plugins;
+
     require File::Spec;
     foreach my $name ( @plugins ) {
         my $plugin = RT::Plugin->new( name => $name );
@@ -400,10 +406,10 @@ sub bootstrap_plugins {
             if $ENV{'TEST_VERBOSE'};
 
         if ( -e $etc_path ) {
-            my ($ret, $msg) = $RT::Handle->InsertSchema( undef, $etc_path );
+            my ($ret, $msg) = $RT::Handle->InsertSchema( $dba_dbh, $etc_path );
             Test::More::ok($ret || $msg =~ /^Couldn't find schema/, "Created schema: ".($msg||''));
 
-            ($ret, $msg) = $RT::Handle->InsertACL( undef, $etc_path );
+            ($ret, $msg) = $RT::Handle->InsertACL( $dba_dbh, $etc_path );
             Test::More::ok($ret || $msg =~ /^Couldn't find ACLs/, "Created ACL: ".($msg||''));
 
             my $data_file = File::Spec->catfile( $etc_path, 'initialdata' );
@@ -423,6 +429,7 @@ sub bootstrap_plugins {
 
         $RT::Handle->Connect; # XXX: strange but mysql can loose connection
     }
+    $dba_dbh->disconnect if $dba_dbh;
 }
 
 sub _get_dbh {

-----------------------------------------------------------------------