[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-223-g6731eb2

[? sunnavy]

The branch, 3.9-trunk has been updated
       via  6731eb2567c978d985fe20dffd68f05519808d42 (commit)
       via  b54be3e1023282b6cc59d4a8ba83ee8624f56ee5 (commit)
      from  8a2725a1031352ee57b28e21b496ce329bb31f17 (commit)

Summary of changes:
 lib/RT/Date.pm |    2 +-
 t/api/date.t   |   15 ++++++++++++++-
 2 files changed, 15 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit b54be3e1023282b6cc59d4a8ba83ee8624f56ee5
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 6 10:45:40 2010 +0800

    string without \S should be set to unix 0

diff --git a/lib/RT/Date.pm b/lib/RT/Date.pm
index ef619f7..2684e8f 100755
--- a/lib/RT/Date.pm
+++ b/lib/RT/Date.pm
@@ -164,7 +164,7 @@ sub Set {
         @_
     );
 
-    return $self->Unix(0) unless $args{'Value'};
+    return $self->Unix(0) unless $args{'Value'} && $args{'Value'} =~ /\S/;
 
     if ( $args{'Format'} =~ /^unix$/i ) {
         return $self->Unix( $args{'Value'} );

commit 6731eb2567c978d985fe20dffd68f05519808d42
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Aug 6 10:46:11 2010 +0800

    edge case test for Date::Set with Format unknown

diff --git a/t/api/date.t b/t/api/date.t
index bc1446f..f2b159a 100644
--- a/t/api/date.t
+++ b/t/api/date.t
@@ -7,7 +7,7 @@ my $tests;
 
 my $localized_datetime_tests;
 BEGIN {
-    $tests = 167;
+    $tests = 170;
     $localized_datetime_tests =
       eval { require DateTime; 1; } && eval { require DateTime::Locale; 1; } &&
       DateTime->can('format_cldr') && DateTime::Locale::root->can('date_format_full');
@@ -557,6 +557,19 @@ my $year = (localtime(time))[5] + 1900;
     is($date->GetMonth(-13),  '',    '-13 and lesser are invalid');
 }
 
+{
+    # set unknown format: edge cases
+    my $date = RT::Date->new($RT::SystemUser);
+    $date->Set( Value => 0, Format => 'unknown' );
+    is( $date->Unix(), 0, "unix is 0 with Value => 0, Format => 'unknown'" );
+
+    $date->Set( Value => '', Format => 'unknown' );
+    is( $date->Unix(), 0, "unix is 0 with Value => '', Format => 'unknown'" );
+
+    $date->Set( Value => ' ', Format => 'unknown' );
+    is( $date->Unix(), 0, "unix is 0 with Value => ' ', Format => 'unknown'" );
+}
+
 #TODO: AsString
 #TODO: RFC2822, W3CDTF with Timezones
 

-----------------------------------------------------------------------