[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-225-gd47d7c1

[Thomas Sibley]

The branch, 3.9-trunk has been updated
       via  d47d7c1f3a43d58a7565494488aaa2c283c1c162 (commit)
      from  aa588c030d621d041eea5dedb274be5c2aae690e (commit)

Summary of changes:
 share/html/Elements/EmailInput             |    2 +-
 share/html/NoAuth/css/base/ticket-form.css |    5 +++++
 share/html/Ticket/Create.html              |    8 ++++----
 share/html/Ticket/Elements/UpdateCc        |    4 ++--
 share/html/Ticket/Update.html              |    2 +-
 5 files changed, 13 insertions(+), 8 deletions(-)

- Log -----------------------------------------------------------------
commit d47d7c1f3a43d58a7565494488aaa2c283c1c162
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Sat Aug 7 00:01:37 2010 -0400

    Don't hardcode <input> sizes for ticket update/create forms
    
    We'll handle the width in CSS and it won't break layouts.  This also
    adds an explicit type="text" to all EmailInputs, which is a good thing.
    Someday (soon) we might want to switch to type="email" and take
    advantage of HTML5 goodness.

diff --git a/share/html/Elements/EmailInput b/share/html/Elements/EmailInput
index 61ffb28..6972fb0 100644
--- a/share/html/Elements/EmailInput
+++ b/share/html/Elements/EmailInput
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %# 
 %# END BPS TAGGED BLOCK }}}
-<input id="<% $Name %>" name="<% $Name %>" size="<% $Size %>" value="<% $Default || '' %>" />
+<input type="text" id="<% $Name %>" name="<% $Name %>" <% defined $Size ? qq{size="$Size"} : '' |n %> value="<% $Default || '' %>" />
 <%ARGS>
 $Name
 $Size    => 40
diff --git a/share/html/NoAuth/css/base/ticket-form.css b/share/html/NoAuth/css/base/ticket-form.css
index 710a8c0..e4ee624 100644
--- a/share/html/NoAuth/css/base/ticket-form.css
+++ b/share/html/NoAuth/css/base/ticket-form.css
@@ -17,6 +17,11 @@
     margin-bottom: 0.5em;
 }
 
+#ticket-create-message .messagedetails input[type="text"],
+#ticket-update-message .messagedetails input[type="text"] {
+    width: 90%;
+}
+
 #ticket-create-message #SubmitTicket,
 #ticket-update-message #SubmitTicket {
     padding-bottom: 2em;
diff --git a/share/html/Ticket/Create.html b/share/html/Ticket/Create.html
index bc5235c..17bff08 100755
--- a/share/html/Ticket/Create.html
+++ b/share/html/Ticket/Create.html
@@ -117,14 +117,14 @@
 <&|/l&>Requestors</&>:
 </td>
 <td class="value" colspan="5">
-<& /Elements/EmailInput, Name => 'Requestors', Size => '40', Default => $ARGS{Requestors} || $session{CurrentUser}->EmailAddress &>
+<& /Elements/EmailInput, Name => 'Requestors', Size => undef, Default => $ARGS{Requestors} || $session{CurrentUser}->EmailAddress &>
 </td>
 </tr>
 <tr>
 <td class="label">
 <&|/l&>Cc</&>:
 </td>
-<td class="value" colspan="5"><& /Elements/EmailInput, Name => 'Cc', Size => '40', Default => $ARGS{Cc} &></td>
+<td class="value" colspan="5"><& /Elements/EmailInput, Name => 'Cc', Size => undef, Default => $ARGS{Cc} &></td>
 </tr>
 
 <tr>
@@ -140,7 +140,7 @@
 <td class="label">
 <&|/l&>Admin Cc</&>:
 </td>
-<td class="value" colspan="5"><& /Elements/EmailInput, Name => 'AdminCc', Size => '40', Default => $ARGS{AdminCc} &></td>
+<td class="value" colspan="5"><& /Elements/EmailInput, Name => 'AdminCc', Size => undef, Default => $ARGS{AdminCc} &></td>
 </tr>
 
 <tr>
@@ -157,7 +157,7 @@
 <&|/l&>Subject</&>:
 </td>
 <td class="value" colspan="5">
-<input name="Subject" size="60" maxsize="200" value="<%$ARGS{Subject} || ''%>" />
+<input type="text" name="Subject" maxsize="200" value="<%$ARGS{Subject} || ''%>" />
 % $m->callback( %ARGS, CallbackName => 'AfterSubject' );
 </td>
 </tr>
diff --git a/share/html/Ticket/Elements/UpdateCc b/share/html/Ticket/Elements/UpdateCc
index 50f0a93..cb04cf6 100644
--- a/share/html/Ticket/Elements/UpdateCc
+++ b/share/html/Ticket/Elements/UpdateCc
@@ -47,7 +47,7 @@
 %# END BPS TAGGED BLOCK }}}
 % $m->callback(CallbackName => 'BeforeCc', ARGSRef => \%ARGS, Ticket => $TicketObj, one_time_Ccs => \@one_time_Ccs, txn_addresses => \%txn_addresses);
 
-<tr><td class="label"><&|/l&>One-time Cc</&>:</td><td><& /Elements/EmailInput, Name => 'UpdateCc', Size => '60', Default => $ARGS{UpdateCc} &>
+<tr><td class="label"><&|/l&>One-time Cc</&>:</td><td><& /Elements/EmailInput, Name => 'UpdateCc', Size => undef, Default => $ARGS{UpdateCc} &>
 <input type="hidden" id="UpdateIgnoreAddressCheckboxes" name="UpdateIgnoreAddressCheckboxes" value="0">
         <br />
 
@@ -65,7 +65,7 @@ name="UpdateCc-<%$addr%>"
     <% $ARGS{'UpdateCc-'.$addr} ? 'checked="checked"' : ''%> > <& /Elements/ShowUser, Address => $txn_addresses{$addr}&>
 %}
 </td></tr>
-<tr><td class="label"><&|/l&>One-time Bcc</&>:</td><td><& /Elements/EmailInput, Name => 'UpdateBcc', Size => '60', Default => $ARGS{UpdateBcc} &><br />
+<tr><td class="label"><&|/l&>One-time Bcc</&>:</td><td><& /Elements/EmailInput, Name => 'UpdateBcc', Size => undef, Default => $ARGS{UpdateBcc} &><br />
 %if (scalar @one_time_Ccs) {
 <i class="label">(<&|/l&>check to add</&>)</i>
 %}
diff --git a/share/html/Ticket/Update.html b/share/html/Ticket/Update.html
index 741713b..2e7b8ee 100755
--- a/share/html/Ticket/Update.html
+++ b/share/html/Ticket/Update.html
@@ -140,7 +140,7 @@
 % }
 % $m->callback( %ARGS, CallbackName => 'AfterGnuPG' );
 
-<tr><td class="label"><&|/l&>Subject</&>:</td><td> <input name="UpdateSubject" size="60" value="<% $ARGS{UpdateSubject} || $TicketObj->Subject()%>" />
+<tr><td class="label"><&|/l&>Subject</&>:</td><td> <input type="text" name="UpdateSubject" value="<% $ARGS{UpdateSubject} || $TicketObj->Subject()%>" />
 % $m->callback( %ARGS, CallbackName => 'AfterSubject' );
 </td></tr>
 

-----------------------------------------------------------------------