[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-290-g510d78c

Kevin Falcone falcone at bestpractical.com
Wed Aug 11 14:55:38 EDT 2010


The branch, 3.9-trunk has been updated
       via  510d78c83293026622404459969365365071d27e (commit)
      from  08a937f30fd9d99b76e2f08fd04490c6260ae12e (commit)

Summary of changes:
 share/html/Ticket/Elements/Bookmark |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 510d78c83293026622404459969365365071d27e
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Wed Aug 11 14:56:44 2010 -0400

    Make it harder to have a conflicting id
    
    Naming something toggle-# invites conflicts.
    Also undo some crazy wrapping in the middle of a mason
    expression/onClick handler

diff --git a/share/html/Ticket/Elements/Bookmark b/share/html/Ticket/Elements/Bookmark
index 55efb6b..cb905c1 100644
--- a/share/html/Ticket/Elements/Bookmark
+++ b/share/html/Ticket/Elements/Bookmark
@@ -81,10 +81,9 @@ if ( $Toggle ) {
 $id
 $Toggle => 0
 </%ARGS>
-<span id="toggle-<% $id %>">
+<span id="toggle-bookmark-<% $id %>">
 % my $url = RT->Config->Get('WebPath') ."/Helpers/Toggle/TicketBookmark?id=". $id;
-<a align="right" href="<% $url %>" onclick="jQuery('#toggle-<% $id |n
-%>').load('<% $url |n %>'); return false;" >
+<a align="right" href="<% $url %>" onclick="jQuery('#toggle-bookmark-<% $id |n%>').load('<% $url |n %>'); return false;" >
 % if ( $bookmarked ) {
 <img src="<% RT->Config->Get('WebPath') %>/NoAuth/images/star.gif" alt="<% loc('Remove Bookmark') %>" style="border-style: none" />
 % } else {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list