[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-425-g1c9a507

[Thomas Sibley]

The branch, 3.9-trunk has been updated
       via  1c9a507cb3595f91f3f5ed8ba912459db3e55681 (commit)
      from  ee4ad902b2db5069232636dbfd20cb61a0dcc5d8 (commit)

Summary of changes:
 share/html/Widgets/TitleBoxStart |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 1c9a507cb3595f91f3f5ed8ba912459db3e55681
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Aug 17 16:36:37 2010 -0400

    Seriously, just escape everything that isn't valid in element IDs
    
    jQuery interprets periods and colons as CSS selectors.  This change will
    break existing cookies for people's hidden/shown preferences, but it'll
    be in a major release at least.

diff --git a/share/html/Widgets/TitleBoxStart b/share/html/Widgets/TitleBoxStart
index 23ed037..f5010d7 100755
--- a/share/html/Widgets/TitleBoxStart
+++ b/share/html/Widgets/TitleBoxStart
@@ -88,7 +88,8 @@ my $title_b64 = MIME::Base64::encode_base64(Encode::encode_utf8($title), '');
 my $tid  = "TitleBox--$page--" .
             join '--', ($class, $bodyclass, $title_b64, $id);
 
-$tid =~ s{[^A-Za-z0-9\-_:\.]+}{_}g;
+# Replace anything that ISN'T alphanumeric, a hyphen, or an underscore
+$tid =~ s{[^A-Za-z0-9\-_]}{_}g;
 
 my $i = 0;
 $i++ while $m->notes("$tid-$i");

-----------------------------------------------------------------------