[Rt-commit] rt branch, owner-autocomplete, updated. rt-3.8.8-486-ga5f41c2

Thomas Sibley trs at bestpractical.com
Thu Aug 19 18:12:27 EDT 2010


The branch, owner-autocomplete has been updated
       via  a5f41c2ba13df030c4bf838374cc1c798cc7a363 (commit)
      from  a9490fba858e59c0e105bab23620fb3b92199df5 (commit)

Summary of changes:
 share/html/Elements/SelectOwnerAutocomplete |    5 +++--
 share/html/Helpers/Autocomplete/Owners      |    4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

- Log -----------------------------------------------------------------
commit a5f41c2ba13df030c4bf838374cc1c798cc7a363
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Aug 19 18:11:04 2010 -0400

    Default to Name instead of Id, which magically just works

diff --git a/share/html/Elements/SelectOwnerAutocomplete b/share/html/Elements/SelectOwnerAutocomplete
index d3f4e97..dffce29 100644
--- a/share/html/Elements/SelectOwnerAutocomplete
+++ b/share/html/Elements/SelectOwnerAutocomplete
@@ -49,10 +49,10 @@
 $Name           => undef
 $Objects        => []
 $Default        => 0
-$ValueAttribute => 'id'
+$ValueAttribute => 'Name'
 </%ARGS>
 <%INIT>
-$ValueAttribute = 'id' unless $ValueAttribute =~ /^(?:id|Name)$/;
+$ValueAttribute = 'Name' unless $ValueAttribute =~ /^(?:id|Name)$/;
 
 my $value = '';
 
@@ -79,3 +79,4 @@ my $query = $m->comp('/Elements/QueryString',
         });
     });
 </script>
+
diff --git a/share/html/Helpers/Autocomplete/Owners b/share/html/Helpers/Autocomplete/Owners
index af57ad2..94a942d 100644
--- a/share/html/Helpers/Autocomplete/Owners
+++ b/share/html/Helpers/Autocomplete/Owners
@@ -49,7 +49,7 @@
 <% JSON::to_json( \@suggestions ) |n %>
 % $m->abort;
 <%ARGS>
-$return => ''
+$return => 'Name'
 $limit => undef
 $term => undef
 </%ARGS>
@@ -57,7 +57,7 @@ $term => undef
 require JSON;
 
 # Only allow certain return fields
-$return = 'id'
+$return = 'Name'
     unless $return =~ /^(?:EmailAddress|Name|RealName|id)$/;
 
 $m->abort unless defined $return

-----------------------------------------------------------------------


More information about the Rt-commit mailing list