[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-533-gf14eac7

[Jesse Vincent]

The branch, 3.9-trunk has been updated
       via  f14eac7b91493aa430f116d6e9d0fc573b636527 (commit)
       via  b88bd48d79418a4f6743183e251ade79d0a982fe (commit)
       via  2d4b30487c0663ae586c3204fd96031af2357ed1 (commit)
      from  665eeb51fd79abf4e4c4fac25080c46860074de3 (commit)

Summary of changes:
 lib/RT.pm.in                    |    3 ++-
 lib/RT/Interface/Web/Handler.pm |    2 ++
 lib/RT/Interface/Web/Menu.pm    |    3 ++-
 t/web/command_line.t            |    6 +-----
 4 files changed, 7 insertions(+), 7 deletions(-)

- Log -----------------------------------------------------------------
commit 2d4b30487c0663ae586c3204fd96031af2357ed1
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Tue Aug 24 14:45:15 2010 -0400

    Libraries that were not yet using strict

diff --git a/lib/RT/Interface/Web/Handler.pm b/lib/RT/Interface/Web/Handler.pm
index cd54e85..f40f059 100644
--- a/lib/RT/Interface/Web/Handler.pm
+++ b/lib/RT/Interface/Web/Handler.pm
@@ -47,6 +47,8 @@
 # END BPS TAGGED BLOCK }}}
 
 package RT::Interface::Web::Handler;
+use warnings;
+use strict;
 
 use CGI qw/-private_tempfiles/;
 use MIME::Entity;
diff --git a/lib/RT/Interface/Web/Menu.pm b/lib/RT/Interface/Web/Menu.pm
index 2bf5ab2..90a01f8 100644
--- a/lib/RT/Interface/Web/Menu.pm
+++ b/lib/RT/Interface/Web/Menu.pm
@@ -47,7 +47,8 @@
 # END BPS TAGGED BLOCK }}}
 
 package RT::Interface::Web::Menu;
-
+use warnings;
+use strict;
 
 sub new {
     my $class = shift;

commit b88bd48d79418a4f6743183e251ade79d0a982fe
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Tue Aug 24 15:47:18 2010 -0400

    RT.pm now loads Config on first access if it hasn't yet been loaded

diff --git a/lib/RT.pm.in b/lib/RT.pm.in
index 13a0cd5..babfabf 100755
--- a/lib/RT.pm.in
+++ b/lib/RT.pm.in
@@ -169,6 +169,7 @@ sub LoadConfig {
     }
     
     RT::I18N->Init;
+    return $Config;
 }
 
 =head2 Init
@@ -534,7 +535,7 @@ Method can be called as class method.
 
 =cut
 
-sub Config { return $Config }
+sub Config { return $Config || shift->LoadConfig(); }
 
 =head2 DatabaseHandle
 

commit f14eac7b91493aa430f116d6e9d0fc573b636527
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Tue Aug 24 15:48:06 2010 -0400

    remove passing todo test for "no warnings"

diff --git a/t/web/command_line.t b/t/web/command_line.t
index 88cb9df..e6527dc 100644
--- a/t/web/command_line.t
+++ b/t/web/command_line.t
@@ -3,7 +3,7 @@
 use strict;
 use File::Spec ();
 use Test::Expect;
-use RT::Test tests => 295;
+use RT::Test tests => 294;
 my ($baseurl, $m) = RT::Test->started_ok;
 
 use RT::User;
@@ -395,10 +395,6 @@ ok($merge_ticket_B, "Got second ticket to merge id=$merge_ticket_B");
 expect_send("merge $merge_ticket_B $merge_ticket_A", 'Merging the tickets...');
 expect_like(qr/Merge completed/, 'Merged the tickets');
 
-TODO: {
-    local $TODO = "we generate a spurious warning here";
-    $m->no_warnings_ok;
-}
 
 expect_send("show ticket/$merge_ticket_A/history", 'Checking merge on first ticket');
 expect_like(qr/Merged into ticket #$merge_ticket_A by root/, 'Merge recorded in first ticket');

-----------------------------------------------------------------------