[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-542-gc5b8119

[Shawn Moore]

The branch, 3.9-trunk has been updated
       via  c5b8119bf972d17b10264afb612b8db95fe68e13 (commit)
      from  6b7c71b0074bee033ff2fb87e1f9e2798f6f0175 (commit)

Summary of changes:
 t/ticket/linking.t |   23 ++++++++++++++++++++---
 1 files changed, 20 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit c5b8119bf972d17b10264afb612b8db95fe68e13
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Tue Aug 24 18:37:13 2010 -0400

    Catch and test some link warnings

diff --git a/t/ticket/linking.t b/t/ticket/linking.t
index 77eeee0..c0d4304 100644
--- a/t/ticket/linking.t
+++ b/t/ticket/linking.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => '101';
+use RT::Test tests => 106;
 use_ok('RT');
 use_ok('RT::Ticket');
 use_ok('RT::ScripConditions');
@@ -195,9 +195,15 @@ ok ($id,$msg);
 
 diag('try link to itself');
 {
+    my @warnings;
+    local $SIG{__WARN__} = sub {
+        push @warnings, "@_";
+    };
     my ($id, $msg) = $ticket->AddLink(Type => 'RefersTo', Target => $ticket->id);
     ok(!$id, $msg);
     is(link_count($filename), 0, "scrips ok");
+    is(@warnings, 1, "one warning");
+    like("@warnings", qr/Can't link a ticket to itself/);
 }
 
 my $ticket2 = RT::Ticket->new($RT::SystemUser);
@@ -214,8 +220,19 @@ ok ($id,$msg);
 ($id,$msg) = $ticket->AddLink(Type => 'RefersTo', Target => $ticket2->id);
 ok($id,$msg);
 is(link_count($filename), 1, "scrips ok");
-($id,$msg) = $ticket->AddLink(Type => 'RefersTo', Target => -1);
-ok(!$id,$msg);
+
+{
+    my @warnings;
+    local $SIG{__WARN__} = sub {
+        push @warnings, "@_";
+    };
+    ($id,$msg) = $ticket->AddLink(Type => 'RefersTo', Target => -1);
+    ok(!$id,$msg);
+    is(@warnings, 2, "two warnings");
+    like($warnings[0], qr/Could not determine a URI scheme for -1/);
+    like($warnings[1], qr/Couldn't resolve '-1' into a URI/);
+}
+
 ($id,$msg) = $ticket->AddLink(Type => 'RefersTo', Target => $ticket2->id);
 ok($id,$msg);
 is(link_count($filename), 1, "scrips ok");

-----------------------------------------------------------------------