[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-591-g73442b8

[Jesse Vincent]

The branch, 3.9-trunk has been updated
       via  73442b8ff14dba576882b27fa7bd716fb009a996 (commit)
       via  81d2d32ce1d70ce4b4dd655b8fbe2f0c4f378429 (commit)
       via  10c66c0f24b82d5c0e01fcac4c70c0b0af07e640 (commit)
       via  223eab9d17d73cd2e58a568c709990093a06729d (commit)
      from  420aee4a3825b9d4285e9d43b119fe445af26fcd (commit)

Summary of changes:
 lib/RT.pm.in                          |    2 +-
 lib/RT/Base.pm                        |   10 ----------
 lib/RT/Principal_Overlay.pm           |    2 +-
 share/html/Admin/Elements/ShowKeyInfo |    2 +-
 4 files changed, 3 insertions(+), 13 deletions(-)

- Log -----------------------------------------------------------------
commit 223eab9d17d73cd2e58a568c709990093a06729d
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Wed Aug 25 23:39:14 2010 -0400

    remove some very expensive error checking on every call to RT::*->CurrentUser

diff --git a/lib/RT/Base.pm b/lib/RT/Base.pm
index 461bb38..23eb959 100755
--- a/lib/RT/Base.pm
+++ b/lib/RT/Base.pm
@@ -99,16 +99,6 @@ sub CurrentUser {
             if ref $self->{'user'} && $self->{'user'} == $self;
     }
 
-    unless ( ref $self->{'user'} && $self->{'user'}->isa('RT::CurrentUser') ) {
-        my $msg = "$self was created without a CurrentUser."
-            ." Any RT object which is subclass of RT::Base must be created"
-            ." with a RT::CurrentUser or a RT::User object as the first argument.";
-        $msg .= "\n". Carp::longmess() if @_;
-
-        $RT::Logger->error( $msg );
-        return $self->{'user'} = undef;
-    }
-
     return ( $self->{'user'} );
 }
 

commit 10c66c0f24b82d5c0e01fcac4c70c0b0af07e640
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Thu Aug 26 00:12:19 2010 -0400

    Avoid a couple function calls and acl checks on "Disabled" checks

diff --git a/lib/RT/Principal_Overlay.pm b/lib/RT/Principal_Overlay.pm
index ca515b9..e57f6a3 100755
--- a/lib/RT/Principal_Overlay.pm
+++ b/lib/RT/Principal_Overlay.pm
@@ -304,7 +304,7 @@ sub HasRight {
     $args{'EquivObjects'} = [ @{ $args{'EquivObjects'} } ]
         if $args{'EquivObjects'};
 
-    if ( $self->Disabled ) {
+    if ( $self->__Value('Disabled') ) {
         $RT::Logger->debug( "Disabled User #"
               . $self->id
               . " failed access check for "

commit 81d2d32ce1d70ce4b4dd655b8fbe2f0c4f378429
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Thu Aug 26 00:28:08 2010 -0400

    disable lexicon precaching - it's a minimal runtime hit and big startup
    overhead

diff --git a/lib/RT.pm.in b/lib/RT.pm.in
index babfabf..e7b63b0 100755
--- a/lib/RT.pm.in
+++ b/lib/RT.pm.in
@@ -497,7 +497,7 @@ sub InitClasses {
             );
         }
 
-        RT::I18N->LoadLexicons;
+        #RT::I18N->LoadLexicons;
     }
 }
 

commit 73442b8ff14dba576882b27fa7bd716fb009a996
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Thu Aug 26 00:54:30 2010 -0400

    Make sure that the key info cache is actually per process.

diff --git a/share/html/Admin/Elements/ShowKeyInfo b/share/html/Admin/Elements/ShowKeyInfo
index f6aa0ce..8e97f12 100644
--- a/share/html/Admin/Elements/ShowKeyInfo
+++ b/share/html/Admin/Elements/ShowKeyInfo
@@ -78,7 +78,7 @@ $EmailAddress
 $Type => 'public'
 </%ARGS>
 <%INIT>
-return if ($m->cache_self( key => join("||",$EmailAddress,$Type), expires_in => '2 minutes'));
+return if ($m->cache_self( key => join("||",$EmailAddress,$Type, $$), expires_in => '2 minutes'));
 require RT::Crypt::GnuPG;
 my %res = RT::Crypt::GnuPG::GetKeyInfo( $EmailAddress, $Type );
 

-----------------------------------------------------------------------