[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.9.6-325-g57738b8

? sunnavy sunnavy at bestpractical.com
Thu Dec 2 05:33:20 EST 2010


The branch, 3.9-trunk has been updated
       via  57738b819c82ecc95e449f6c080b3be5e01ea52d (commit)
       via  9c469c960715f2a186e5875c79646e614f930fd1 (commit)
       via  24f5df5d7fd75fb9c0ad6d6de9980c5b438135fa (commit)
       via  ccb6d0aa1596587c7a81103654e4bfe7be8af301 (commit)
      from  4bd1d614d6117c7a9c6fc6acf12326ee471c1189 (commit)

Summary of changes:
 lib/RT/CustomField_Overlay.pm               |    4 +++-
 lib/RT/Test/Web.pm                          |    7 +++++++
 share/html/Elements/Tabs                    |   15 +++++++++++----
 t/approval/admincc.t                        |    2 +-
 t/customfields/access_via_queue.t           |    2 +-
 t/customfields/ip.t                         |    2 +-
 t/customfields/iprange.t                    |    2 +-
 t/customfields/iprangev6.t                  |    2 +-
 t/customfields/ipv6.t                       |    2 +-
 t/customfields/sort_order.t                 |    2 +-
 t/i18n/default.t                            |    2 +-
 t/mail/extractsubjecttag.t                  |    2 +-
 t/mail/gateway.t                            |    2 +-
 t/mail/gnupg-bad.t                          |    2 +-
 t/mail/gnupg-incoming.t                     |    2 +-
 t/mail/gnupg-outgoing-encrypted.t           |    2 +-
 t/mail/gnupg-outgoing-plain.t               |    2 +-
 t/mail/gnupg-outgoing-signed.t              |    2 +-
 t/mail/gnupg-outgoing-signed_encrypted.t    |    2 +-
 t/mail/gnupg-realmail.t                     |    2 +-
 t/mail/gnupg-reverification.t               |    2 +-
 t/mail/gnupg-special.t                      |    2 +-
 t/mail/outlook.t                            |    2 +-
 t/ticket/badlinks.t                         |    2 +-
 t/ticket/clicky.t                           |    2 +-
 t/ticket/scrips_batch.t                     |    2 +-
 t/web/admin_groups.t                        |    3 ++-
 t/web/admin_user.t                          |    2 +-
 t/web/attachment_encoding.t                 |    2 +-
 t/web/attachments.t                         |    2 +-
 t/web/basic.t                               |    2 +-
 t/web/cf_access.t                           |    2 +-
 t/web/cf_date.t                             |    2 +-
 t/web/cf_datetime.t                         |    2 +-
 t/web/cf_onqueue.t                          |    2 +-
 t/web/cf_select_one.t                       |    2 +-
 t/web/command_line.t                        |    2 +-
 t/web/command_line_with_unknown_field.t     |    2 +-
 t/web/config_tab_right.t                    |    2 +-
 t/web/crypt-gnupg.t                         |    2 +-
 t/web/custom_frontpage.t                    |    2 +-
 t/web/custom_search.t                       |    2 +-
 t/web/dashboard_with_deleted_saved_search.t |    2 +-
 t/web/dashboards-groups.t                   |    2 +-
 t/web/dashboards-permissions.t              |    2 +-
 t/web/dashboards.t                          |    2 +-
 t/web/gnupg-select-keys-on-create.t         |    2 +-
 t/web/gnupg-select-keys-on-update.t         |    2 +-
 t/web/gnupg-tickyboxes.t                    |    2 +-
 t/web/googleish_search.t                    |    2 +-
 t/web/html_template.t                       |    2 +-
 t/web/offline_messages_utf8.t               |    2 +-
 t/web/offline_utf8.t                        |    2 +-
 t/web/query_log.t                           |    2 +-
 t/web/queue_caching.t                       |    2 +-
 t/web/quickcreate.t                         |    2 +-
 t/web/quicksearch.t                         |    2 +-
 t/web/redirect-after-login.t                |    2 +-
 t/web/requestor_groups_edit_link.t          |    2 +-
 t/web/requestor_groups_limit.t              |    2 +-
 t/web/rest-non-ascii-subject.t              |    2 +-
 t/web/rest.t                                |    2 +-
 t/web/rights.t                              |    2 +-
 t/web/rights1.t                             |    2 +-
 t/web/saved_search_chart.t                  |    2 +-
 t/web/saved_search_permissions.t            |    2 +-
 t/web/saved_search_update.t                 |    2 +-
 t/web/search_bulk_update_links.t            |    2 +-
 t/web/search_rss.t                          |    2 +-
 t/web/template.t                            |    2 +-
 t/web/ticket-create-utf8.t                  |    2 +-
 t/web/ticket_forward.t                      |    2 +-
 t/web/ticket_modify_all.t                   |    2 +-
 t/web/ticket_owner.t                        |    2 +-
 t/web/ticket_owner_autocomplete.t           |    2 +-
 t/web/ticket_seen.t                         |    2 +-
 t/web/ticket_txn_content.t                  |    2 +-
 t/web/ticket_update_without_content.t       |    2 +-
 t/web/unlimited_search.t                    |    2 +-
 t/web/walk.t                                |    2 +-
 t/web/watching-queues.t                     |    2 +-
 81 files changed, 100 insertions(+), 83 deletions(-)

- Log -----------------------------------------------------------------
commit ccb6d0aa1596587c7a81103654e4bfe7be8af301
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Dec 2 17:34:25 2010 +0800

    no warnings test in the end

diff --git a/lib/RT/Test/Web.pm b/lib/RT/Test/Web.pm
index fb7fbeb..a77a8d7 100644
--- a/lib/RT/Test/Web.pm
+++ b/lib/RT/Test/Web.pm
@@ -338,4 +338,11 @@ sub custom_field_input {
     return $res;
 }
 
+sub DESTROY {
+    my $self = shift;
+    if ( @RT::Test::SERVERS && !$RT::Test::Web::DESTROY++ ) {
+        $self->no_warnings_ok;
+    }
+}
+
 1;
diff --git a/t/approval/admincc.t b/t/approval/admincc.t
index 67bf5af..b439296 100644
--- a/t/approval/admincc.t
+++ b/t/approval/admincc.t
@@ -9,7 +9,7 @@ BEGIN {
 
 
 use RT;
-use RT::Test tests => 60;
+use RT::Test tests => 62;
 use RT::Test::Email;
 
 RT->Config->Set( LogToScreen => 'debug' );
diff --git a/t/customfields/access_via_queue.t b/t/customfields/access_via_queue.t
index b6a1abe..690e177 100644
--- a/t/customfields/access_via_queue.t
+++ b/t/customfields/access_via_queue.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 35;
+use RT::Test nodata => 1, tests => 37;
 use RT::Ticket;
 use RT::CustomField;
 
diff --git a/t/customfields/ip.t b/t/customfields/ip.t
index a7616d6..f73e63f 100644
--- a/t/customfields/ip.t
+++ b/t/customfields/ip.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 71;
+use RT::Test tests => 73;
 
 my ( $baseurl, $agent ) = RT::Test->started_ok;
 ok( $agent->login, 'log in' );
diff --git a/t/customfields/iprange.t b/t/customfields/iprange.t
index b8cc6ea..118d23c 100644
--- a/t/customfields/iprange.t
+++ b/t/customfields/iprange.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 131;
+use RT::Test tests => 133;
 
 my ($baseurl, $agent) =RT::Test->started_ok;
 ok( $agent->login, 'log in' );
diff --git a/t/customfields/iprangev6.t b/t/customfields/iprangev6.t
index 7c2f645..06b59e4 100644
--- a/t/customfields/iprangev6.t
+++ b/t/customfields/iprangev6.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 153;
+use RT::Test tests => 155;
 
 my ($baseurl, $agent) =RT::Test->started_ok;
 ok( $agent->login, 'log in' );
diff --git a/t/customfields/ipv6.t b/t/customfields/ipv6.t
index 2eb08c4..5054fb2 100644
--- a/t/customfields/ipv6.t
+++ b/t/customfields/ipv6.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 96;
+use RT::Test tests => 98;
 
 my ( $baseurl, $agent ) = RT::Test->started_ok;
 ok( $agent->login, 'log in' );
diff --git a/t/customfields/sort_order.t b/t/customfields/sort_order.t
index d210f31..2453a7c 100644
--- a/t/customfields/sort_order.t
+++ b/t/customfields/sort_order.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 18;
+use RT::Test tests => 20;
 use RT::Ticket;
 use RT::CustomField;
 
diff --git a/t/i18n/default.t b/t/i18n/default.t
index b8c6d78..764a67f 100644
--- a/t/i18n/default.t
+++ b/t/i18n/default.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 8;
+use RT::Test nodata => 1, tests => 10;
 
 my ($baseurl, $m) = RT::Test->started_ok;
 $m->get_ok('/');
diff --git a/t/mail/extractsubjecttag.t b/t/mail/extractsubjecttag.t
index 8a09dfb..c9f4615 100644
--- a/t/mail/extractsubjecttag.t
+++ b/t/mail/extractsubjecttag.t
@@ -3,7 +3,7 @@ use strict;
 use warnings;
 use utf8;
 
-use RT::Test tests => 14;
+use RT::Test tests => 16;
 
 
 my ($baseurl, $m) = RT::Test->started_ok;
diff --git a/t/mail/gateway.t b/t/mail/gateway.t
index d7ab73c..2401a52 100644
--- a/t/mail/gateway.t
+++ b/t/mail/gateway.t
@@ -57,7 +57,7 @@ use strict;
 use warnings;
 
 
-use RT::Test config => 'Set( $UnsafeEmailCommands, 1);', tests => 219, actual_server => 1;
+use RT::Test config => 'Set( $UnsafeEmailCommands, 1);', tests => 221, actual_server => 1;
 my ($baseurl, $m) = RT::Test->started_ok;
 
 use RT::Tickets;
diff --git a/t/mail/gnupg-bad.t b/t/mail/gnupg-bad.t
index 83790b6..c9b28c9 100644
--- a/t/mail/gnupg-bad.t
+++ b/t/mail/gnupg-bad.t
@@ -3,7 +3,7 @@ use strict;
 use warnings;
 
 use RT::Test::GnuPG
-  tests         => 5,
+  tests         => 7,
   gnupg_options => {
     passphrase => 'rt-test',
     homedir => RT::Test::get_abs_relocatable_dir(
diff --git a/t/mail/gnupg-incoming.t b/t/mail/gnupg-incoming.t
index 4e362be..e591add 100644
--- a/t/mail/gnupg-incoming.t
+++ b/t/mail/gnupg-incoming.t
@@ -11,7 +11,7 @@ BEGIN {
 }
 
 use RT::Test::GnuPG
-  tests         => 39,
+  tests         => 41,
   actual_server => 1,
   gnupg_options => {
     passphrase => 'rt-test',
diff --git a/t/mail/gnupg-outgoing-encrypted.t b/t/mail/gnupg-outgoing-encrypted.t
index 668c3a2..4f2a28f 100644
--- a/t/mail/gnupg-outgoing-encrypted.t
+++ b/t/mail/gnupg-outgoing-encrypted.t
@@ -3,7 +3,7 @@ use strict;
 use warnings;
 
 use RT::Test::GnuPG
-  tests         => 101,
+  tests         => 103,
   gnupg_options => {
     passphrase    => 'rt-test',
     'trust-model' => 'always',
diff --git a/t/mail/gnupg-outgoing-plain.t b/t/mail/gnupg-outgoing-plain.t
index 05ed171..ee9a8ac 100644
--- a/t/mail/gnupg-outgoing-plain.t
+++ b/t/mail/gnupg-outgoing-plain.t
@@ -3,7 +3,7 @@ use strict;
 use warnings;
 
 use RT::Test::GnuPG
-  tests         => 101,
+  tests         => 103,
   gnupg_options => {
     passphrase    => 'rt-test',
     'trust-model' => 'always',
diff --git a/t/mail/gnupg-outgoing-signed.t b/t/mail/gnupg-outgoing-signed.t
index df5d2fc..2ea20a2 100644
--- a/t/mail/gnupg-outgoing-signed.t
+++ b/t/mail/gnupg-outgoing-signed.t
@@ -3,7 +3,7 @@ use strict;
 use warnings;
 
 use RT::Test::GnuPG
-  tests         => 101,
+  tests         => 103,
   gnupg_options => {
     passphrase    => 'rt-test',
     'trust-model' => 'always',
diff --git a/t/mail/gnupg-outgoing-signed_encrypted.t b/t/mail/gnupg-outgoing-signed_encrypted.t
index 9f1a73b..0b82cf1 100644
--- a/t/mail/gnupg-outgoing-signed_encrypted.t
+++ b/t/mail/gnupg-outgoing-signed_encrypted.t
@@ -3,7 +3,7 @@ use strict;
 use warnings;
 
 use RT::Test::GnuPG
-  tests         => 101,
+  tests         => 103,
   gnupg_options => {
     passphrase    => 'rt-test',
     'trust-model' => 'always',
diff --git a/t/mail/gnupg-realmail.t b/t/mail/gnupg-realmail.t
index 68a3a3c..7d1dbca 100644
--- a/t/mail/gnupg-realmail.t
+++ b/t/mail/gnupg-realmail.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test::GnuPG tests => 196, gnupg_options => { passphrase => 'rt-test' };
+use RT::Test::GnuPG tests => 198, gnupg_options => { passphrase => 'rt-test' };
 
 use Digest::MD5 qw(md5_hex);
 
diff --git a/t/mail/gnupg-reverification.t b/t/mail/gnupg-reverification.t
index 198ec2a..03c00e3 100644
--- a/t/mail/gnupg-reverification.t
+++ b/t/mail/gnupg-reverification.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test::GnuPG tests => 214, gnupg_options => { passphrase => 'rt-test' };
+use RT::Test::GnuPG tests => 216, gnupg_options => { passphrase => 'rt-test' };
 
 diag "load Everyone group";
 my $everyone;
diff --git a/t/mail/gnupg-special.t b/t/mail/gnupg-special.t
index cc8b7d3..d001091 100644
--- a/t/mail/gnupg-special.t
+++ b/t/mail/gnupg-special.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test::GnuPG tests => 11, gnupg_options => { passphrase => 'rt-test' };
+use RT::Test::GnuPG tests => 13, gnupg_options => { passphrase => 'rt-test' };
 
 RT::Test->import_gnupg_key('rt-recipient at example.com');
 RT::Test->import_gnupg_key('rt-test at example.com', 'public');
diff --git a/t/mail/outlook.t b/t/mail/outlook.t
index 836920a..4a566a1 100644
--- a/t/mail/outlook.t
+++ b/t/mail/outlook.t
@@ -56,7 +56,7 @@ rt-mailgate - Mail interface to RT3.
 use strict;
 use warnings;
 
-use RT::Test tests => 43;
+use RT::Test tests => 45;
 my ($baseurl, $m) = RT::Test->started_ok;
 # 12.0 is outlook 2007, 14.0 is 2010
 for my $mailer ( 'Microsoft Office Outlook 12.0', 'Microsoft Outlook 14.0' ) {
diff --git a/t/ticket/badlinks.t b/t/ticket/badlinks.t
index 5018b0c..71ab739 100644
--- a/t/ticket/badlinks.t
+++ b/t/ticket/badlinks.t
@@ -1,7 +1,7 @@
 #!/usr/bin/env perl
 use strict;
 use warnings;
-use RT::Test tests => 12;
+use RT::Test tests => 14;
 
 my ($baseurl, $m) = RT::Test->started_ok;
 ok($m->login, "Logged in");
diff --git a/t/ticket/clicky.t b/t/ticket/clicky.t
index a6af7f6..85e6690 100644
--- a/t/ticket/clicky.t
+++ b/t/ticket/clicky.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 use Test::More;
-use RT::Test tests => 18;
+use RT::Test tests => 20;
 
 my $plain = MIME::Entity->build(
     Subject => 'plain mime',
diff --git a/t/ticket/scrips_batch.t b/t/ticket/scrips_batch.t
index 1cfc732..3edac53 100644
--- a/t/ticket/scrips_batch.t
+++ b/t/ticket/scrips_batch.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => '17';
+use RT::Test tests => 19;
 use_ok('RT');
 use_ok('RT::Ticket');
 
diff --git a/t/web/admin_groups.t b/t/web/admin_groups.t
index 45c1b9f..21587ba 100644
--- a/t/web/admin_groups.t
+++ b/t/web/admin_groups.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 25;
+use RT::Test tests => 27;
 
 my ( $url, $m ) = RT::Test->started_ok;
 ok( $m->login(), 'logged in' );
diff --git a/t/web/admin_user.t b/t/web/admin_user.t
index 7f34f11..fde075f 100644
--- a/t/web/admin_user.t
+++ b/t/web/admin_user.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 5;
+use RT::Test tests => 7;
 
 my ( $url, $m ) = RT::Test->started_ok;
 ok( $m->login(), 'logged in' );
diff --git a/t/web/attachment_encoding.t b/t/web/attachment_encoding.t
index fe823eb..38e4034 100644
--- a/t/web/attachment_encoding.t
+++ b/t/web/attachment_encoding.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 28;
+use RT::Test tests => 30;
 use Encode;
 my ( $baseurl, $m ) = RT::Test->started_ok;
 ok $m->login, 'logged in as root';
diff --git a/t/web/attachments.t b/t/web/attachments.t
index 5a0d764..6f175f6 100644
--- a/t/web/attachments.t
+++ b/t/web/attachments.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use strict;
 
-use RT::Test tests => 14;
+use RT::Test tests => 16;
 
 use constant LogoFile => $RT::MasonComponentRoot .'/NoAuth/images/bpslogo.png';
 use constant FaviconFile => $RT::MasonComponentRoot .'/NoAuth/images/favicon.png';
diff --git a/t/web/basic.t b/t/web/basic.t
index 3328155..31e28c4 100644
--- a/t/web/basic.t
+++ b/t/web/basic.t
@@ -4,7 +4,7 @@ use strict;
 use warnings;
 use Encode;
 
-use RT::Test tests => 21;
+use RT::Test tests => 23;
 
 my ($baseurl, $agent) = RT::Test->started_ok;
 
diff --git a/t/web/cf_access.t b/t/web/cf_access.t
index 966b05f..0eaf7b3 100644
--- a/t/web/cf_access.t
+++ b/t/web/cf_access.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use strict;
 
-use RT::Test tests => 23;
+use RT::Test tests => 25;
 
 my ($baseurl, $m) = RT::Test->started_ok;
 
diff --git a/t/web/cf_date.t b/t/web/cf_date.t
index be421a7..887aa42 100644
--- a/t/web/cf_date.t
+++ b/t/web/cf_date.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 33;
+use RT::Test tests => 35;
 
 my ( $baseurl, $m ) = RT::Test->started_ok;
 ok $m->login, 'logged in as root';
diff --git a/t/web/cf_datetime.t b/t/web/cf_datetime.t
index 95f5c17..2fb0eaa 100644
--- a/t/web/cf_datetime.t
+++ b/t/web/cf_datetime.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 42;
+use RT::Test tests => 44;
 RT->Config->Set( 'Timezone' => 'EST5EDT' ); # -04:00
 
 my ($baseurl, $m) = RT::Test->started_ok;
diff --git a/t/web/cf_onqueue.t b/t/web/cf_onqueue.t
index 2c020b7..422eeff 100644
--- a/t/web/cf_onqueue.t
+++ b/t/web/cf_onqueue.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use strict;
 
-use RT::Test tests => 12;
+use RT::Test tests => 14;
 my ($baseurl, $m) = RT::Test->started_ok;
 
 ok $m->login, 'logged in';
diff --git a/t/web/cf_select_one.t b/t/web/cf_select_one.t
index 86f05cd..15fe416 100644
--- a/t/web/cf_select_one.t
+++ b/t/web/cf_select_one.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 43;
+use RT::Test tests => 45;
 
 my ($baseurl, $m) = RT::Test->started_ok;
 ok $m->login, 'logged in as root';
diff --git a/t/web/command_line.t b/t/web/command_line.t
index 5040d7d..22edc86 100644
--- a/t/web/command_line.t
+++ b/t/web/command_line.t
@@ -3,7 +3,7 @@
 use strict;
 use File::Spec ();
 use Test::Expect;
-use RT::Test tests => 295, actual_server => 1;
+use RT::Test tests => 297, actual_server => 1;
 my ($baseurl, $m) = RT::Test->started_ok;
 
 use RT::User;
diff --git a/t/web/command_line_with_unknown_field.t b/t/web/command_line_with_unknown_field.t
index 150d3c0..5557e10 100644
--- a/t/web/command_line_with_unknown_field.t
+++ b/t/web/command_line_with_unknown_field.t
@@ -3,7 +3,7 @@
 use strict;
 use File::Spec ();
 use Test::Expect;
-use RT::Test tests => 10, actual_server => 1;
+use RT::Test tests => 12, actual_server => 1;
 my ($baseurl, $m) = RT::Test->started_ok;
 my $rt_tool_path = "$RT::BinPath/rt";
 
diff --git a/t/web/config_tab_right.t b/t/web/config_tab_right.t
index 9f12754..361506c 100644
--- a/t/web/config_tab_right.t
+++ b/t/web/config_tab_right.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 8;
+use RT::Test nodata => 1, tests => 10;
 
 my ($uname, $upass, $user) = ('tester', 'tester');
 {
diff --git a/t/web/crypt-gnupg.t b/t/web/crypt-gnupg.t
index 16f2e08..9dd3d5c 100644
--- a/t/web/crypt-gnupg.t
+++ b/t/web/crypt-gnupg.t
@@ -2,7 +2,7 @@
 use strict;
 
 use RT::Test::GnuPG
-  tests         => 100,
+  tests         => 102,
   gnupg_options => {
     passphrase    => 'recipient',
     'trust-model' => 'always',
diff --git a/t/web/custom_frontpage.t b/t/web/custom_frontpage.t
index bb3b0d6..893ddd2 100644
--- a/t/web/custom_frontpage.t
+++ b/t/web/custom_frontpage.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use strict;
 
-use RT::Test tests => 7;
+use RT::Test tests => 9;
 my ($baseurl, $m) = RT::Test->started_ok;
 
 my $url = $m->rt_base_url;
diff --git a/t/web/custom_search.t b/t/web/custom_search.t
index bea8f31..f8fde25 100644
--- a/t/web/custom_search.t
+++ b/t/web/custom_search.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use strict;
 
-use RT::Test tests => 11;
+use RT::Test tests => 13;
 my ($baseurl, $m) = RT::Test->started_ok;
 my $url = $m->rt_base_url;
 
diff --git a/t/web/dashboard_with_deleted_saved_search.t b/t/web/dashboard_with_deleted_saved_search.t
index 60c0179..4cd7fea 100644
--- a/t/web/dashboard_with_deleted_saved_search.t
+++ b/t/web/dashboard_with_deleted_saved_search.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 18;
+use RT::Test tests => 20;
 my ( $url, $m ) = RT::Test->started_ok;
 ok( $m->login, 'logged in' );
 
diff --git a/t/web/dashboards-groups.t b/t/web/dashboards-groups.t
index 776e9b5..a269beb 100644
--- a/t/web/dashboards-groups.t
+++ b/t/web/dashboards-groups.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use strict;
 
-use RT::Test nodata => 1, tests => 33;
+use RT::Test nodata => 1, tests => 35;
 my ($baseurl, $m) = RT::Test->started_ok;
 
 my $url = $m->rt_base_url;
diff --git a/t/web/dashboards-permissions.t b/t/web/dashboards-permissions.t
index dc66d8a..c0a0b11 100644
--- a/t/web/dashboards-permissions.t
+++ b/t/web/dashboards-permissions.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 6;
+use RT::Test nodata => 1, tests => 8;
 my ($baseurl, $m) = RT::Test->started_ok;
 
 my $url = $m->rt_base_url;
diff --git a/t/web/dashboards.t b/t/web/dashboards.t
index 3550862..ae3af6e 100644
--- a/t/web/dashboards.t
+++ b/t/web/dashboards.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use strict;
 
-use RT::Test tests => 108;
+use RT::Test tests => 110;
 my ($baseurl, $m) = RT::Test->started_ok;
 
 my $url = $m->rt_base_url;
diff --git a/t/web/gnupg-select-keys-on-create.t b/t/web/gnupg-select-keys-on-create.t
index 377bc28..cf27e48 100644
--- a/t/web/gnupg-select-keys-on-create.t
+++ b/t/web/gnupg-select-keys-on-create.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test::GnuPG tests => 77, gnupg_options => { passphrase => 'rt-test' };
+use RT::Test::GnuPG tests => 79, gnupg_options => { passphrase => 'rt-test' };
 use RT::Action::SendEmail;
 
 my $queue = RT::Test->load_or_create_queue(
diff --git a/t/web/gnupg-select-keys-on-update.t b/t/web/gnupg-select-keys-on-update.t
index 2f4cdbf..4842dcd 100644
--- a/t/web/gnupg-select-keys-on-update.t
+++ b/t/web/gnupg-select-keys-on-update.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test::GnuPG tests => 84, gnupg_options => { passphrase => 'rt-test' };
+use RT::Test::GnuPG tests => 86, gnupg_options => { passphrase => 'rt-test' };
 
 use RT::Action::SendEmail;
 
diff --git a/t/web/gnupg-tickyboxes.t b/t/web/gnupg-tickyboxes.t
index 29f2b4e..9445397 100644
--- a/t/web/gnupg-tickyboxes.t
+++ b/t/web/gnupg-tickyboxes.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test::GnuPG tests => 20, gnupg_options => { passphrase => 'rt-test' };
+use RT::Test::GnuPG tests => 22, gnupg_options => { passphrase => 'rt-test' };
 
 use RT::Action::SendEmail;
 
diff --git a/t/web/googleish_search.t b/t/web/googleish_search.t
index 1fce804..2e786be 100644
--- a/t/web/googleish_search.t
+++ b/t/web/googleish_search.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 84, config => 'Set( %FullTextSearch, Enable => 1, Indexed => 0 );';
+use RT::Test tests => 86, config => 'Set( %FullTextSearch, Enable => 1, Indexed => 0 );';
 my ($baseurl, $m) = RT::Test->started_ok;
 my $url = $m->rt_base_url;
 
diff --git a/t/web/html_template.t b/t/web/html_template.t
index f46158c..662a26b 100644
--- a/t/web/html_template.t
+++ b/t/web/html_template.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 17;
+use RT::Test tests => 19;
 use Encode;
 my ( $baseurl, $m ) = RT::Test->started_ok;
 ok $m->login, 'logged in as root';
diff --git a/t/web/offline_messages_utf8.t b/t/web/offline_messages_utf8.t
index 5a91bd3..6894d6b 100644
--- a/t/web/offline_messages_utf8.t
+++ b/t/web/offline_messages_utf8.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 6;
+use RT::Test tests => 8;
 use File::Temp qw/tempfile/;
 use Encode;
 use RT::Ticket;
diff --git a/t/web/offline_utf8.t b/t/web/offline_utf8.t
index 4a5fb8e..4eb3953 100644
--- a/t/web/offline_utf8.t
+++ b/t/web/offline_utf8.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 7;
+use RT::Test tests => 9;
 use utf8;
 
 use File::Temp qw/tempfile/;
diff --git a/t/web/query_log.t b/t/web/query_log.t
index 0faa2cf..25edfd2 100644
--- a/t/web/query_log.t
+++ b/t/web/query_log.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 7;
+use RT::Test tests => 9;
 
 RT->Config->Set(StatementLog => 1);
 
diff --git a/t/web/queue_caching.t b/t/web/queue_caching.t
index 57ac061..d90aacb 100644
--- a/t/web/queue_caching.t
+++ b/t/web/queue_caching.t
@@ -1,6 +1,6 @@
 use strict;
 use warnings;
-use RT::Test tests => 34;
+use RT::Test tests => 36;
 
 # make an initial queue, so we have more than 1
 my $original_test_queue = new_queue("Test$$");
diff --git a/t/web/quickcreate.t b/t/web/quickcreate.t
index 3da0ccb..0cb856c 100644
--- a/t/web/quickcreate.t
+++ b/t/web/quickcreate.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 8;
+use RT::Test tests => 10;
 
 RT->Config->Set('DisplayTicketAfterQuickCreate' => 0);
 
diff --git a/t/web/quicksearch.t b/t/web/quicksearch.t
index 833d35d..8cc084c 100644
--- a/t/web/quicksearch.t
+++ b/t/web/quicksearch.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 7;
+use RT::Test tests => 9;
 my ($baseurl, $m) = RT::Test->started_ok;
 my $url = $m->rt_base_url;
 
diff --git a/t/web/redirect-after-login.t b/t/web/redirect-after-login.t
index db266c0..669b01e 100644
--- a/t/web/redirect-after-login.t
+++ b/t/web/redirect-after-login.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 120;
+use RT::Test tests => 122;
 
 RT->Config->Set( GnuPG => { Enable => 0 } );
 
diff --git a/t/web/requestor_groups_edit_link.t b/t/web/requestor_groups_edit_link.t
index 3f031be..9d1fefd 100644
--- a/t/web/requestor_groups_edit_link.t
+++ b/t/web/requestor_groups_edit_link.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 9;
+use RT::Test tests => 11;
 
 RT->Config->Set( ShowMoreAboutPrivilegedUsers    => 1 );
 
diff --git a/t/web/requestor_groups_limit.t b/t/web/requestor_groups_limit.t
index c8aeeac..7987a13 100644
--- a/t/web/requestor_groups_limit.t
+++ b/t/web/requestor_groups_limit.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 9;
+use RT::Test tests => 11;
 
 diag "set groups limit to 1";
 RT->Config->Set( ShowMoreAboutPrivilegedUsers    => 1 );
diff --git a/t/web/rest-non-ascii-subject.t b/t/web/rest-non-ascii-subject.t
index 3cffc7a..d7a89af 100644
--- a/t/web/rest-non-ascii-subject.t
+++ b/t/web/rest-non-ascii-subject.t
@@ -2,7 +2,7 @@
 # Test ticket creation with REST using non ascii subject
 use strict;
 use warnings;
-use RT::Test tests => 7;
+use RT::Test tests => 9;
 
 use Encode;
 # \x{XX} where XX is less than 255 is not treated as unicode code point
diff --git a/t/web/rest.t b/t/web/rest.t
index 2f648dd..5e7194c 100644
--- a/t/web/rest.t
+++ b/t/web/rest.t
@@ -1,7 +1,7 @@
 #!/usr/bin/env perl
 use strict;
 use warnings;
-use RT::Test tests => 16;
+use RT::Test tests => 18;
 
 my ($baseurl, $m) = RT::Test->started_ok;
 
diff --git a/t/web/rights.t b/t/web/rights.t
index 63a0878..9a5f358 100644
--- a/t/web/rights.t
+++ b/t/web/rights.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 12;
+use RT::Test tests => 14;
 
 my ($baseurl, $m) = RT::Test->started_ok;
 ok $m->login, "logged in";
diff --git a/t/web/rights1.t b/t/web/rights1.t
index aaa2820..e127877 100644
--- a/t/web/rights1.t
+++ b/t/web/rights1.t
@@ -2,7 +2,7 @@
 use strict;
 use HTTP::Cookies;
 
-use RT::Test nodata => 1, tests => 29;
+use RT::Test nodata => 1, tests => 31;
 my ($baseurl, $agent) = RT::Test->started_ok;
 
 # Create a user with basically no rights, to start.
diff --git a/t/web/saved_search_chart.t b/t/web/saved_search_chart.t
index 0384f11..2821f07 100644
--- a/t/web/saved_search_chart.t
+++ b/t/web/saved_search_chart.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 19;
+use RT::Test tests => 21;
 my ( $url, $m ) = RT::Test->started_ok;
 use RT::Attribute;
 my $search = RT::Attribute->new(RT->SystemUser);
diff --git a/t/web/saved_search_permissions.t b/t/web/saved_search_permissions.t
index 870b265..5cae30b 100644
--- a/t/web/saved_search_permissions.t
+++ b/t/web/saved_search_permissions.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 10;
+use RT::Test tests => 12;
 my $user = RT::User->new(RT->SystemUser);
 ok(
     $user->Create(
diff --git a/t/web/saved_search_update.t b/t/web/saved_search_update.t
index 9b2724e..dfb18d4 100644
--- a/t/web/saved_search_update.t
+++ b/t/web/saved_search_update.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 16;
+use RT::Test tests => 18;
 
 my $root = RT::User->new( $RT::SystemUser );
 $root->Load('root');
diff --git a/t/web/search_bulk_update_links.t b/t/web/search_bulk_update_links.t
index 9307dda..7d150a6 100644
--- a/t/web/search_bulk_update_links.t
+++ b/t/web/search_bulk_update_links.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 45;
+use RT::Test tests => 47;
 my ( $url, $m ) = RT::Test->started_ok;
 ok( $m->login, 'logged in' );
 
diff --git a/t/web/search_rss.t b/t/web/search_rss.t
index 67cae1f..95de931 100644
--- a/t/web/search_rss.t
+++ b/t/web/search_rss.t
@@ -2,7 +2,7 @@
 
 use strict;
 
-use RT::Test tests => 36;
+use RT::Test tests => 38;
 my ($baseurl, $agent) = RT::Test->started_ok;
 
 my $ticket = RT::Ticket->new(RT->SystemUser);
diff --git a/t/web/template.t b/t/web/template.t
index 50c93e3..40a5366 100644
--- a/t/web/template.t
+++ b/t/web/template.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 17;
+use RT::Test tests => 19;
 
 my $user_a = RT::Test->load_or_create_user(
     Name => 'user_a', Password => 'password',
diff --git a/t/web/ticket-create-utf8.t b/t/web/ticket-create-utf8.t
index 324b4e9..8d36bd1 100644
--- a/t/web/ticket-create-utf8.t
+++ b/t/web/ticket-create-utf8.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 41;
+use RT::Test tests => 43;
 
 use Encode;
 
diff --git a/t/web/ticket_forward.t b/t/web/ticket_forward.t
index 7e72818..c5a4d47 100644
--- a/t/web/ticket_forward.t
+++ b/t/web/ticket_forward.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 23;
+use RT::Test tests => 25;
 use File::Temp 'tempfile';
 use File::Spec;
 my ( $att_fh, $att_file ) =
diff --git a/t/web/ticket_modify_all.t b/t/web/ticket_modify_all.t
index 2330021..351f8a5 100644
--- a/t/web/ticket_modify_all.t
+++ b/t/web/ticket_modify_all.t
@@ -1,7 +1,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 9;
+use RT::Test tests => 11;
 
 my $ticket = RT::Test->create_ticket(
     Subject => 'test bulk update',
diff --git a/t/web/ticket_owner.t b/t/web/ticket_owner.t
index 864817e..aa8b876 100644
--- a/t/web/ticket_owner.t
+++ b/t/web/ticket_owner.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 101;
+use RT::Test nodata => 1, tests => 103;
 
 my $queue = RT::Test->load_or_create_queue( Name => 'Regression' );
 ok $queue && $queue->id, 'loaded or created queue';
diff --git a/t/web/ticket_owner_autocomplete.t b/t/web/ticket_owner_autocomplete.t
index 282101e..787c8fd 100644
--- a/t/web/ticket_owner_autocomplete.t
+++ b/t/web/ticket_owner_autocomplete.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 41;
+use RT::Test nodata => 1, tests => 43;
 use JSON qw(from_json);
 
 my $queue = RT::Test->load_or_create_queue( Name => 'Regression' );
diff --git a/t/web/ticket_seen.t b/t/web/ticket_seen.t
index b65f803..8dacaf5 100644
--- a/t/web/ticket_seen.t
+++ b/t/web/ticket_seen.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test nodata => 1, tests => 21, config => 'Set($ShowUnreadMessageNotifications, 1);';
+use RT::Test nodata => 1, tests => 23, config => 'Set($ShowUnreadMessageNotifications, 1);';
 
 my $queue = RT::Test->load_or_create_queue( Name => 'Regression' );
 ok $queue && $queue->id, 'loaded or created queue';
diff --git a/t/web/ticket_txn_content.t b/t/web/ticket_txn_content.t
index 8ea4485..176840c 100644
--- a/t/web/ticket_txn_content.t
+++ b/t/web/ticket_txn_content.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use strict;
 
-use RT::Test tests => 37;
+use RT::Test tests => 39;
 use File::Temp 'tempfile';
 use File::Spec;
 my ( $plain_fh, $plain_file ) =
diff --git a/t/web/ticket_update_without_content.t b/t/web/ticket_update_without_content.t
index 26e5e44..54f0c5a 100644
--- a/t/web/ticket_update_without_content.t
+++ b/t/web/ticket_update_without_content.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 10;
+use RT::Test tests => 12;
 my ( $url, $m ) = RT::Test->started_ok;
 
 # merged tickets still show up in search
diff --git a/t/web/unlimited_search.t b/t/web/unlimited_search.t
index c55ef78..988a291 100644
--- a/t/web/unlimited_search.t
+++ b/t/web/unlimited_search.t
@@ -2,7 +2,7 @@
 
 use strict;
 
-use RT::Test tests => 83;
+use RT::Test tests => 85;
 my ($baseurl, $agent) = RT::Test->started_ok;
 
 my $ticket = RT::Ticket->new(RT->SystemUser);
diff --git a/t/web/walk.t b/t/web/walk.t
index b5e8c9b..5a8c075 100644
--- a/t/web/walk.t
+++ b/t/web/walk.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 93;
+use RT::Test tests => 95;
 
 my ( $baseurl, $m ) = RT::Test->started_ok;
 
diff --git a/t/web/watching-queues.t b/t/web/watching-queues.t
index 4d9ec6b..9e79804 100644
--- a/t/web/watching-queues.t
+++ b/t/web/watching-queues.t
@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 use strict;
 
-use RT::Test tests => 75;
+use RT::Test tests => 77;
 use Web::Scraper;
 my ($baseurl, $m) = RT::Test->started_ok;
 

commit 24f5df5d7fd75fb9c0ad6d6de9980c5b438135fa
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Dec 2 18:28:16 2010 +0800

    BasedOn may be empty

diff --git a/lib/RT/CustomField_Overlay.pm b/lib/RT/CustomField_Overlay.pm
index a2d56c3..cd51b22 100755
--- a/lib/RT/CustomField_Overlay.pm
+++ b/lib/RT/CustomField_Overlay.pm
@@ -1671,7 +1671,9 @@ sub BasedOnObj {
     my $self = shift;
 
     my $obj = RT::CustomField->new( $self->CurrentUser );
-    $obj->Load( $self->BasedOn );
+    if ( $self->BasedOn ) {
+        $obj->Load( $self->BasedOn );
+    }
     return $obj;
 }
 

commit 9c469c960715f2a186e5875c79646e614f930fd1
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Dec 2 18:29:08 2010 +0800

    capture the warning

diff --git a/t/web/admin_groups.t b/t/web/admin_groups.t
index 21587ba..e41c8d8 100644
--- a/t/web/admin_groups.t
+++ b/t/web/admin_groups.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use RT::Test tests => 27;
+use RT::Test tests => 29;
 
 my ( $url, $m ) = RT::Test->started_ok;
 ok( $m->login(), 'logged in' );
@@ -42,6 +42,7 @@ ok( $m->login(), 'logged in' );
     $m->content_contains('RT Error', 'found error title');
     $m->content_contains('Group could not be created', 'found results');
     $m->content_like(qr/Group name .+? is already in use/, 'found message');
+    $m->warning_like(qr/Group name .+? is already in use/, 'found warning');
 }
 
 {

commit 57738b819c82ecc95e449f6c080b3be5e01ea52d
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Dec 2 18:30:46 2010 +0800

    in case id is not a number

diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
index ff54aa4..8c00c09 100755
--- a/share/html/Elements/Tabs
+++ b/share/html/Elements/Tabs
@@ -240,7 +240,11 @@ if ( $request_path !~ qr{^/SelfService/} ) {
     }
 
     if ( $request_path =~ qr{^/Admin/Queues} ) {
-        if ( my $id = $m->request_args->{'id'} || $m->request_args->{'Queue'} ) {
+        if ( $m->request_args->{'id'} && $m->request_args->{'id'} =~ /^\d+$/ 
+                ||
+              $m->request_args->{'Queue'} && $m->request_args->{'Queue'} =~ /^\d+$/ 
+                ) {
+            my $id = $m->request_args->{'id'} || $m->request_args->{'Queue'};
             my $queue_obj = RT::Queue->new( $session{'CurrentUser'} );
             $queue_obj->Load($id);
 
@@ -274,7 +278,8 @@ if ( $request_path !~ qr{^/SelfService/} ) {
         }
     }
     if ( $request_path =~ qr{^/Admin/Users} ) {
-        if ( my $id = $m->request_args->{'id'} ) {
+        if ( $m->request_args->{'id'} && $m->request_args->{'id'} =~ /^\d+$/ ) {
+            my $id = $m->request_args->{'id'};
             my $obj = RT::User->new( $session{'CurrentUser'} );
             $obj->Load($id);
             my $tabs = PageMenu();
@@ -290,7 +295,8 @@ if ( $request_path !~ qr{^/SelfService/} ) {
     }
 
     if ( $request_path =~ qr{^/Admin/Groups} ) {
-        if ( my $id = $m->request_args->{'id'} ) {
+        if ( $m->request_args->{'id'} && $m->request_args->{'id'} =~ /^\d+$/ ) {
+            my $id = $m->request_args->{'id'};
             my $obj = RT::Group->new( $session{'CurrentUser'} );
             $obj->Load($id);
             my $tabs = PageMenu();
@@ -303,7 +309,8 @@ if ( $request_path !~ qr{^/SelfService/} ) {
     }
 
     if ( $request_path =~ qr{^/Admin/CustomFields/} ) {
-        if ( my $id = $m->request_args->{'id'} ) {
+        if ( $m->request_args->{'id'} && $m->request_args->{'id'} =~ /^\d+$/ ) {
+            my $id = $m->request_args->{'id'};
             my $obj = RT::CustomField->new( $session{'CurrentUser'} );
             $obj->Load($id);
             my $tabs = PageMenu();

-----------------------------------------------------------------------


More information about the Rt-commit mailing list