[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.9.6-355-gb48df68

? sunnavy sunnavy at bestpractical.com
Fri Dec 3 23:17:25 EST 2010


The branch, 3.9-trunk has been updated
       via  b48df68919e190d7bdb5249e458382bac4428c30 (commit)
       via  f701c40700d32c4a4ad5917899dbe0853f53ce2e (commit)
      from  e7bc4373f128dd0ed7ff2bcdf4b7b4f3b480c64d (commit)

Summary of changes:
 share/html/Admin/Elements/SelectNewGroupMembers |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit f701c40700d32c4a4ad5917899dbe0853f53ce2e
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Dec 4 11:56:13 2010 +0800

    need to explicitly set the input value as we customized select callback

diff --git a/share/html/Admin/Elements/SelectNewGroupMembers b/share/html/Admin/Elements/SelectNewGroupMembers
index 19e6a82..dee5f85 100755
--- a/share/html/Admin/Elements/SelectNewGroupMembers
+++ b/share/html/Admin/Elements/SelectNewGroupMembers
@@ -53,6 +53,7 @@
         source: "<% RT->Config->Get('WebPath')%>/Helpers/Autocomplete/Users?return=Name;privileged=1;exclude=<% $user_ids |u %>",
         // Auto-submit once a user is chosen
         select: function( event, ui ) {
+            jQuery(event.target).val(ui.item.value);
             jQuery(event.target).closest("form").submit();
         }
     });
@@ -68,6 +69,7 @@
         source: "<% RT->Config->Get('WebPath')%>/Helpers/Autocomplete/Groups?exclude=<% $group_ids |u %>",
         // Auto-submit once a user is chosen
         select: function( event, ui ) {
+            jQuery(event.target).val(ui.item.value);
             jQuery(event.target).closest("form").submit();
         }
     });

commit b48df68919e190d7bdb5249e458382bac4428c30
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Dec 4 11:57:32 2010 +0800

    clean old code: no need Groups-Name any more

diff --git a/share/html/Admin/Elements/SelectNewGroupMembers b/share/html/Admin/Elements/SelectNewGroupMembers
index dee5f85..4b4dc50 100755
--- a/share/html/Admin/Elements/SelectNewGroupMembers
+++ b/share/html/Admin/Elements/SelectNewGroupMembers
@@ -62,10 +62,9 @@
 
 % if ( $Show ne 'Users' ) {
 <label for="<% $Name %>Groups"><&|/l&>Add group</&>:</label>
-<input type="text" value="" name="<% $Name %>Groups-Name" id="<% $Name %>Groups-Name" /><br />
-<input type="hidden" value="" name="<% $Name %>Groups" id="<% $Name %>Groups" />
+<input type="text" value="" name="<% $Name %>Groups" id="<% $Name %>Groups" /><br />
 <script type="text/javascript">
-    jQuery("#<% $Name %>Groups-Name").autocomplete({
+    jQuery("#<% $Name %>Groups").autocomplete({
         source: "<% RT->Config->Get('WebPath')%>/Helpers/Autocomplete/Groups?exclude=<% $group_ids |u %>",
         // Auto-submit once a user is chosen
         select: function( event, ui ) {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list