[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.9.7-956-g9e76a3b

Thomas Sibley trs at bestpractical.com
Mon Dec 20 16:00:47 EST 2010


The branch, 3.9-trunk has been updated
       via  9e76a3be9767805dcaa72234ad48ea8798839db7 (commit)
       via  cc12809c93a08c06764d1cd988b91fdeb42f8392 (commit)
      from  760d1da77a9fd499590f0ba61d6c01c042df2733 (commit)

Summary of changes:
 share/html/Admin/Articles/Classes/GroupRights.html |    2 +-
 share/html/Admin/Articles/Classes/UserRights.html  |    4 +-
 share/html/Admin/CustomFields/GroupRights.html     |    2 +-
 share/html/Admin/CustomFields/UserRights.html      |    2 +-
 share/html/Admin/Global/GroupRights.html           |    2 +-
 share/html/Admin/Global/UserRights.html            |    2 +-
 share/html/Admin/Groups/GroupRights.html           |    2 +-
 share/html/Admin/Groups/UserRights.html            |    2 +-
 share/html/Admin/Queues/GroupRights.html           |    2 +-
 share/html/Admin/Queues/UserRights.html            |    3 +-
 share/html/NoAuth/css/base/rights-editor.css       |   27 +++++++++++++------
 11 files changed, 29 insertions(+), 21 deletions(-)

- Log -----------------------------------------------------------------
commit cc12809c93a08c06764d1cd988b91fdeb42f8392
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Dec 20 15:42:08 2010 -0500

    Update the rights editor styles for readability

diff --git a/share/html/NoAuth/css/base/rights-editor.css b/share/html/NoAuth/css/base/rights-editor.css
index 2cd954d..43f82fa 100644
--- a/share/html/NoAuth/css/base/rights-editor.css
+++ b/share/html/NoAuth/css/base/rights-editor.css
@@ -45,16 +45,12 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-/* This selector is very heavy handed, but the jQuery UI theme is tenacious */
-.rights-editor, .rights-editor * {
-    font-family: arial, helvetica, sans-serif !important;
-}
-
 /* Styles for putting jQuery UI tabs on the left */
 .rights-editor {
     border: none;
     background: transparent;
     width: 100%;
+    font-size: 110%;
 }
 
 /* Position and style the left tabs */
@@ -111,10 +107,6 @@ li.category ~ li.category {
     font-size: 80%;
 }
 
-.rights-editor ul.rights-list {
-    list-style: none;
-}
-
 .category-tabs {
     width: 100%;
     border: none;
@@ -135,6 +127,7 @@ li.category ~ li.category {
     background: white !important;
     color: #222 !important;
     border-color: #aaa !important; 
+    font-weight: bold;
 }
 
 .rights-editor .ui-state-active a,
@@ -151,6 +144,22 @@ li.category ~ li.category {
     display: none;
 }
 
+.rights-editor ul.rights-list {
+    list-style: none;
+}
+
+.rights-editor ul.rights-list li {
+    padding: 0.2em 0;
+}
+
+.rights-editor ul.rights-list li:nth-child(even) {
+    background: #f4f4f4;
+}
+
+.rights-editor ul.rights-list li label {
+    cursor: pointer;
+}
+
 .rights-editor .rightname {
     color: #888;
     font-size: 0.9em;

commit 9e76a3be9767805dcaa72234ad48ea8798839db7
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Mon Dec 20 15:51:15 2010 -0500

    Standardize on a Save Changes button in the rights editor and kill Reset

diff --git a/share/html/Admin/Articles/Classes/GroupRights.html b/share/html/Admin/Articles/Classes/GroupRights.html
index 0031bc2..96a058c 100644
--- a/share/html/Admin/Articles/Classes/GroupRights.html
+++ b/share/html/Admin/Articles/Classes/GroupRights.html
@@ -53,7 +53,7 @@
 
   <& /Admin/Elements/EditRights, Context => $ClassObj, Principals => \@principals &>
 
-<& /Elements/Submit, Caption => loc("Modify Group Rights"), Reset => 1 &>
+  <& /Elements/Submit, Label => loc('Save Changes') &>
 </form>
 <%INIT>
 
diff --git a/share/html/Admin/Articles/Classes/UserRights.html b/share/html/Admin/Articles/Classes/UserRights.html
index bd9b879..57583c6 100644
--- a/share/html/Admin/Articles/Classes/UserRights.html
+++ b/share/html/Admin/Articles/Classes/UserRights.html
@@ -51,8 +51,8 @@
 <form method="post" action="UserRights.html" name="ModifyUserRights" id="ModifyUserRights">
 <input type="hidden" name="id" value="<% $ClassObj->id %>" />
   <& /Admin/Elements/EditRights, Context => $ClassObj, Principals => \@principals &>
- 
-  <& /Elements/Submit, Label => loc('Modify User Rights'), Reset => 1 &>
+
+  <& /Elements/Submit, Label => loc('Save Changes') &> 
 <%INIT>
 my @results =  ProcessACLs(\%ARGS);
 
diff --git a/share/html/Admin/CustomFields/GroupRights.html b/share/html/Admin/CustomFields/GroupRights.html
index ee85364..9707988 100644
--- a/share/html/Admin/CustomFields/GroupRights.html
+++ b/share/html/Admin/CustomFields/GroupRights.html
@@ -53,7 +53,7 @@
     <input type="hidden" class="hidden" name="id" value="<% $CustomFieldObj->id %>" />
 
     <& /Admin/Elements/EditRights, Context => $CustomFieldObj, Principals => \@principals &>
-    <& /Elements/Submit, Caption => loc("Be sure to save your changes"), Reset => 1 &>
+    <& /Elements/Submit, Label => loc('Save Changes') &>
   </form>
 
 <%INIT>
diff --git a/share/html/Admin/CustomFields/UserRights.html b/share/html/Admin/CustomFields/UserRights.html
index 48afc73..6a72f4a 100644
--- a/share/html/Admin/CustomFields/UserRights.html
+++ b/share/html/Admin/CustomFields/UserRights.html
@@ -52,7 +52,7 @@
   <form method="post" action="UserRights.html" name="ModifyUserRights" id="ModifyUserRights">
     <input type="hidden" class="hidden" name="id" value="<% $CustomFieldObj->id %>" />
     <& /Admin/Elements/EditRights, Context => $CustomFieldObj, Principals => \@principals &>
-    <& /Elements/Submit, Caption => loc("Be sure to save your changes"), Reset => 1 &>
+    <& /Elements/Submit, Label => loc('Save Changes') &>
   </form>
 <%INIT>
 # Update the acls.
diff --git a/share/html/Admin/Global/GroupRights.html b/share/html/Admin/Global/GroupRights.html
index fb8bd1b..b526ca7 100755
--- a/share/html/Admin/Global/GroupRights.html
+++ b/share/html/Admin/Global/GroupRights.html
@@ -51,7 +51,7 @@
 
 <form method="post" action="GroupRights.html" id="ModifyGroupRights" name="ModifyGroupRights">
   <& /Admin/Elements/EditRights, Context => $RT::System, Principals => \@principals &>
-  <& /Elements/Submit, Label => loc('Modify Group Rights'), Reset => 1 &>
+  <& /Elements/Submit, Label => loc('Save Changes') &>
 </form>
   
 <%INIT>
diff --git a/share/html/Admin/Global/UserRights.html b/share/html/Admin/Global/UserRights.html
index 85410ba..f3505fb 100755
--- a/share/html/Admin/Global/UserRights.html
+++ b/share/html/Admin/Global/UserRights.html
@@ -51,7 +51,7 @@
 
 <form method="post" action="UserRights.html" name="ModifyUserRights" id="ModifyUserRights">
   <& /Admin/Elements/EditRights, Context => $RT::System, Principals => \@principals &>
-  <& /Elements/Submit, Label => loc('Modify User Rights'), Reset => 1 &>
+  <& /Elements/Submit, Label => loc('Save Changes') &>
 </form>
 <%INIT>
 my @results = ProcessACLs(\%ARGS);
diff --git a/share/html/Admin/Groups/GroupRights.html b/share/html/Admin/Groups/GroupRights.html
index 8e99ec8..ca1cff7 100755
--- a/share/html/Admin/Groups/GroupRights.html
+++ b/share/html/Admin/Groups/GroupRights.html
@@ -52,7 +52,7 @@
   <form method="post" action="GroupRights.html" id="ModifyGroupRights" name="ModifyGroupRights">
     <input type="hidden" class="hidden" name="id" value="<% $GroupObj->id %>" />
     <& /Admin/Elements/EditRights, Context => $GroupObj, Principals => \@principals &>
-    <& /Elements/Submit, Label => loc('Modify Group Rights'), Reset => 1 &>
+    <& /Elements/Submit, Label => loc('Save Changes') &>
   </form>
 <%INIT>
 # Update the acls.
diff --git a/share/html/Admin/Groups/UserRights.html b/share/html/Admin/Groups/UserRights.html
index c547b32..ece5ea8 100755
--- a/share/html/Admin/Groups/UserRights.html
+++ b/share/html/Admin/Groups/UserRights.html
@@ -52,7 +52,7 @@
   <form method="post" action="UserRights.html" name="ModifyUserRights" id="ModifyUserRights">
     <input type="hidden" class="hidden" name="id" value="<% $GroupObj->id %>" />
     <& /Admin/Elements/EditRights, Context => $GroupObj, Principals => \@principals &>
-    <& /Elements/Submit, Label => loc('Modify User Rights'), Reset => 1 &>
+    <& /Elements/Submit, Label => loc('Save Changes') &>
   </form>
 
 <%INIT>
diff --git a/share/html/Admin/Queues/GroupRights.html b/share/html/Admin/Queues/GroupRights.html
index d19584b..1e85d7d 100755
--- a/share/html/Admin/Queues/GroupRights.html
+++ b/share/html/Admin/Queues/GroupRights.html
@@ -56,7 +56,7 @@
 
   <& /Admin/Elements/EditRights, Context => $QueueObj, Principals => \@principals &>
 
-  <& /Elements/Submit, Label => loc('Modify Group Rights'), Reset => 1 &>
+  <& /Elements/Submit, Label => loc('Save Changes') &>
 </form>
 
 <%INIT>
diff --git a/share/html/Admin/Queues/UserRights.html b/share/html/Admin/Queues/UserRights.html
index 8f8f8ae..4681911 100755
--- a/share/html/Admin/Queues/UserRights.html
+++ b/share/html/Admin/Queues/UserRights.html
@@ -57,8 +57,7 @@
 
   <& /Admin/Elements/EditRights, Context => $QueueObj, Principals => \@principals &>
  
-  <& /Elements/Submit, Label => loc('Modify User Rights'), Reset => 1 &>
-
+  <& /Elements/Submit, Label => loc('Save Changes') &>
 </form>
 
 <%INIT>

-----------------------------------------------------------------------


More information about the Rt-commit mailing list