[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.9.7-985-g350ca50

Jesse Vincent jesse at bestpractical.com
Tue Dec 21 15:50:55 EST 2010


The branch, 3.9-trunk has been updated
       via  350ca500b3a1e0ddf1f757117022db15a2af7bea (commit)
       via  433008bbd992f4dd8f60d1f1724b4da2475d875f (commit)
       via  fc3879855bdeb2e7191f5e935dc62eb0493ef660 (commit)
       via  cb7798845c736618d7a1b1c8c5d8672a49e21692 (commit)
      from  5fe3f6f8cff781ee4d7ded6c05e69a31311f0458 (commit)

Summary of changes:
 share/html/Articles/Article/PreCreate.html |    2 +-
 share/html/Elements/EditCustomFieldSelect  |    2 +-
 share/html/Elements/Tabs                   |   13 ++++++-------
 share/html/Search/Chart.html               |    4 ++--
 4 files changed, 10 insertions(+), 11 deletions(-)

- Log -----------------------------------------------------------------
commit cb7798845c736618d7a1b1c8c5d8672a49e21692
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Tue Dec 21 15:48:42 2010 -0500

    Switch from ~english to boring error message

diff --git a/share/html/Articles/Article/PreCreate.html b/share/html/Articles/Article/PreCreate.html
index 5e375bc..6c3c033 100644
--- a/share/html/Articles/Article/PreCreate.html
+++ b/share/html/Articles/Article/PreCreate.html
@@ -57,5 +57,5 @@
 % }
 </ul>
 % unless ( $have_classes ) {
-<span><&|/l&>No classes you have access to...</&></span>
+<span><&|/l&>Permission Denied</&></span>
 % }

commit fc3879855bdeb2e7191f5e935dc62eb0493ef660
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Tue Dec 21 15:49:25 2010 -0500

    specify a default value to fix an explosion in bulk update with bad old
    data

diff --git a/share/html/Elements/EditCustomFieldSelect b/share/html/Elements/EditCustomFieldSelect
index 9473d75..a1658f2 100644
--- a/share/html/Elements/EditCustomFieldSelect
+++ b/share/html/Elements/EditCustomFieldSelect
@@ -149,7 +149,7 @@ $Multiple => 0
 $Rows => undef
 $HideCategory => 0
 $RenderType => undef
-$MaxValues
+$MaxValues => 1
 </%ARGS>
 
 <%METHOD options>

commit 433008bbd992f4dd8f60d1f1724b4da2475d875f
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Tue Dec 21 15:50:23 2010 -0500

    Move "Chart" out of the "More" menu and change "More" to "Feeds"

diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
index 2dcad5e..e4b06d4 100755
--- a/share/html/Elements/Tabs
+++ b/share/html/Elements/Tabs
@@ -598,22 +598,21 @@ my $build_admin_menu = sub {
         } else {
             $current_search_menu = PageMenu();
         }
-        if ($has_query) {
-            $current_search_menu->child( results => title => loc('Show Results') => path => "/Search/Results.html$args" );
-
-        }
 
         $current_search_menu->child( edit_search => title => loc('Edit Search') =>
                                      path => "/Search/Build.html" . ( ($has_query) ? $args : '' ) );
         $current_search_menu->child( loc('Advanced') => path => "/Search/Edit.html$args" );
+        if ($has_query) {
+            $current_search_menu->child( results => title => loc('Show Results') => path => "/Search/Results.html$args" );
+        }
 
         if ( $has_query ) {
             $current_search_menu->child( bulk => title => loc('Bulk Update') => path => "/Search/Bulk.html$args" );
+            $current_search_menu->child( chart => title => loc('Chart'),
+                                         path => "/Search/Chart.html$args" );
 
-            my $more = $current_search_menu->child( more => title => loc('More...') );
+            my $more = $current_search_menu->child( more => title => loc('Feeds...') );
             
-            $more->child( chart => title => loc('Graph'),
-                                         path => "/Search/Chart.html$args" );
             $more->child(
                                    spreadsheet => title => loc('Spreadsheet'),
                                    path => "/Search/Results.tsv$args" );

commit 350ca500b3a1e0ddf1f757117022db15a2af7bea
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Tue Dec 21 15:50:43 2010 -0500

    Graph -> Chart to be a bit more consistent

diff --git a/share/html/Search/Chart.html b/share/html/Search/Chart.html
index 478bef7..55dab94 100644
--- a/share/html/Search/Chart.html
+++ b/share/html/Search/Chart.html
@@ -86,13 +86,13 @@ my @actions = $m->comp( '/Widgets/SavedSearch:process', args => \%ARGS, self =>
 
 <div class="chart-meta">
 <div class="chart-type">
-<&| /Widgets/TitleBox, title => loc('Graph Properties')&>
+<&| /Widgets/TitleBox, title => loc('Chart Properties')&>
 <form method="get" action="<%RT->Config->Get('WebPath')%>/Search/Chart.html">
 <input type="hidden" class="hidden" name="Query" value="<% $ARGS{Query} %>" />
 <input type="hidden" class="hidden" name="SavedChartSearchId" value="<% $saved_search->{SearchId} || 'new' %>" />
 
 <&|/l, $m->scomp('Elements/SelectChartType', Name => 'ChartStyle', Default => $ChartStyle), $m->scomp('Elements/SelectGroupBy', Name => 'PrimaryGroupBy', Query => $ARGS{Query}, Default => $PrimaryGroupBy) 
-&>[_1] chart by [_2]</&><input type="submit" class="button" value="<%loc('Update Graph')%>" />
+&>[_1] chart by [_2]</&><input type="submit" class="button" value="<%loc('Update Chart')%>" />
 </form>
 </&>
 </div>

-----------------------------------------------------------------------


More information about the Rt-commit mailing list