[Rt-commit] rt branch, custom_fields_application, created. rt-3.8.7-162-g15ec7b4

Ruslan Zakirov ruz at bestpractical.com
Wed Feb 17 21:35:41 EST 2010


The branch, custom_fields_application has been created
        at  15ec7b4d900ecfe235f4a67e352fc5914715dabc (commit)

- Log -----------------------------------------------------------------
commit d8ca52cc5cf11a1b4ceda3f05c0ca6f258ded27f
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Wed Feb 17 20:06:27 2010 -0500

    Add callback for adding links for attachment downloads

diff --git a/share/html/Ticket/Elements/ShowTransactionAttachments b/share/html/Ticket/Elements/ShowTransactionAttachments
index 242725a..a8cdfc1 100644
--- a/share/html/Ticket/Elements/ShowTransactionAttachments
+++ b/share/html/Ticket/Elements/ShowTransactionAttachments
@@ -67,7 +67,10 @@ foreach my $message ( grep $_->__Value('Parent') == $Parent, @$Attachments ) {
 % if ( $DownloadableHeaders && !$message->Filename && $message->ContentType =~ /text/  ) {
  / <a href="<% $AttachPath %>/WithHeaders/<% $message->Id %>"><% loc('with headers') %></a>
 % }
-<br /> 
+
+% $m->callback(CallbackName => 'AfterDownloadLinks', ARGSRef => \%ARGS, Ticket => $Ticket, Transaction => $Transaction, Attachment => $message);
+
+<br />
 <span class="downloadcontenttype"><% $message->ContentType %> <% $size_to_str->( $size ) %></span>
 </div>
 %   }

commit 15ec7b4d900ecfe235f4a67e352fc5914715dabc
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Thu Feb 18 05:09:50 2010 +0300

    DefaultMailPrecedence config option worked incorrectly
    
    "if !x || !y" when it should be "if !x && y"

diff --git a/lib/RT/Action/SendEmail.pm b/lib/RT/Action/SendEmail.pm
index 56d00b4..850abb3 100755
--- a/lib/RT/Action/SendEmail.pm
+++ b/lib/RT/Action/SendEmail.pm
@@ -607,9 +607,11 @@ sub SetRTSpecialHeaders {
         }
     }
 
-    $self->SetHeader( 'Precedence', RT->Config->Get('DefaultMailPrecedence') )
-        unless $self->TemplateObj->MIMEObj->head->get("Precedence")
-            && defined(RT->Config->Get('DefaultMailPrecedence'));
+    if (my $precedence = RT->Config->Get('DefaultMailPrecedence')
+        and !$self->TemplateObj->MIMEObj->head->get("Precedence")
+    ) {
+        $self->SetHeader( 'Precedence', $precedence );
+    }
 
     $self->SetHeader( 'X-RT-Loop-Prevention', RT->Config->Get('rtname') );
     $self->SetHeader( 'RT-Ticket',

-----------------------------------------------------------------------


More information about the Rt-commit mailing list