[Rt-commit] rt branch, admin_ui, updated. 3a00d78b337d7c80ec92703390991b28fd2b7fb7

[sunnavy at bestpractical.com]

The branch, admin_ui has been updated
       via  3a00d78b337d7c80ec92703390991b28fd2b7fb7 (commit)
      from  799eb8e818d9c8aba8ffce3651d9510a3f1de656 (commit)

Summary of changes:
 lib/RT/Action/UpdateCustomField.pm |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

- Log -----------------------------------------------------------------
commit 3a00d78b337d7c80ec92703390991b28fd2b7fb7
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Jan 4 16:24:44 2010 +0800

    add fake values_class for non select cfs so Jifty won't warn

diff --git a/lib/RT/Action/UpdateCustomField.pm b/lib/RT/Action/UpdateCustomField.pm
index fa03ca3..429240a 100644
--- a/lib/RT/Action/UpdateCustomField.pm
+++ b/lib/RT/Action/UpdateCustomField.pm
@@ -63,6 +63,11 @@ sub arguments {
             },
         };
     }
+    else {
+        $args->{values_class} = {
+            render => 'hidden',
+        };
+    }
     return $args;
 }
 
@@ -76,6 +81,10 @@ sub take_action {
     for my $attr (@attrs) {
         if ( $self->has_argument($attr) ) {
             my $method = "set_$attr";
+            # for non select cfs, we supply an empty and hidden input
+            # and we don't want to set_... for that.
+            next if $attr eq 'values_class' && !$self->argument_value($attr);
+
             my ( $status, $msg ) =
               $self->record->$method( $self->argument_value($attr) );
             Jifty->log->error($msg) unless $status;

-----------------------------------------------------------------------