[Rt-commit] rt branch, 3.8-trunk, updated. rt-3.8.7-89-gcf29b12

sartak at bestpractical.com sartak at bestpractical.com
Wed Jan 6 14:34:24 EST 2010


The branch, 3.8-trunk has been updated
       via  cf29b12bd36f8663a8ea6314ed0ac8a0e4e87ede (commit)
      from  dee11f2956b662c39770f6ab59b3bba44e1ba777 (commit)

Summary of changes:
 share/html/Ticket/Elements/UpdateCc |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit cf29b12bd36f8663a8ea6314ed0ac8a0e4e87ede
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Wed Jan 6 14:32:19 2010 -0500

    Patch from Bálint Bekény to fix a JS escaping issue

diff --git a/share/html/Ticket/Elements/UpdateCc b/share/html/Ticket/Elements/UpdateCc
index 2538c82..f7880ee 100644
--- a/share/html/Ticket/Elements/UpdateCc
+++ b/share/html/Ticket/Elements/UpdateCc
@@ -55,7 +55,9 @@
 id="UpdateCc-<%$addr%>" 
 name="UpdateCc-<%$addr%>" 
     type="checkbox" 
-    onClick="checkboxToInput('UpdateCc', 'UpdateCc-<%$addr%>','<%$txn_addresses{$addr}->format%>' ); $(UpdateIgnoreAddressCheckboxes).value=1"  
+% my $clean_addr = $txn_addresses{$addr}->format;
+% $clean_addr =~ s/'/\\'/g;
+    onClick="checkboxToInput('UpdateCc', 'UpdateCc-<%$addr%>','<%$clean_addr%>' ); $(UpdateIgnoreAddressCheckboxes).value=1"
     <% $ARGS{'UpdateCc-'.$addr} ? 'checked="checked"' : ''%> > <& /Elements/ShowUser, Address => $txn_addresses{$addr}&>
 %}
 </td></tr>
@@ -66,7 +68,9 @@ name="UpdateCc-<%$addr%>"
     id="UpdateBcc-<%$addr%>"
     name="UpdateBcc-<%$addr%>"
     type="checkbox" 
-    onClick="checkboxToInput('UpdateBcc', 'UpdateBcc-<%$addr%>','<%$txn_addresses{$addr}->format%>' ); $(UpdateIgnoreAddressCheckboxes).value=1" 
+% my $clean_addr = $txn_addresses{$addr}->format;
+% $clean_addr =~ s/'/\\'/g;
+    onClick="checkboxToInput('UpdateBcc', 'UpdateBcc-<%$addr%>','<%$clean_addr%>' ); $(UpdateIgnoreAddressCheckboxes).value=1"
         <% $ARGS{'UpdateBcc-'.$addr} ? 'checked="checked"' : ''%>> 
 <& /Elements/ShowUser, Address => $txn_addresses{$addr}&>
 %}

-----------------------------------------------------------------------


More information about the Rt-commit mailing list