[Rt-commit] rt branch, 3.999-trunk, updated. 8b69e3b582a7a2511dd3c90168481d299fc2d8c6

[sartak at bestpractical.com]

The branch, 3.999-trunk has been updated
       via  8b69e3b582a7a2511dd3c90168481d299fc2d8c6 (commit)
      from  089d41b7577f39576f0edc25f5b32ff0fb92a758 (commit)

Summary of changes:
 Makefile.PL                |    2 +-
 t/ticket/requestor-order.t |   16 +++-------------
 2 files changed, 4 insertions(+), 14 deletions(-)

- Log -----------------------------------------------------------------
commit 8b69e3b582a7a2511dd3c90168481d299fc2d8c6
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Mon Jan 11 17:25:04 2010 -0500

    Latest JDBI seems to fix this issue

diff --git a/Makefile.PL b/Makefile.PL
index 08fa2b1..01f398f 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -10,7 +10,7 @@ requires(
     'Digest::MD5'                => '2.27',
     'DBI'                        => '1.37',
     'Class::ReturnValue'         => '0.40',
-    'Jifty::DBI'                 => '0.59',
+    'Jifty::DBI'                 => '0.61',
     'Jifty::Plugin::Wikitext'    => '0.01',
     'Jifty::Plugin::WyzzEditor'  => '0.01',
     'Text::Template'             => 0,
diff --git a/t/ticket/requestor-order.t b/t/ticket/requestor-order.t
index ee01ff0..7594651 100644
--- a/t/ticket/requestor-order.t
+++ b/t/ticket/requestor-order.t
@@ -59,11 +59,7 @@ sub check_emails_order
         if( $_ ) { unshift @mails, $_ }
         else { push @mails, $_ }
     }
-    TODO: {
-        local $TODO = "requires Jifty::DBI improvements supposedly :)"
-            if $todo;
-        is_deeply( \@mails, \@required_order, "Addresses are sorted");
-    }
+    is_deeply( \@mails, \@required_order, "Addresses are sorted");
 }
 
 {
@@ -131,10 +127,7 @@ sub check_emails_order
     my @mails;
     while (my $t = $tix->next) { push @mails, $t->role_group("requestor")->member_emails_as_string; }
     is(@mails, 30, "found thirty tickets");
-    TODO: {
-        local $TODO = "requires Jifty::DBI improvements supposedly :)";
-        is_deeply( [grep {$_} @mails], [ sort grep {$_} @mails ], "Paging works (exclude nulls, which are db-dependant)");
-    }
+    is_deeply( [grep {$_} @mails], [ sort grep {$_} @mails ], "Paging works (exclude nulls, which are db-dependant)");
 }
 
 {
@@ -145,10 +138,7 @@ sub check_emails_order
     my @mails;
     while (my $t = $tix->next) { push @mails, $t->role_group("requestor")->member_emails_as_string; }
     is(@mails, 30, "found thirty tickets");
-    TODO: {
-        local $TODO = "requires Jifty::DBI improvements supposedly :)";
-        is_deeply( [grep {$_} @mails], [ sort grep {$_} @mails ], "Paging works (exclude nulls, which are db-dependant)");
-    };
+    is_deeply( [grep {$_} @mails], [ sort grep {$_} @mails ], "Paging works (exclude nulls, which are db-dependant)");
 }
 RT::Test->mailsent_ok(25);
 

-----------------------------------------------------------------------