[Rt-commit] rt branch, admin_ui, updated. 975a6dc994487284e0c549a725c2f1494148c752

sunnavy at bestpractical.com sunnavy at bestpractical.com
Wed Jan 13 01:20:20 EST 2010


The branch, admin_ui has been updated
       via  975a6dc994487284e0c549a725c2f1494148c752 (commit)
       via  a609b69b6f1ba4a29cc7bf17097b8a45cc46a3bf (commit)
      from  d8e3defe50ebbf7d01d3e91027cc38bf060e3419 (commit)

Summary of changes:
 lib/RT/Action/ConfigMyRT.pm               |    2 +-
 lib/RT/Action/ConfigSystem.pm             |    2 +-
 lib/RT/Action/CreateWorkflow.pm           |    2 +-
 lib/RT/Action/EditGroupMembers.pm         |    2 +-
 lib/RT/Action/EditRights.pm               |    2 +-
 lib/RT/Action/EditUserMemberships.pm      |    2 +-
 lib/RT/Action/EditWatchers.pm             |    2 +-
 lib/RT/Action/EditWorkflowInterface.pm    |    2 +-
 lib/RT/Action/EditWorkflowMappings.pm     |    2 +-
 lib/RT/Action/EditWorkflowStatuses.pm     |    2 +-
 lib/RT/Action/EditWorkflowTransitions.pm  |    2 +-
 lib/RT/Action/SelectCustomFields.pm       |    2 +-
 lib/RT/Action/SelectObjectCustomFields.pm |    2 +-
 lib/RT/Action/SelectPrivateKey.pm         |    2 +-
 lib/RT/Action/UserSettings.pm             |    2 +-
 t/web/admin/queues.t                      |   52 +++++++++++++++++++++++++++++
 16 files changed, 67 insertions(+), 15 deletions(-)
 create mode 100644 t/web/admin/queues.t

- Log -----------------------------------------------------------------
commit a609b69b6f1ba4a29cc7bf17097b8a45cc46a3bf
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Jan 12 18:53:51 2010 +0800

    admin queues test

diff --git a/t/web/admin/queues.t b/t/web/admin/queues.t
new file mode 100644
index 0000000..7414b08
--- /dev/null
+++ b/t/web/admin/queues.t
@@ -0,0 +1,52 @@
+#!/usr/bin/env perl
+
+use strict;
+use RT::Test strict => 0, tests => 13, l10n => 1;
+
+my ( $baseurl, $agent ) = RT::Test->started_ok;
+ok( $agent->login, 'logged in' );
+
+$agent->get_ok('/admin/queues/');
+
+ok( $agent->find_link( text => 'General', url_regex => qr{\?id=1}, ),
+    "General link" );
+
+ok( !$agent->find_link( text => '___Approvals', ), "no Approvals link" );
+
+ok(
+    $agent->find_link( text => 'Include disabled ones in listing', ),
+    'include disabled link',
+);
+
+$agent->follow_link_ok( { text => 'Include disabled ones in listing' } );
+ok( $agent->find_link( text => '___Approvals', ), "Approvals link" );
+
+ok(
+    $agent->find_link( text => 'Exclude disabled ones in listing', ),
+    'exclude disabled link',
+);
+
+
+$agent->follow_link_ok( { text => 'General', url_regex => qr{\?id=1} },
+    'click General' );
+
+# Basics 
+$agent->follow_link_ok( { text => 'Basics' } );
+my $update_moniker = 'update_queue';
+$agent->fill_in_action_ok( $update_moniker, initial_priority => 30 );
+$agent->submit;
+$agent->content_contains( 'Updated', 'queue is updated' )
+
+# Watchers
+
+# Templates
+
+# Ticket Custom Fields
+
+# Transaction Custom Fields
+
+# Group Rights
+
+# User Rights
+
+# GnuPG

commit 975a6dc994487284e0c549a725c2f1494148c752
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Jan 13 14:20:08 2010 +0800

    tweak success messages

diff --git a/lib/RT/Action/ConfigMyRT.pm b/lib/RT/Action/ConfigMyRT.pm
index f0446b6..a4cb490 100644
--- a/lib/RT/Action/ConfigMyRT.pm
+++ b/lib/RT/Action/ConfigMyRT.pm
@@ -172,7 +172,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated myrt'));
 }
 
 
diff --git a/lib/RT/Action/ConfigSystem.pm b/lib/RT/Action/ConfigSystem.pm
index f5dbce7..ce0a76c 100644
--- a/lib/RT/Action/ConfigSystem.pm
+++ b/lib/RT/Action/ConfigSystem.pm
@@ -184,7 +184,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated system'));
 }
 
 1;
diff --git a/lib/RT/Action/CreateWorkflow.pm b/lib/RT/Action/CreateWorkflow.pm
index eeaa1c2..a4a5d3b 100644
--- a/lib/RT/Action/CreateWorkflow.pm
+++ b/lib/RT/Action/CreateWorkflow.pm
@@ -41,7 +41,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Created workflow %1', $self->record->name));
 }
 
 1;
diff --git a/lib/RT/Action/EditGroupMembers.pm b/lib/RT/Action/EditGroupMembers.pm
index 346f6ca..3fd22ac 100644
--- a/lib/RT/Action/EditGroupMembers.pm
+++ b/lib/RT/Action/EditGroupMembers.pm
@@ -103,7 +103,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated group members'));
 }
 
 sub available_values {
diff --git a/lib/RT/Action/EditRights.pm b/lib/RT/Action/EditRights.pm
index 29f066d..a2f1c93 100644
--- a/lib/RT/Action/EditRights.pm
+++ b/lib/RT/Action/EditRights.pm
@@ -104,7 +104,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated rights'));
 }
 
 sub available_values {
diff --git a/lib/RT/Action/EditUserMemberships.pm b/lib/RT/Action/EditUserMemberships.pm
index 024c68d..4d1764d 100644
--- a/lib/RT/Action/EditUserMemberships.pm
+++ b/lib/RT/Action/EditUserMemberships.pm
@@ -104,7 +104,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated user memberships'));
 }
 
 sub available_values {
diff --git a/lib/RT/Action/EditWatchers.pm b/lib/RT/Action/EditWatchers.pm
index a65355d..1317582 100644
--- a/lib/RT/Action/EditWatchers.pm
+++ b/lib/RT/Action/EditWatchers.pm
@@ -121,7 +121,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated watchers'));
 }
 
 sub available_values {
diff --git a/lib/RT/Action/EditWorkflowInterface.pm b/lib/RT/Action/EditWorkflowInterface.pm
index e9436e5..8635838 100644
--- a/lib/RT/Action/EditWorkflowInterface.pm
+++ b/lib/RT/Action/EditWorkflowInterface.pm
@@ -99,7 +99,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated workflow interface'));
 }
 
 1;
diff --git a/lib/RT/Action/EditWorkflowMappings.pm b/lib/RT/Action/EditWorkflowMappings.pm
index 2c86e31..3a15e26 100644
--- a/lib/RT/Action/EditWorkflowMappings.pm
+++ b/lib/RT/Action/EditWorkflowMappings.pm
@@ -123,7 +123,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated workflow mappings'));
 }
 
 1;
diff --git a/lib/RT/Action/EditWorkflowStatuses.pm b/lib/RT/Action/EditWorkflowStatuses.pm
index 33a3d48..084383a 100644
--- a/lib/RT/Action/EditWorkflowStatuses.pm
+++ b/lib/RT/Action/EditWorkflowStatuses.pm
@@ -67,7 +67,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated workflow statuses'));
 }
 
 1;
diff --git a/lib/RT/Action/EditWorkflowTransitions.pm b/lib/RT/Action/EditWorkflowTransitions.pm
index 223cd89..3c50783 100644
--- a/lib/RT/Action/EditWorkflowTransitions.pm
+++ b/lib/RT/Action/EditWorkflowTransitions.pm
@@ -75,7 +75,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated workflow transactions'));
 }
 
 1;
diff --git a/lib/RT/Action/SelectCustomFields.pm b/lib/RT/Action/SelectCustomFields.pm
index dee3525..e217ca6 100644
--- a/lib/RT/Action/SelectCustomFields.pm
+++ b/lib/RT/Action/SelectCustomFields.pm
@@ -188,7 +188,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated custom fields selection'));
 }
 
 1;
diff --git a/lib/RT/Action/SelectObjectCustomFields.pm b/lib/RT/Action/SelectObjectCustomFields.pm
index f5391cb..57267ea 100644
--- a/lib/RT/Action/SelectObjectCustomFields.pm
+++ b/lib/RT/Action/SelectObjectCustomFields.pm
@@ -147,7 +147,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated object custom fields selection'));
 }
 
 1;
diff --git a/lib/RT/Action/SelectPrivateKey.pm b/lib/RT/Action/SelectPrivateKey.pm
index 40dc6d8..de3e994 100644
--- a/lib/RT/Action/SelectPrivateKey.pm
+++ b/lib/RT/Action/SelectPrivateKey.pm
@@ -77,7 +77,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated private key selection'));
 }
 
 sub available_values {
diff --git a/lib/RT/Action/UserSettings.pm b/lib/RT/Action/UserSettings.pm
index 286be22..23cc233 100644
--- a/lib/RT/Action/UserSettings.pm
+++ b/lib/RT/Action/UserSettings.pm
@@ -213,7 +213,7 @@ sub report_success {
     my $self = shift;
 
     # Your success message here
-    $self->result->message('Success');
+    $self->result->message(_('Updated user settings'));
 }
 
 sub default_value {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list