[Rt-commit] rt branch, expand-history, created. rt-3.8.8-103-g1386408

[Shawn Moore]

The branch, expand-history has been created
        at  138640897857177bd38cb75c5a9cb83d3f12158f (commit)

- Log -----------------------------------------------------------------
commit fde9e681c3fab37c9482c7a39d42f446b35156e4
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Tue Jun 29 13:37:54 2010 -0400

    Clean up warnings by switching back to QueryString

diff --git a/share/html/Elements/RT__SavedSearch/ColumnMap b/share/html/Elements/RT__SavedSearch/ColumnMap
index 795b5a2..95f9db5 100644
--- a/share/html/Elements/RT__SavedSearch/ColumnMap
+++ b/share/html/Elements/RT__SavedSearch/ColumnMap
@@ -71,11 +71,10 @@ my $COLUMN_MAP = {
         title     => '',
         attribute => 'ResultsURL',
         value     => sub { my $search = shift;
-                           return join('&', sort
-                            map { $m->interp->apply_escapes($_,'u') .
-                                  '=' .
-                                  $m->interp->apply_escapes($search->GetParameter($_),'u') }
-                            qw(Query Format Rows Order OrderBy)) },
+                            return $m->comp('/Elements/QueryString',
+                                            map { $_ => $search->GetParameter($_) }
+                                            qw(Query Format Rows Order OrderBy));
+                        },
     }
 };
 

commit 0d04a0ebf31f6c8dde9831518ed50068470dd6cc
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Wed Jun 30 17:48:53 2010 -0400

    Revert "New config $HideCustomFieldValidator"
    
    This reverts commit 83ace0a90979429c8784623f0dde1d4d638c362e.
    
    Too specific (and kinda useless) for core, this is shipping out to an
    extension

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index 0142e71..c148c25 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -1539,17 +1539,6 @@ Use this to set the default units for time entry to hours instead of minutes.
 
 Set($DefaultTimeUnitsToHours, 0);
 
-=item C<$HideCustomFieldValidator>
-
-Use this to hide the regular expression used to validate custom field values.
-This applies only to the custom field admin interface. The regular expression's
-first comment will be used as the label for that validator. For example, the
-validator C<(?#Digits)^[\d.]+$> will display as just C<Digits>.
-
-=cut
-
-Set($HideCustomFieldValidator, 0);
-
 =back
 
 =head1 L<Net::Server> (rt-server) Configuration
diff --git a/share/html/Admin/CustomFields/Modify.html b/share/html/Admin/CustomFields/Modify.html
index 14eceb3..f75607a 100644
--- a/share/html/Admin/CustomFields/Modify.html
+++ b/share/html/Admin/CustomFields/Modify.html
@@ -230,15 +230,6 @@ my @CFvalidations = (
 
 $m->callback(CallbackName => 'ValidationPatterns', Values => \@CFvalidations);
 
-if (RT->Config->Get('HideCustomFieldValidator')) {
-    for my $pattern (@CFvalidations) {
-        next if ref($pattern);
-        if (my ($name) = $pattern =~ /\(\?\#(\w+)\)/) {
-            $pattern = { name => $pattern, label => $name };
-        }
-    }
-}
-
 </%INIT>
 <%ARGS>
 $id => undef

commit 41d51f1c9edaa671fa08dd6e4eeebb213a781750
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Thu Jul 1 23:46:33 2010 +0400

    Starts and Started were missing from the .tsv view, shuffle order as well

diff --git a/share/html/Search/Results.tsv b/share/html/Search/Results.tsv
index 946a35d..ded44eb 100644
--- a/share/html/Search/Results.tsv
+++ b/share/html/Search/Results.tsv
@@ -91,8 +91,9 @@ my @attrs = qw(
     Requestors->MemberEmailAddressesAsString
     Cc->MemberEmailAddressesAsString
     AdminCc->MemberEmailAddressesAsString
-    DueObj->ISO ToldObj->ISO CreatedObj->ISO
-    ResolvedObj->ISO LastUpdatedObj->ISO
+    CreatedObj->ISO
+    StartsObj->ISO StartedObj->ISO ResolvedObj->ISO DueObj->ISO 
+    ToldObj->ISO LastUpdatedObj->ISO
 );
 
 $r->content_type('application/vnd.ms-excel');

commit 31f4e2394efee01fb6292d806a35b35706f5f3fc
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Fri Jul 2 18:48:02 2010 -0400

    Add a callback for before One-time Cc

diff --git a/share/html/Ticket/Elements/UpdateCc b/share/html/Ticket/Elements/UpdateCc
index 2559e56..9ffabcb 100644
--- a/share/html/Ticket/Elements/UpdateCc
+++ b/share/html/Ticket/Elements/UpdateCc
@@ -45,6 +45,8 @@
 %# those contributions and any derivatives thereof.
 %# 
 %# END BPS TAGGED BLOCK }}}
+% $m->callback(CallbackName => 'BeforeCc', ARGSRef => \%ARGS, Ticket => $TicketObj, one_time_Ccs => \@one_time_Ccs, txn_addresses => \%txn_addresses);
+
 <tr><td class="label"><&|/l&>One-time Cc</&>:</td><td><& /Elements/EmailInput, Name => 'UpdateCc', Size => '60', Default => $ARGS{UpdateCc} &>
 <input type="hidden" id="UpdateIgnoreAddressCheckboxes" name="UpdateIgnoreAddressCheckboxes" value="0">
         <br />

commit 138640897857177bd38cb75c5a9cb83d3f12158f
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Fri Jul 2 20:12:10 2010 -0400

    Callback for massaging @DisplayHeaders

diff --git a/share/html/Ticket/Elements/ShowTransactionAttachments b/share/html/Ticket/Elements/ShowTransactionAttachments
index a8cdfc1..32a6a91 100644
--- a/share/html/Ticket/Elements/ShowTransactionAttachments
+++ b/share/html/Ticket/Elements/ShowTransactionAttachments
@@ -125,6 +125,8 @@ elsif (!$ShowHeaders)  {
     push @DisplayHeaders, 'RT-Send-Bcc' if RT->Config->Get('ShowBccHeader');
 }
 
+$m->callback(CallbackName => 'MassageDisplayHeaders', DisplayHeaders => \@DisplayHeaders, Transaction => $Transaction);
+
 my $size_to_str = sub {
     my $size = shift;
     # show a download link

-----------------------------------------------------------------------