[Rt-commit] rt branch, history-filter, updated. rt-3.8.8-91-g28c7bab

[Shawn Moore]

The branch, history-filter has been updated
       via  28c7babe0e5c1bd07757281fa26f07fe6e3355c1 (commit)
       via  07adcb8e13324b69b56a516338b21703f003347b (commit)
      from  28eed9213ac73e59e7a0e36d0d2841c35abd5659 (commit)

Summary of changes:
 lib/RT/Transaction_Overlay.pm |   43 +++++++++++++++++++++++++++-------------
 1 files changed, 29 insertions(+), 14 deletions(-)

- Log -----------------------------------------------------------------
commit 07adcb8e13324b69b56a516338b21703f003347b
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Tue Jun 15 15:36:25 2010 -0400

    Move SystemError into %TypeMetadata

diff --git a/lib/RT/Transaction_Overlay.pm b/lib/RT/Transaction_Overlay.pm
index ee36ccc..15e42c3 100755
--- a/lib/RT/Transaction_Overlay.pm
+++ b/lib/RT/Transaction_Overlay.pm
@@ -350,6 +350,12 @@ use HTML::TreeBuilder;
             return $self->loc("Reminder '[_1]' completed", $ticket->Subject);
         },
     },
+    SystemError => {
+        BriefDescription => sub {
+            my $self = shift;
+            return $self->loc("System error");
+        },
+    },
 );
 # }}}
 
@@ -928,9 +934,6 @@ sub BriefDescription {
             )
         );
     }
-    elsif ( $type =~ /SystemError/ ) {
-        return $self->loc("System error");
-    }
 
     if ( my $code = $self->TypeMetadata(Type => $type, Field => 'BriefDescription') ) {
         return $code->($self);

commit 28c7babe0e5c1bd07757281fa26f07fe6e3355c1
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Tue Jun 15 15:48:20 2010 -0400

    Refactor Create, Enabled, Disabled to be in %TypeMetadata

diff --git a/lib/RT/Transaction_Overlay.pm b/lib/RT/Transaction_Overlay.pm
index 15e42c3..7462ee7 100755
--- a/lib/RT/Transaction_Overlay.pm
+++ b/lib/RT/Transaction_Overlay.pm
@@ -356,6 +356,27 @@ use HTML::TreeBuilder;
             return $self->loc("System error");
         },
     },
+    Create => {
+        BriefDescription => sub {
+            my $self = shift;
+            my %args = @_;
+            return ( $self->loc( "[_1] created", $args{obj_type} ) );
+        },
+    },
+    Enabled => {
+        BriefDescription => sub {
+            my $self = shift;
+            my %args = @_;
+            return ( $self->loc( "[_1] enabled", $args{obj_type} ) );
+        },
+    },
+    Disabled => {
+        BriefDescription => sub {
+            my $self = shift;
+            my %args = @_;
+            return ( $self->loc( "[_1] disabled", $args{obj_type} ) );
+        },
+    },
 );
 # }}}
 
@@ -897,16 +918,7 @@ sub BriefDescription {
 
     my $obj_type = $self->FriendlyObjectType;
 
-    if ( $type eq 'Create' ) {
-        return ( $self->loc( "[_1] created", $obj_type ) );
-    }
-    elsif ( $type eq 'Enabled' ) {
-        return ( $self->loc( "[_1] enabled", $obj_type ) );
-    }
-    elsif ( $type eq 'Disabled' ) {
-        return ( $self->loc( "[_1] disabled", $obj_type ) );
-    }
-    elsif ( $type =~ /Status/ ) {
+    if ( $type =~ /Status/ ) {
         if ( $self->Field eq 'Status' ) {
             if ( $self->NewValue eq 'deleted' ) {
                 return ( $self->loc( "[_1] deleted", $obj_type ) );
@@ -936,7 +948,7 @@ sub BriefDescription {
     }
 
     if ( my $code = $self->TypeMetadata(Type => $type, Field => 'BriefDescription') ) {
-        return $code->($self);
+        return $code->($self, obj_type => $obj_type);
     }
 
     return $self->loc(

-----------------------------------------------------------------------