[Rt-commit] rt branch, history-filter, updated. rt-3.8.8-92-gb15e86e

Shawn Moore sartak at bestpractical.com
Tue Jun 15 16:47:32 EDT 2010


The branch, history-filter has been updated
       via  b15e86e44b141be8114ff51a405dc302e915dd92 (commit)
      from  28c7babe0e5c1bd07757281fa26f07fe6e3355c1 (commit)

Summary of changes:
 lib/RT/Transaction_Overlay.pm |   14 ++------------
 1 files changed, 2 insertions(+), 12 deletions(-)

- Log -----------------------------------------------------------------
commit b15e86e44b141be8114ff51a405dc302e915dd92
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Tue Jun 15 16:48:18 2010 -0400

    If the description is undef, fallback to "changed from $old to $new"

diff --git a/lib/RT/Transaction_Overlay.pm b/lib/RT/Transaction_Overlay.pm
index 7462ee7..38c9eef 100755
--- a/lib/RT/Transaction_Overlay.pm
+++ b/lib/RT/Transaction_Overlay.pm
@@ -934,21 +934,11 @@ sub BriefDescription {
 
             }
         }
-
-        # Generic:
-        my $no_value = $self->loc("(no value)");
-        return (
-            $self->loc(
-                "[_1] changed from [_2] to [_3]",
-                $self->Field,
-                ( $self->OldValue ? "'" . $self->OldValue . "'" : $no_value ),
-                "'" . $self->NewValue . "'"
-            )
-        );
     }
 
     if ( my $code = $self->TypeMetadata(Type => $type, Field => 'BriefDescription') ) {
-        return $code->($self, obj_type => $obj_type);
+        my $description = $code->($self, obj_type => $obj_type);
+        return $description if defined $description;
     }
 
     return $self->loc(

-----------------------------------------------------------------------


More information about the Rt-commit mailing list