[Rt-commit] rt branch, 3.8-trunk, updated. rt-3.8.8-101-g4313c4b

[? sunnavy]

The branch, 3.8-trunk has been updated
       via  4313c4b943e7b6c365ee46bcf9d353e91f1bd1a4 (commit)
      from  fbbea56f36f87b8907036f1349eee5d99ed9056a (commit)

Summary of changes:
 lib/RT/URI.pm                   |    5 ++++-
 share/html/Elements/MyReminders |    9 ++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 4313c4b943e7b6c365ee46bcf9d353e91f1bd1a4
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Mon Jun 28 16:00:55 2010 +0800

    better msg for the 'can not parse links' error

diff --git a/lib/RT/URI.pm b/lib/RT/URI.pm
index 70654e1..b11ae72 100755
--- a/lib/RT/URI.pm
+++ b/lib/RT/URI.pm
@@ -144,7 +144,10 @@ sub FromURI {
     $self->_GetResolver($scheme);
     
     unless ($self->Resolver->ParseURI($uri)) {
-        $RT::Logger->warning("Resolver ".ref($self->Resolver)." could not parse $uri");
+        $RT::Logger->warning( "Resolver "
+              . ref( $self->Resolver )
+              . " could not parse $uri, maybe Organization config was changed?"
+        );
         $self->{resolver} = RT::URI::base->new( $self->CurrentUser ); # clear resolver
     	return (undef);
     }
diff --git a/share/html/Elements/MyReminders b/share/html/Elements/MyReminders
index 53e3f99..662c7c2 100755
--- a/share/html/Elements/MyReminders
+++ b/share/html/Elements/MyReminders
@@ -55,6 +55,7 @@
 % $i++;
 % if ($reminder->RefersTo->First) {
 % my $ticket= $reminder->RefersTo->First->TargetObj;
+% if ( $ticket ) {
 <tr class="<%$i%2 ? 'evenline' : 'oddline'%>"><td><a href="<%RT->Config->Get('WebPath')%>/Ticket/Display.html?id=<%$ticket->id%>"><%$reminder->Subject%></a><br />
 <blockquote>
 #<%$ticket->id%>: <%$ticket->Subject%><br />
@@ -62,7 +63,13 @@
 </blockquote>
 </td>
 </tr>
-% }}
+% }
+% else {
+    <div class="error"><div class="error">
+Couldn't find TargetObj for reminder <% $reminder->id %>.<br/>
+Maybe Organization config was changed? Please contact administrator.
+    </div></div>
+% }}}
 </table>
 </&>
 

-----------------------------------------------------------------------