[Rt-commit] rt branch, 3.8-trunk, updated. rt-3.8.8-43-g92a1e0f

? sunnavy sunnavy at bestpractical.com
Thu May 13 22:54:47 EDT 2010


The branch, 3.8-trunk has been updated
       via  92a1e0fa105b32eeb109b9e28cc87db8240a588a (commit)
      from  2338cd19ed7a7f4c1e94f639ab2789d6586d01f3 (commit)

Summary of changes:
 lib/RT/Util.pm |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)

- Log -----------------------------------------------------------------
commit 92a1e0fa105b32eeb109b9e28cc87db8240a588a
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri May 14 10:32:37 2010 +0800

    revert 725318d6 as it breaks gnupg part badly

diff --git a/lib/RT/Util.pm b/lib/RT/Util.pm
index 45ba030..03d27a3 100644
--- a/lib/RT/Util.pm
+++ b/lib/RT/Util.pm
@@ -101,7 +101,6 @@ sub _safe_run_child {
     $stdin->fdopen( 0, 'r' );
     local *STDIN = $stdin;
 
-    my $old_stdout = select;
     my $stdout = IO::Handle->new;
     $stdout->fdopen( 1, 'w' );
     local *STDOUT = $stdout;
@@ -110,14 +109,7 @@ sub _safe_run_child {
     $stderr->fdopen( 2, 'w' );
     local *STDERR = $stderr;
 
-    my @return = shift->();
-
-    # no idea why
-    # but if we don't restore $old_stdout, t/web/command_line.t will cry
-    # you can run t/web/command_line.t with GnuPG enabled to reproduce this.
-    select $old_stdout;
-
-    return @return;
+    return shift->();
 }
 
 eval "require RT::Util_Vendor";

-----------------------------------------------------------------------


More information about the Rt-commit mailing list