[Rt-commit] rt branch, 3.8-trunk, updated. rt-3.8.8-51-g5e7d1b0

Kevin Falcone falcone at bestpractical.com
Fri May 14 20:26:22 EDT 2010


The branch, 3.8-trunk has been updated
       via  5e7d1b0e7c5f8191a569ef07dc6dbd52b3965973 (commit)
      from  f2d703a52c80de640c89d495caed39bbd1175fe8 (commit)

Summary of changes:
 .gitignore                                         |    1 +
 configure.ac                                       |    1 +
 etc/RT_Config.pm.in                                |    5 ++
 ...es-extension.in => generate-rtaddressregexp.in} |   54 ++++++++-----------
 4 files changed, 30 insertions(+), 31 deletions(-)
 copy etc/upgrade/{3.8-branded-queues-extension.in => generate-rtaddressregexp.in} (70%)
 mode change 100755 => 100644

- Log -----------------------------------------------------------------
commit 5e7d1b0e7c5f8191a569ef07dc6dbd52b3965973
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Fri May 14 20:21:50 2010 -0400

    When you come up to rt-3.8.8 and it starts warning at you, generate a
    dumb regexp from the Queue.CorrespondAddres/CommentAddress and config
    options.
    
    This could be much smarter, but it 'works'

diff --git a/.gitignore b/.gitignore
index d866c83..adae6e8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,6 +11,7 @@ etc/RT_Config.pm
 etc/upgrade/3.8-branded-queues-extension
 etc/upgrade/3.8-ical-extension
 etc/upgrade/split-out-cf-categories
+etc/upgrade/generate-rtaddressregexp
 lib/RT.pm
 Makefile
 t/data/gnupg/keyrings/random_seed
diff --git a/configure.ac b/configure.ac
index 731c2fd..a108d56 100755
--- a/configure.ac
+++ b/configure.ac
@@ -397,6 +397,7 @@ AC_CONFIG_FILES([
                  etc/upgrade/3.8-branded-queues-extension
                  etc/upgrade/3.8-ical-extension
                  etc/upgrade/split-out-cf-categories
+                 etc/upgrade/generate-rtaddressregexp
                  sbin/rt-attributes-viewer
                  sbin/rt-dump-database
                  sbin/rt-setup-database
diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index fd688cd..6112975 100755
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -284,6 +284,11 @@ regular expression that matches all addresses used by your RT.  This lets RT
 avoid sending mail to itself.  It will also hide RT addresses from the list of 
 "One-time Cc" and Bcc lists on ticket reply.
 
+If you have a number of addresses configured in your RT database already, you
+can generate a naive first pass regexp by using
+
+    perl etc/upgrade/generate-rtaddressregexp
+
 =cut
 
 Set($RTAddressRegexp , undef);
diff --git a/etc/upgrade/generate-rtaddressregexp.in b/etc/upgrade/generate-rtaddressregexp.in
new file mode 100644
index 0000000..45554a2
--- /dev/null
+++ b/etc/upgrade/generate-rtaddressregexp.in
@@ -0,0 +1,87 @@
+#!@PERL@
+# BEGIN BPS TAGGED BLOCK {{{
+# 
+# COPYRIGHT:
+#  
+# This software is Copyright (c) 1996-2008 Best Practical Solutions, LLC 
+#                                          <jesse at bestpractical.com>
+# 
+# (Except where explicitly superseded by other copyright notices)
+# 
+# 
+# LICENSE:
+# 
+# This work is made available to you under the terms of Version 2 of
+# the GNU General Public License. A copy of that license should have
+# been provided with this software, but in any event can be snarfed
+# from www.gnu.org.
+# 
+# This work is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# General Public License for more details.
+# 
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+# 02110-1301 or visit their web page on the internet at
+# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
+# 
+# 
+# CONTRIBUTION SUBMISSION POLICY:
+# 
+# (The following paragraph is not intended to limit the rights granted
+# to you to modify and distribute this software under the terms of
+# the GNU General Public License and is only of importance to you if
+# you choose to contribute your changes and enhancements to the
+# community by submitting them to Best Practical Solutions, LLC.)
+# 
+# By intentionally submitting any modifications, corrections or
+# derivatives to this work, or any other work intended for use with
+# Request Tracker, to Best Practical Solutions, LLC, you confirm that
+# you are the copyright holder for those contributions and you grant
+# Best Practical Solutions,  LLC a nonexclusive, worldwide, irrevocable,
+# royalty-free, perpetual, license to use, copy, create derivative
+# works based on those contributions, and sublicense and distribute
+# those contributions and any derivatives thereof.
+# 
+# END BPS TAGGED BLOCK }}}
+use strict;
+use warnings;
+
+use lib "@LOCAL_LIB_PATH@";
+use lib "@RT_LIB_PATH@";
+
+use RT;
+RT::LoadConfig();
+RT->Config->Set('LogToScreen' => 'debug');
+RT::Init();
+
+$| = 1;
+
+if (my $re = RT->Config->Get('RTAddressRegexp')) {
+    print "No need to use this script, you already have RTAddressRegexp set to $re\n";
+    exit;
+}
+
+use RT::Queues;
+my $queues = RT::Queues->new( $RT::SystemUser );
+$queues->UnLimit;
+$queues->RowsPerPage(100);
+
+my @addresses = (RT->Config->Get('CorrespondAddress'), RT->Config->Get('CommentAddress'));
+while ( my $queue = $queues->Next ) {
+    push @addresses, $queue->CorrespondAddress, $queue->CommentAddress;
+}
+
+my %seen;
+my $re = join '|', map "\Q$_\E",
+    grep defined && length && !$seen{ lc $_ }++,
+    @addresses;
+
+print <<ENDDESCRIPTION;
+You can add the following to RT_SiteConfig.pm, but may want to collapse it into a more efficient regexp.
+Keep in mind that this only contains the email addresses that RT knows about, you should also examine
+your mail system for aliases that reach RT but which RT doesn't know about.
+ENDDESCRIPTION
+print "Set('RTAddressRegexp','^(?:${re})\$');\n";

-----------------------------------------------------------------------


More information about the Rt-commit mailing list