[Rt-commit] rt branch, librarize-send-dashboards, updated. rt-3.9.4-536-g790003b

Shawn Moore sartak at bestpractical.com
Fri Nov 19 15:39:22 EST 2010


The branch, librarize-send-dashboards has been updated
       via  790003b9ae6ab055042a4cf0b6b3132579095777 (commit)
      from  08cffb6f2f9b02eda856cca817bbd6e04770a32d (commit)

Summary of changes:
 lib/RT/Dashboard/Mailer.pm |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

- Log -----------------------------------------------------------------
commit 790003b9ae6ab055042a4cf0b6b3132579095777
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Fri Nov 19 15:38:14 2010 -0500

    Better limit the scope of Mason var localization

diff --git a/lib/RT/Dashboard/Mailer.pm b/lib/RT/Dashboard/Mailer.pm
index 2394060..7d92628 100644
--- a/lib/RT/Dashboard/Mailer.pm
+++ b/lib/RT/Dashboard/Mailer.pm
@@ -68,13 +68,11 @@ sub MailDashboards {
         @_,
     );
 
-    $RT::Logger->info("Using time " . $args{Time} . " for dashboard generation");
+    $RT::Logger->info("Using time $args{Time} for dashboard generation");
 
     my $from = $self->GetFrom();
     $RT::Logger->debug("Sending email from $from");
 
-    local $HTML::Mason::Commands::r = RT::Dashboard::FakeRequest->new;
-
     # look through each user for her subscriptions
     my $Users = RT::Users->new(RT->SystemUser);
     $Users->LimitToPrivileged;
@@ -220,7 +218,9 @@ SUMMARY
         return;
     }
 
-    $HTML::Mason::Commands::session{CurrentUser} = $currentuser;
+    local $HTML::Mason::Commands::session{CurrentUser} = $currentuser;
+    local $HTML::Mason::Commands::r = RT::Dashboard::FakeRequest->new;
+
     my $content = RunComponent(
         '/Dashboards/Render.html',
         id      => $dashboard->Id,

-----------------------------------------------------------------------


More information about the Rt-commit mailing list