[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.9.4-552-g79e24f4

Shawn Moore sartak at bestpractical.com
Mon Nov 22 16:58:42 EST 2010


The branch, 3.9-trunk has been updated
       via  79e24f4be9fa941c240e89b87b565db01d245882 (commit)
      from  203157b6f0dc28976621237a3b01bb82b1ee3cc0 (commit)

Summary of changes:
 lib/RT/Test.pm             |    5 -----
 lib/RT/Test/Email.pm       |    2 --
 lib/RT/Test/GnuPG.pm       |    1 -
 t/mail/charsets-outgoing.t |    2 --
 t/mail/extractsubjecttag.t |    1 -
 t/web/html_template.t      |    2 --
 t/web/ticket_forward.t     |    1 -
 t/web/ticket_txn_content.t |    1 -
 8 files changed, 0 insertions(+), 15 deletions(-)

- Log -----------------------------------------------------------------
commit 79e24f4be9fa941c240e89b87b565db01d245882
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Mon Nov 22 16:58:08 2010 -0500

    Remove set_mail_catcher which is just a no-op
    
        We always catch mail in the new world order

diff --git a/lib/RT/Test.pm b/lib/RT/Test.pm
index 0695da2..8be8403 100644
--- a/lib/RT/Test.pm
+++ b/lib/RT/Test.pm
@@ -912,11 +912,6 @@ sub mailsent_ok {
     );
 }
 
-sub set_mail_catcher {
-    my $self = shift;
-    return 1;
-}
-
 sub fetch_caught_mails {
     my $self = shift;
     return grep /\S/, split /%% split me! %%\n/,
diff --git a/lib/RT/Test/Email.pm b/lib/RT/Test/Email.pm
index c03efe2..cc8c804 100644
--- a/lib/RT/Test/Email.pm
+++ b/lib/RT/Test/Email.pm
@@ -56,8 +56,6 @@ use Email::Abstract;
 use base 'Exporter';
 our @EXPORT = qw(mail_ok);
 
-RT::Test->set_mail_catcher;
-
 =head1 NAME
 
 RT::Test::Email - 
diff --git a/lib/RT/Test/GnuPG.pm b/lib/RT/Test/GnuPG.pm
index da78bbd..fad3d37 100644
--- a/lib/RT/Test/GnuPG.pm
+++ b/lib/RT/Test/GnuPG.pm
@@ -45,7 +45,6 @@ sub import {
         Right => ['CreateTicket', 'ShowTicket', 'SeeQueue', 'ReplyToTicket', 'ModifyTicket'],
     );
 
-    $class->set_mail_catcher;
     $class->export_to_level(1);
 }
 
diff --git a/t/mail/charsets-outgoing.t b/t/mail/charsets-outgoing.t
index 59af27e..e17dd98 100644
--- a/t/mail/charsets-outgoing.t
+++ b/t/mail/charsets-outgoing.t
@@ -18,8 +18,6 @@ my %string = (
     },
 );
 
-RT::Test->set_mail_catcher;
-
 my $queue = RT::Test->load_or_create_queue(
     Name              => 'Regression',
     CorrespondAddress => 'rt-recipient at example.com',
diff --git a/t/mail/extractsubjecttag.t b/t/mail/extractsubjecttag.t
index cf1c667..8a09dfb 100644
--- a/t/mail/extractsubjecttag.t
+++ b/t/mail/extractsubjecttag.t
@@ -7,7 +7,6 @@ use RT::Test tests => 14;
 
 
 my ($baseurl, $m) = RT::Test->started_ok;
-RT::Test->set_mail_catcher;
 
 my $queue = RT::Test->load_or_create_queue(
     Name              => 'Regression',
diff --git a/t/web/html_template.t b/t/web/html_template.t
index 9b6e0d9..b83a524 100644
--- a/t/web/html_template.t
+++ b/t/web/html_template.t
@@ -8,8 +8,6 @@ use Encode;
 my ( $baseurl, $m ) = RT::Test->started_ok;
 ok $m->login, 'logged in as root';
 
-RT::Test->set_mail_catcher;
-
 use utf8;
 
 diag('make Autoreply template a html one and add utf8 chars')
diff --git a/t/web/ticket_forward.t b/t/web/ticket_forward.t
index 83e1908..7e72818 100644
--- a/t/web/ticket_forward.t
+++ b/t/web/ticket_forward.t
@@ -15,7 +15,6 @@ my $att_name = ( File::Spec->splitpath($att_file) )[-1];
 my ( $baseurl, $m ) = RT::Test->started_ok;
 ok $m->login, 'logged in as root';
 
-RT::Test->set_mail_catcher;
 $m->get_ok( $baseurl . '/Ticket/Create.html?Queue=1' );
 
 $m->submit_form(
diff --git a/t/web/ticket_txn_content.t b/t/web/ticket_txn_content.t
index d33d154..8ea4485 100644
--- a/t/web/ticket_txn_content.t
+++ b/t/web/ticket_txn_content.t
@@ -23,7 +23,6 @@ my $queue = RT::Queue->new(RT->Nobody);
 my $qid = $queue->Load('General');
 ok( $qid, "Loaded General queue" );
 
-RT::Test->set_mail_catcher;
 RT::Test->clean_caught_mails;
 
 for my $type ( 'text/plain', 'text/html' ) {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list