[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-689-g5dfcc41

Thomas Sibley trs at bestpractical.com
Fri Sep 3 15:56:47 EDT 2010


The branch, 3.9-trunk has been updated
       via  5dfcc41fee46f1418ed243c0642e89dc12cbae10 (commit)
       via  5759d7288a0675dcaef8ce2a9cb6c1eadc34fe31 (commit)
      from  beda996dd9748b1f6ced33578cd72e7057b1b3c5 (commit)

Summary of changes:
 share/html/Admin/Users/Memberships.html   |    4 ++--
 share/html/Elements/CollectionAsTable/Row |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 5759d7288a0675dcaef8ce2a9cb6c1eadc34fe31
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Sep 3 15:33:30 2010 -0400

    Avoid an undef warning on 5.12

diff --git a/share/html/Elements/CollectionAsTable/Row b/share/html/Elements/CollectionAsTable/Row
index 1ce803f..960e366 100644
--- a/share/html/Elements/CollectionAsTable/Row
+++ b/share/html/Elements/CollectionAsTable/Row
@@ -131,7 +131,7 @@ foreach my $column (@Format) {
             Arguments => [$record, $i],
         );
     }
-    s/\n/<br \/>/gs for @out;
+    s/\n/<br \/>/gs for grep defined $_, @out;
 
     $m->out( $_ .'="'. $m->interp->apply_escapes( $attrs{$_} => 'h' ) .'"' )
         foreach grep $attrs{$_}, qw(align style colspan);

commit 5dfcc41fee46f1418ed243c0642e89dc12cbae10
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Sep 3 15:54:08 2010 -0400

    Limit user group membership collections to something more readable

diff --git a/share/html/Admin/Users/Memberships.html b/share/html/Admin/Users/Memberships.html
index 0fe0081..cae0f06 100644
--- a/share/html/Admin/Users/Memberships.html
+++ b/share/html/Admin/Users/Memberships.html
@@ -63,7 +63,7 @@
     OrderBy => 'Name',
     Order   => 'ASC',
     %ARGS,
-    Rows    => 0,
+    Rows    => 20,
     DisplayFormat => "__CheckBox.{Delete}__,$Format",
     Format => $Format,
     Collection => $is_member,
@@ -76,7 +76,7 @@
 <& /Elements/CollectionList,
     OrderBy => 'Name',
     Order   => 'ASC',
-    Rows    => 100,
+    Rows    => 20,
     %ARGS,
     DisplayFormat => "__CheckBox.{Add}__,'__HasMemberRecursively.{$id}__/TITLE:Recursive',$Format",
     Format => $Format,

-----------------------------------------------------------------------


More information about the Rt-commit mailing list