[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.8.8-830-gc65a665

Alex Vandiver alexmv at bestpractical.com
Mon Sep 20 19:49:49 EDT 2010


The branch, 3.9-trunk has been updated
       via  c65a66522076ad5ee344fee2650652ce75a11047 (commit)
      from  07d6bbc464cf828bbe8f49d717a2bd50254a2a76 (commit)

Summary of changes:
 lib/RT/Attributes_Overlay.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit c65a66522076ad5ee344fee2650652ce75a11047
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Sep 20 19:27:07 2010 -0400

    Only do the attribute search if we have limits; fixes attributes on unborn objects
    
    Previously, calling any attribute methods on an unloaded object would
    result in an unlimited search over the entire Attributes table.  Check
    that LimitToObject managed to construct some limits before attempting
    to complete the search.

diff --git a/lib/RT/Attributes_Overlay.pm b/lib/RT/Attributes_Overlay.pm
index 8b581c1..70224ac 100644
--- a/lib/RT/Attributes_Overlay.pm
+++ b/lib/RT/Attributes_Overlay.pm
@@ -96,7 +96,7 @@ sub _BuildAccessTable {
 
 sub _AttrHash {
     my $self = shift;
-    $self->_DoSearch if ($self->{'must_redo_search'});
+    $self->_DoSearch if ($self->{'must_redo_search'} && $self->{'is_limited'});
     unless ($self->{'attr'}) {
         $self->{'attr'}->{'__none'} = RT::Attribute->new($self->CurrentUser);
     }

-----------------------------------------------------------------------


More information about the Rt-commit mailing list