[Rt-commit] rtir branch, rt-3.9, updated. f2cc9a2b0c21ae012c8b8c33e50ca60d237729bd

[? sunnavy]

The branch, rt-3.9 has been updated
       via  f2cc9a2b0c21ae012c8b8c33e50ca60d237729bd (commit)
      from  4f3a8869f2adc89e4c7ee99c624acb8f495b95cd (commit)

Summary of changes:
 lib/RT/IR.pm |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit f2cc9a2b0c21ae012c8b8c33e50ca60d237729bd
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Sep 24 19:33:06 2010 +0800

    disable cache of RT::IR::CustomFields

diff --git a/lib/RT/IR.pm b/lib/RT/IR.pm
index 1ecdb79..9d7fa11 100644
--- a/lib/RT/IR.pm
+++ b/lib/RT/IR.pm
@@ -231,7 +231,12 @@ sub CustomFields {
         @_%2 ? (Field => @_) : @_
     );
 
-    unless ( keys %cache ) {
+# TODO cache doesn't work with rt 3.9
+# t/customfields/defaults-on-linking.t will fail with cache on
+# maybe because it's called too early somewhere?
+# anyway, seems caching here is not a great idea
+# as it will obstruct cf updates later?
+#    unless ( keys %cache ) {
         foreach my $qname ( @QUEUES ) {
             my $type = TicketType( Queue => $qname );
             $cache{$type} = [];
@@ -259,7 +264,7 @@ sub CustomFields {
         while ( my $cf = $cfs->Next ) {
             push @{ $cache{'Global'} }, $cf;
         }
-    }
+#    }
 
     my $type = TicketType( %arg );
 

-----------------------------------------------------------------------