[Rt-commit] rt branch, 3.9-trunk, updated. rt-3.9.4-13-g69a36d9

Jesse Vincent jesse at bestpractical.com
Wed Sep 29 12:33:19 EDT 2010


The branch, 3.9-trunk has been updated
       via  69a36d96d77a86e6feac67c32c82d4d6f10c5b64 (commit)
      from  ab75250ff5222e1f4c17ab3e64f389c43f3a80f8 (commit)

Summary of changes:
 share/html/Ticket/Elements/ShowTransaction |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 69a36d96d77a86e6feac67c32c82d4d6f10c5b64
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Wed Sep 29 12:35:45 2010 -0400

    Rather than looking for transaction custom fields on any transaction,
    only look for them on "message" transactions.  Rather than doing a count
    to see if it makes sense to show the fields, just try to show the
    fields.  Turns out it's a lot more efficient.

diff --git a/share/html/Ticket/Elements/ShowTransaction b/share/html/Ticket/Elements/ShowTransaction
index 60f8a61..884dd8e 100755
--- a/share/html/Ticket/Elements/ShowTransaction
+++ b/share/html/Ticket/Elements/ShowTransaction
@@ -69,7 +69,7 @@
   </div>
 
     <div class="content">
-% if ( $Transaction->CustomFieldValues->Count ) {
+% if ( $type_class eq 'message') {
       <& /Elements/ShowCustomFields, Object => $Transaction &>
 % }
 % $m->comp('ShowTransactionAttachments', %ARGS, Parent => 0) unless ($Collapsed ||!$ShowBody);

-----------------------------------------------------------------------


More information about the Rt-commit mailing list