[Rt-commit] rt branch, 4.0/fulltext-search, updated. rt-4.0.0-190-gca91cf5

Alex Vandiver alexmv at bestpractical.com
Fri Apr 29 11:45:48 EDT 2011


The branch, 4.0/fulltext-search has been updated
       via  ca91cf50be71497f04fd4bcb2f10ce304678cf4a (commit)
      from  bce3688d864a83f9bf51642770fa6f09b488ed7d (commit)

Summary of changes:
 lib/RT/Tickets.pm |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit ca91cf50be71497f04fd4bcb2f10ce304678cf4a
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Thu Apr 28 18:01:39 2011 -0400

    Since we will immediately limit on fields of these tables, they need not be left
    
    In fact, SearchBuilder makes then not-left after the initial limit on
    them -- but fix it explicitly, and remove the misleading comment

diff --git a/lib/RT/Tickets.pm b/lib/RT/Tickets.pm
index 99a0199..c1b9ea1 100644
--- a/lib/RT/Tickets.pm
+++ b/lib/RT/Tickets.pm
@@ -771,7 +771,6 @@ sub _TransContentLimit {
     my $txn_alias = $self->JoinTransactions;
     unless ( defined $self->{_sql_trattachalias} ) {
         $self->{_sql_trattachalias} = $self->_SQLJoin(
-            TYPE   => 'LEFT', # not all txns have an attachment
             ALIAS1 => $txn_alias,
             FIELD1 => 'id',
             TABLE2 => 'Attachments',
@@ -786,7 +785,6 @@ sub _TransContentLimit {
         my $alias;
         if ( $config->{'Table'} and $config->{'Table'} ne "Attachments") {
             $alias = $self->{'_sql_aliases'}{'full_text'} ||= $self->_SQLJoin(
-                TYPE   => 'LEFT',
                 ALIAS1 => $self->{'_sql_trattachalias'},
                 FIELD1 => 'id',
                 TABLE2 => $config->{'Table'},

-----------------------------------------------------------------------


More information about the Rt-commit mailing list