[Rt-commit] rt branch, 4.0/spurious-user-change-results, updated. rt-4.0.0-173-g1164024

[Shawn Moore]

The branch, 4.0/spurious-user-change-results has been updated
       via  11640242079b6250d5045be6b13275d2a4dcfd7b (commit)
      from  87c3856e67512fa3f8d9d1d4055a6e472098092a (commit)

Summary of changes:
 share/html/User/Prefs.html |    2 +-
 t/web/user_update.t        |    9 +--------
 2 files changed, 2 insertions(+), 9 deletions(-)

- Log -----------------------------------------------------------------
commit 11640242079b6250d5045be6b13275d2a4dcfd7b
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Fri Apr 29 14:58:51 2011 -0400

    Don't list Lang twice in @fields
    
        Otherwise you get a spurious "That is already the current value"
        whenever you change your language.
    
        The TODO test disappears now because we don't try to display the
        "That is already the current value" message any more, so there's
        nothing to be garbled by loc_fuzzy.

diff --git a/share/html/User/Prefs.html b/share/html/User/Prefs.html
index 863ebf9..0ace58a 100755
--- a/share/html/User/Prefs.html
+++ b/share/html/User/Prefs.html
@@ -214,7 +214,7 @@ my @fields = qw(
     Organization RealName NickName Lang EmailEncoding WebEncoding 
     ExternalContactInfoId ContactInfoSystem Gecos ExternalAuthId 
     AuthSystem HomePhone WorkPhone MobilePhone PagerPhone Address1
-    Address2 City State Zip Country Lang Timezone
+    Address2 City State Zip Country Timezone
 );
 
 $m->callback(
diff --git a/t/web/user_update.t b/t/web/user_update.t
index 5b7ceb3..dc908fc 100644
--- a/t/web/user_update.t
+++ b/t/web/user_update.t
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 use utf8;
-use RT::Test tests => 10;
+use RT::Test tests => 9;
 
 my ( $url, $m ) = RT::Test->started_ok;
 ok( $m->login(), 'logged in' );
@@ -30,10 +30,3 @@ $m->text_contains("Langは「'ja'」から「'en_us'」に変更されました"
 # another spurious update
 $m->content_lacks("That is already the current value");
 
-# This text is not in the RT source (including .po files)!
-# [issues.bestpractical.com #16913]
-TODO: {
-    local $TODO = "this is caused by an overzealous loc_fuzzy";
-    $m->content_lacks("the current value-is-already That");
-};
-

-----------------------------------------------------------------------