[Rt-commit] rt branch, 3.8/address-deprecations, updated. rt-3.8.10-22-g96434ce
Alex Vandiver
alexmv at bestpractical.com
Wed Aug 3 14:11:45 EDT 2011
The branch, 3.8/address-deprecations has been updated
via 96434ce0de13a7a6d2858b2696d6b8bc6bacf4a8 (commit)
from edd07b4279610bd45becc761581edfb39f0c4a05 (commit)
Summary of changes:
lib/RT/Action/CreateTickets.pm | 2 +-
share/html/Ticket/Elements/PreviewScrips | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
- Log -----------------------------------------------------------------
commit 96434ce0de13a7a6d2858b2696d6b8bc6bacf4a8
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Wed Aug 3 14:11:26 2011 -0400
Fix a few more cases of "foreach my $foo qw(...) { ... }"
This syntax is deprecated in perl 5.14
diff --git a/lib/RT/Action/CreateTickets.pm b/lib/RT/Action/CreateTickets.pm
index c81a4fd..08763d5 100755
--- a/lib/RT/Action/CreateTickets.pm
+++ b/lib/RT/Action/CreateTickets.pm
@@ -723,7 +723,7 @@ sub ParseLines {
}
}
- foreach my $date qw(due starts started resolved) {
+ foreach my $date (qw(due starts started resolved)) {
my $dateobj = RT::Date->new( $self->CurrentUser );
next unless $args{$date};
if ( $args{$date} =~ /^\d+$/ ) {
diff --git a/share/html/Ticket/Elements/PreviewScrips b/share/html/Ticket/Elements/PreviewScrips
index a7576e5..dcf85a5 100755
--- a/share/html/Ticket/Elements/PreviewScrips
+++ b/share/html/Ticket/Elements/PreviewScrips
@@ -65,7 +65,7 @@ my @non_recipients = @{ $squelch{'EmailAddresses'} };
<b><% $scrip->Description || loc('Scrip #[_1]',$scrip->id) %></b><br />
<&|/l, loc($scrip->ConditionObj->Name), loc($scrip->ActionObj->Name), loc($scrip->TemplateObj->Name)&>[_1] [_2] with template [_3]</&>
<br />
-%foreach my $type qw(To Cc Bcc) {
+%foreach my $type (qw(To Cc Bcc)) {
%my @addresses = $scrip->ActionObj->Action->$type();
<ul>
%foreach my $addr (@addresses) {
@@ -90,7 +90,7 @@ my @non_recipients = @{ $squelch{'EmailAddresses'} };
% next unless $rule->{hints} && $rule->{hints}{class} eq 'SendEmail';
<b><% $rule->Describe %></b>
% my $data = $rule->{hints}{recipients};
-% foreach my $type qw(To Cc Bcc) {
+% foreach my $type (qw(To Cc Bcc)) {
<ul>
% foreach my $address (@{$data->{$type}}) {
<li>
@@ -205,7 +205,7 @@ foreach my $scrip ( @{ $txn->Scrips->Prepared } ) {
my $action = $scrip->ActionObj->Action;
next unless $action->isa('RT::Action::SendEmail');
- foreach my $type qw(To Cc Bcc) {
+ foreach my $type (qw(To Cc Bcc)) {
push @recipients, $action->$type();
}
}
@@ -250,7 +250,7 @@ foreach my $scrip ( @{ $txn->Scrips->Prepared } ) {
my $action = $scrip->ActionObj->Action;
next unless $action->isa('RT::Action::SendEmail');
- foreach my $type qw(To Cc Bcc) {
+ foreach my $type (qw(To Cc Bcc)) {
push @recipients, $action->$type();
}
}
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list