[Rt-commit] rt branch, 4.0/minimize-minification-cost, created. rt-4.0.1-227-g2fb280a

Kevin Falcone falcone at bestpractical.com
Thu Aug 4 11:36:46 EDT 2011


The branch, 4.0/minimize-minification-cost has been created
        at  2fb280abb925dd6c43f5af8546b24eea636ca0ad (commit)

- Log -----------------------------------------------------------------
commit 2fb280abb925dd6c43f5af8546b24eea636ca0ad
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Thu Aug 4 11:32:52 2011 -0400

    JavaScrip::Minifier takes at least 3 seconds to run, to save 32K(15%)
    
    jsmin takes .1 extra seconds, so if you need to save the 32K, install it
    and use it.  This takes the runtime of HeaderJavascript from
    3.1988s to 0.0989.

diff --git a/lib/RT/Squish/JS.pm b/lib/RT/Squish/JS.pm
index f59ed34..4841a9c 100644
--- a/lib/RT/Squish/JS.pm
+++ b/lib/RT/Squish/JS.pm
@@ -114,15 +114,6 @@ sub Filter {
         }
     }
 
-    unless ($minified) {
-        eval { require JavaScript::Minifier };
-        if ($@) {
-            $RT::Logger->debug("can't load JavaScript::Minifier: $@");
-        }
-        else {
-            $content = JavaScript::Minifier::minify( input => $content );
-        }
-    }
     return $content;
 }
 
diff --git a/sbin/rt-test-dependencies.in b/sbin/rt-test-dependencies.in
index 91842d6..04fe46e 100755
--- a/sbin/rt-test-dependencies.in
+++ b/sbin/rt-test-dependencies.in
@@ -231,7 +231,6 @@ Text::WikiFormat 0.76
 CSS::Squish 0.06
 Devel::StackTrace 1.19
 JSON
-JavaScript::Minifier
 IPC::Run3
 .
 

-----------------------------------------------------------------------


More information about the Rt-commit mailing list