[Rt-commit] rt annotated tag, rt-4.0.2rc1, created. rt-4.0.2rc1

Thomas Sibley trs at bestpractical.com
Mon Aug 8 11:58:25 EDT 2011


The annotated tag, rt-4.0.2rc1 has been created
        at  9fd7f73033e1994ac4f6aeca944ae4f0da00eeb0 (tag)
   tagging  9e8547bcb8b38e35f850e828a902db18040785af (commit)
  replaces  rt-4.0.1
 tagged by  Thomas Sibley
        on  Mon Aug 8 10:17:26 2011 -0400

- Log -----------------------------------------------------------------
release 4.0.2rc1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQBOP+/2Hdv9ZfNcOAcRAm6RAJoCkyG02StqFsurgUaTH/cmc4uAQgCfd2aX
MQz3Im99CaaMOhYwoqj2So4=
=ABiv
-----END PGP SIGNATURE-----

Alex Vandiver (101):
      Replace 3384147 with a less error-prone explicit loop
      Merge branch '3.8/fix-users-whohaveroleright' into 3.8-trunk
      Tests for exposing private componets
      Restrict PrimaryGroupBy to only the explicit options that we offer
      Prevent FIELD- and OPERATOR- based SQL injection at the RT::SB level
      Lock down possible OCFV columns to the two that we use
      Use closures instead of eval to construct external CF limits
      Disallow SQL injection in FIELD argument to OrderBy
      Allow the logout page to specify a URL to redirect to
      Update the two reports which used the short form of User in charting
      Use Apache->the_request for mod_perl1 compat, instead of ->unparsed_uri
      We do not link the results in the table in this version
      Merge branch '3.8/transactionbatch-permissions' into 3.8-trunk
      Merge branch '3.8/stop-saving-multiple-basedon' into 3.8-trunk
      Merge branch '3.8/fix-charts-grouping-not-english' into 3.8-trunk
      Merge branch '4.0/advanced-search-unknown-field-fix' into 4.0-trunk
      Merge branch '4.0/plack-test-server-name-fix' into 4.0-trunk
      Merge branch '4.0/disable-att-quote-folding' into 4.0-trunk
      Force binary signatures, overriding default-to-ascii from config files
      Make the attachments list have a stable order
      Merge branch '3.8-trunk' into 4.0-trunk
      Merge branch '4.0/config-cleanup' into 4.0-trunk
      loc_pair is incorrect, as it adds a "label" localization; loc is sufficient
      Merge branch '4.0/hacking-locs' into 4.0-trunk
      Merge branch '4.0/config-loc' into 4.0-trunk
      Only redirect if we have a valid object (creation was successful)
      Rather than aborting and leaving an empty page, use @results to show the error
      Use $Group->Id to properly handle when creation failed, now that it can
      During user and group creation, keep submitted values on error
      Update tests for duplicate group name not Abort()'ing anymore
      Use single quotes for empty strings in email settings
      Merge branch '4.0.1-releng' into 4.0-trunk
      Add a bare-bones apache.conf for running RT in various ways
      Remove a call to the now-nonexistant /Articles/Article/Elements/Tabs
      Test that group dashboards are correctly listed
      Split the group rights checking into its own file
      Clarify the tests as to who should have which right if queried directly
      Test with a group with no rights, but which the user is a member of
      Add tests to show that the users don't have the right prior to the grant
      Fix the join direction on ForWhichCurrentUserHasRight
      Rewrite ForWhichCurrentUserHasRight, and add more tests
      Add back prevention for "used only once" warnings, removed in the split in 47b1c48
      Prevent disabled groups from allowing rights in ForWhichCurrentUserHasRight
      Add a plan back to the testfile
      Rather than create two identically-named "inner dashboards", name them differently
      Make dashboards which are only visible from superuser rights not appear in the menu
      Explain why we're skipping superusers in the menu
      Properly match on either UpdateType or Action
      Merge branch '3.8/overlayable-approvals' into 3.8-trunk
      Merge branch '3.8/overridable-approval-notes' into 3.8-trunk
      Use StudlyCaps instead of under_scores, for consistency, and pass %ARGS by ref
      Merge branch '3.8/showtransaction-callbacks' into 3.8-trunk
      Make rt-test-dependencies not warn when passed --with-standalone
      Having SeeGroupDashboard on a group is insufficient; you must also be a member
      Ensure that we do not return disabled groups
      Tests for superuser rights, and group membership interactions
      Rename IncludeSuperusers in ObjectsForLoading to reflect that it only acts on group rights
      Make the dashboard portlet not include groups visible because of superuser privs, like the menu
      Merge branch '4.0/configure-web-handler' into 4.0-trunk
      Merge branch '4.0/preferences-viewer' into 4.0-trunk
      Merge branch '4.0/mobile-ui-next-page-fix' into 4.0-trunk
      Merge branch '4.0/articles-webpath' into 4.0-trunk
      Merge branch '4.0/cfs-in-simple-search' into 4.0-trunk
      Merge branch '4.0/default-time-units' into 4.0-trunk
      Merge branch '4.0/global-cf-in-create-tickets' into 4.0-trunk
      Merge branch '4.0/global-scrips-in-queue-page-fix' into 4.0-trunk
      Merge branch '4.0/gnupg-headers-fix' into 4.0-trunk
      Merge branch '4.0/install-docs' into 4.0-trunk
      Merge branch '4.0/issue-17503' into 4.0-trunk
      Merge branch '4.0/limittoglobal-fix' into 4.0-trunk
      Merge branch '4.0/load-user-in-sendmail-fix' into 4.0-trunk
      Merge branch '4.0/mime-head-add-fix' into 4.0-trunk
      Merge branch '4.0/octet-typo-fix' into 4.0-trunk
      Re-indent
      Merge branch '4.0/reset-auth-token-fix' into 4.0-trunk
      Merge branch '4.0/rest-delete-ticket-fix' into 4.0-trunk
      Remove inaccessible code copied from t/web/rest.t
      Merge branch '4.0/rest-string-eval' into 4.0-trunk
      Merge branch '4.0/rfc822-attachment' into 4.0-trunk
      Merge branch '4.0/transaction-link-classes' into 4.0-trunk
      Merge branch '4.0/user-group-search-fix' into 4.0-trunk
      Fix direction of conditional
      When forwarding, adjust expected subject line according to ForwardFromUser
      Merge branch '4.0/web-forward-show-from' into 4.0-trunk
      Merge branch '4.0/sort-attachments' into 4.0-trunk
      Merge branch '4.0/test-tempdirs' into 4.0-trunk
      Merge branch '4.0/redirect-after-quick-create' into 4.0-trunk
      Merge branch '4.0/skip-optional-deps-in-tests' into 4.0-trunk
      Fix a few more cases of "foreach my $foo qw(...) { ... }"
      Merge branch '3.8/qw-deprecations' into 3.8-trunk
      Merge branch '4.0/ignore-local-rtrc' into 4.0-trunk
      Work around a bug in perl < 5.12 where use of => enables the utf8 flag
      Merge branch '3.8/set-mime-encoding-fallback' into 3.8-trunk
      Merge branch '3.8-trunk' into 4.0-trunk
      Merge branch '4.0/minimize-minification-cost' into 4.0.2-releng
      Save on data trasferred on the login page
      Merge branch '4.0/loc-cleanups' into 4.0-trunk
      Run extract-message-catalog
      Fix quotes in PO files that 12a880d introduced
      PO file updates from launchpad
      Merge branch '4.0-trunk' into 4.0.2-releng

Bram (1):
      Remove empty recipients from the To, Cc and Bcc header before removing the inappropriate recipients

Chia-liang Kao (1):
      merge translation from rosseta

Emmanuel Lacour (3):
      Silent a potential undef warning
      Fix and add some missing strings localizations in tabs
      Add missing loc call for "Global Topics"

Jason May (21):
      Make the default root credentials more obvious
      Require GnuPG::Interface at runtime to avoid premature imports
      Pass skip_all into the test object if it's imported
      Skip chart tests if GD isn't installed
      Only show the next page if the total doesn't exceed rows * pages
      Reflect the substitutions in the .po files
      Remove HTML from the shredder msgstrs
      Substitute 'root' to reflect the substitution in the template
      Make permissions on the .po files more consistent
      Substitute 'fulltext:' to reflex Shawn's change to the template
      Substitute "Let's go!" in the PO files
      Add a tool to change msgstrs "in-place" for matching msgids
      Substitute some HTML in the custom-field loc
      Remove a stray </p> from an init-install loc string
      Change <i>%1</i> to "%1" in an Install loc string
      Remove <p> tags from a token warning in the loc strings
      Substitute the HTML in the 'New ticket in' loc string
      Unset the 'to-change' flag to avoid modifying subsequent lines
      Remove stray </a> to get the GPL loc string the template to translate
      Fix some of the "for qw(...)" syntax that's deprecated in 5.14
      Place the HTML outside of the loc string in Search/Simple.html

Jesse Vincent (2):
      A new version of the overlay loading code that doesn't use string eval
      Remove string eval to set the RT::Handle's superclass

Kevin Falcone (54):
      Handle BasedOn in initialdata
      Remove yet-still-more string eval overlay loads
      Switch to using RT::Base->_ImportOverlays
      some old loop cleanup flagged by perlcritic
      Make this private method public
      temp - define our policy
      More perlcritic fixups
      minor warnings cleanups
      Stop warnings from running at more severe levels that flag RT::Logger
      provide pointers to the .perlcriticrc
      Allow prefixing of the cflabel/cfentry html ids in EditCustomFields
      Allow users to add an extra dynamic column to the display
      Merge branch '3.8/basedon-initialdata' into 3.8-trunk
      Merge branch '3.8/admin-editcfs-callbacks' into 3.8-trunk
      Merge branch '3.8/perlcritic' into 3.8-trunk
      Merge branch '3.8/rtir-cf-id-handling' into 3.8-trunk
      Simple test for incoming multipart email being sent back out as an attachment
      3.8 doesn't test warnings, so it has 2 fewer tests per file than 4.0
      Previously, we killed the RowsPerPage() call to avoid harming the cache
      Merge branch '3.8/multipart-mail-fail' into 3.8-trunk
      CGI.pm 3.51 started tossing charset onto every content-type
      prepare for 3.8.10rc1
      Stop direct access to richtext editor files
      Tests - now with more passing
      Merge branch 'security/3.8/customfield-column-injection' into 3.8.10-releng
      Merge branch 'security/3.8/external-cf-eval' into 3.8.10-releng
      Merge branch 'security/3.8/force-null' into 3.8.10-releng
      Merge branch 'security/3.8/limit-security-restriction' into 3.8.10-releng
      Merge branch 'security/3.8/orderby-injection' into 3.8.10-releng
      Merge branch 'security/3.8/path-traversal' into 3.8.10-releng
      Merge branch 'security/3.8/private-components' into 3.8.10-releng
      Merge branch 'security/3.8/restrict-charting' into 3.8.10-releng
      Merge branch 'security/3.8/richtext-autohandler' into 3.8.10-releng
      Merge branch 'security/3.8/ticketsql-private-fields' into 3.8.10-releng
      Merge branch 'security/3.8/validate-refresh' into 3.8.10-releng
      Bump version for 3.8.10
      Merge branch '3.8.10-releng' into 3.8-trunk
      Net::LDAP::Contant was breaking when trying to modify $_
      Walk around acls when determining transaction type
      Without this, it was possible to have multiple BasedOn Attributes
      Merge branch '3.8/no-dollar-underbar' into 3.8-trunk
      Install everything in the docs/ directory
      Refactor the note logic so you can change it
      Allow overrides without copying the whole file
      Fix typo that was preventing cleaning of file sessions
      Fix typo that was preventing cleaning of file sessions
      Merge branch '4.0/add-missing-loc-queue-watcher' into 4.0-trunk
      Add a new rt-preferences-viewer script
      Merge branch '4.0/user-group-creation-errors' into 4.0-trunk
      JavaScrip::Minifier takes at least 3 seconds to run, to save 32K(15%)
      Merge branch '4.0/group-dashboards' into 4.0-trunk
      Merge branch '4.0/single-quote-email-config-settings' into 4.0.2-releng
      Merge branch '4.0/search-titlebox-fix' into 4.0.2-releng
      Merge branch '4.0/no-ckeditor-on-login' into 4.0.2-releng

Matt Zagrabelny (2):
      Callback added to massage attachments Provide a means to tweak attachments before calling ShowTransactionAttachments.
      Callback added to possibly change type_class value

Mikal Kolbein Gule (1):
      Fix RT::Shredder::Plugin->List to correctly return paths

Ruslan Zakirov (1):
      fix charts groupping, mistranslated string

Shawn M Moore (44):
      Merge branch '3.8/translation-updates' into 3.8-trunk
      All of these requests oughta result in an error code
      First pass at MaybeRejectPrivateComponentRequest
      Use the requested path directly for private component checking
      Explain why we're using PATH_INFO instead of request_comp
      More explanation
      Use request_comp but don't check for dhandler
      Copy 4.0's path-traversal.t and tweak it for 3.8
      Forbid /. in Standalone
      Traversal protection for fastcgi_server and mason_handler.fcgi.in
      Traversal protection for webmux.pl (mod_perl)
      Traversal protection for speedycgi and svc
      path-traversal test for a SendStaticFile dhandler
      Construct a path we can usefully test for /. in webmux.pl
      More tests for unsafe and safe URLs
      Use only the integer number of seconds in the Refresh header
      Avoid testing files out of RichText
      Remove assinine string eval from REST API
      Remove an extraneous </a> tag in our GPL link loc text
      Refactor the create-ticket loc string to have less HTML
      Skip StyleGuide from loc extraction
      Move <p> tags outside of a loc string
      Move a stray </p> tag out of the loc string
      Factor out a <span> from the current-user loc string
      Factor out the search builder link tags
      Factor out some <tt>VARIABLE</tt>s from loc strings
      Factor out the fulltext: of simple search
      Factor out the <tt>root</tt>
      Cute trick: use the same Let's go! as the actual translation
      Lock down the queries loc string a lot
      Factor the <span> out of a Shredder error message
      Basic tests for sorting tickets through the REST API
      Merge branch '4.0/enhance-checkbox-select-all' into 4.0-trunk
      Document that standalone is a valid web-handler
      Move a $ inside the associated C<...> block.
      Missing punctuation
      Merge branch '4.0/tabs-loc-fixes' into 4.0-trunk
      loc_pair lifecycles labels
      First pass at an Internationalization section of hacking.pod
      Fix mistaken use of # loc_left_pair
      Merge branch '4.0/clean-lifecycle-rights' into 4.0-trunk
      LimitToGlobal doesn't take any parameters
      Add classes to our transaction link tags
      More consistent layout for transaction links

Stoned Elipot (1):
      Add missing loc() call

Thomas Sibley (42):
      Users->WhoHaveRoleRight wasn't actually limiting to any objects
      Test that values for IS and IS NOT are forced to NULL
      Override Limit further to force values to NULL for IS and IS NOT
      Test that our UI canonicalizes values to NULL for IS/IS NOT
      A failing test that searches by invalid watcher subfields in TicketSQL
      Limit watcher subfields to a valid subset
      Flesh out the tests for rfc822 attachments when building a transaction MIME entity
      Move content_as_mime helper function back to the bottom
      Ensure RT::Test doesn't declare no_plan for us, which conflicts with done_testing
      Actually check the empty forward mail was sent
      Test forwarding transactions that have an empty "content" part and non-existent "content" part
      Rework both ContentAsMIME methods to reconstruct the original message
      Explain why we check ACLs here
      Transactions are messages, so use an appropriate content type
      Rather than bury the forward one level deeper, just add it as a top level part
      Add a description to the MIME entity representing the forwarded ticket
      Setup our test attachments with a disposition of attachment rather than inline
      message/rfc822 isn't multipart, and transactions only have one top attachment
      Our Content-Disposition inspecting condition can be simplified
      Update the message/rfc822 tests to reflect the current RT::Transaction->ContentAsMIME
      Reconstruct message/* attachments correctly from their child attachments
      Cherry pick back d9f6bba062815e698298f6bd04fe312647123011
      bootstrap_tempdir is called from import, so go one step higher in the callstack
      Respect xt/ author test directories in extensions when creating tempdirs
      Redirect back to ourselves after quick ticket creation to avoid POST duplicates
      Create a flat set of test temp directories instead of a hierarchy
      %g can lose minutes and produce scientific notation
      Turn DefaultTimeUnitsToHours into a user preference
      This test file tests the simple googleish search, not the queue list we call quicksearch
      Failing tests for CF.Name:value syntax in the googleish search
      Identify custom fields in TicketSQL with 'CF.{Name}' not CF.'Name'
      Include __WebPath__ in the articles search format
      Merge branch '4.0/dryrun-comment' into 4.0-trunk
      Ignore case when sorting attachments by filename
      Prefer an implicit index.html over explicitly specifying it
      Adjust tests to take into account the new redirect after quickcreate
      Switch to using $0 instead of caller to get the test file name
      Minor nit -- don't create tmp dirs starting with a hyphen when we don't have a test file
      Note where the access and error logs are
      Merge branch '4.0/apache-conf-for-testing' into 4.0-trunk
      Merge branch '4.0/web-create-disabled-cf-fix' into 4.0-trunk
      Explicitly ignore $HOME/.rtrc when running bin/rt tests

sunnavy (32):
      escape exactly the same things that FCKEditor does when comparing sigs, see also #16691
      move parse_mail to Test.pm
      only one entity seems more right
      Txn->Attachments is cached, so do not limit rows
      test rfc822 attachment
      disable attachments' quote folding
      we don't seem use _rt_dict anywhere
      we have Filename in table already
      support CheckboxNameRegex to filter by the regex, see also #13421
      tweak titlebox of search: escape "[" and "]" except in [_1] automatically
      search titlebox test with "[" and "]" in description
      test if user's existance before calling ->Privileged to avoid warnings
      clean: we don't seem make use of $Disabled at all
      respect Enable field even on create
      abstract GetForwardFrom so we can use otherwhere
      good to show From in forward page
      when user selects one, he means '=' instead of 'LIKE'
      typo fix
      MIME::Head->add fix: we meant "replace" in some cases
      load global cf if no such cf with that name in queue
      show more info of global scrips in queue page to make admin happy
      avoid error "Unknown field: Status" or alike in advanced search
      test lower cased field in advanced search
      values of X-RT-(Sign|Encrypt) are either 1 or 0, not ARRAY(...)
      X-RT-(Encrypt|Sign) tests
      we don't set arguments when calling RT::Test->started_ok
      don't update other fields if user clicks ResetAuthToken
      typo fix for octet-stream
      Revert "Encode::from_to don't die unless we tell it to. see also #7126"
      TODO revalent tests as we reverted 49fa675
      removed the eval and the unreachable if ($@) code.
      rest fix: check "DeleteTicket" right if we are deleting a ticket.

-----------------------------------------------------------------------


More information about the Rt-commit mailing list