[Rt-commit] rt branch, 4.0/dashbord-chart-with-utf8, created. rt-4.0.1-300-gcb4956f

? sunnavy sunnavy at bestpractical.com
Tue Aug 9 01:24:45 EDT 2011


The branch, 4.0/dashbord-chart-with-utf8 has been created
        at  cb4956f32a400948f6008b6d86a80a16aabd9881 (commit)

- Log -----------------------------------------------------------------
commit b7923159fd24e36e50ef1674365c8e2315484ae5
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Aug 9 13:23:56 2011 +0800

    encode_utf8 is more right compared to _utf8_off

diff --git a/lib/RT/Dashboard/Mailer.pm b/lib/RT/Dashboard/Mailer.pm
index ae10d21..5d5d16d 100644
--- a/lib/RT/Dashboard/Mailer.pm
+++ b/lib/RT/Dashboard/Mailer.pm
@@ -476,8 +476,7 @@ sub BuildEmail {
 }
 
 sub GetResource {
-    my $string = shift;
-    Encode::_utf8_off($string);
+    my $string = Encode::encode_utf8(shift);
     my $uri = URI->new($string);
     my ($content, $filename, $mimetype, $encoding);
 

commit cb4956f32a400948f6008b6d86a80a16aabd9881
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Aug 9 13:24:17 2011 +0800

    what we actually test is utf8 data

diff --git a/t/mail/dashboard-chart-with-umlauts.t b/t/mail/dashboard-chart-with-utf8.t
similarity index 100%
rename from t/mail/dashboard-chart-with-umlauts.t
rename to t/mail/dashboard-chart-with-utf8.t

-----------------------------------------------------------------------


More information about the Rt-commit mailing list