[Rt-commit] rt branch, 4.0/remove-oracle-binary-flag, created. rt-4.0.2rc1-7-g57a2808

[Kevin Falcone]

The branch, 4.0/remove-oracle-binary-flag has been created
        at  57a2808d460b3dd7427d31dc9b60fdf70f07efb3 (commit)

- Log -----------------------------------------------------------------
commit 57a2808d460b3dd7427d31dc9b60fdf70f07efb3
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Wed Aug 10 13:53:05 2011 -0400

    Remove the --binary flag
    
    Without running CONTENT through an unbase64er, this flag just adds a lot
    of extra data to your index and you might accidentally match something
    in a substring of the base64.  It also implies we have functionality
    that we don't

diff --git a/docs/full_text_indexing.pod b/docs/full_text_indexing.pod
index 41b2449..bfbc53b 100644
--- a/docs/full_text_indexing.pod
+++ b/docs/full_text_indexing.pod
@@ -147,11 +147,6 @@ triggers to support this index.  The script will also output an
 appropriate C<%FullTextSearch> configuration to add to your
 F<RT_SiteConfig>.
 
-The Oracle index determines which content types it will index, at
-creation time.  By default, unknown content-types are ignored; to
-instead index unknown content-types as binary data, pass the C<--binary>
-flag to C<rt-setup-fulltext-index>.
-
 =head2 Updating the index
 
 To update the index, you will need to run the following at regular
diff --git a/sbin/rt-setup-fulltext-index.in b/sbin/rt-setup-fulltext-index.in
index a564fb6..eb40cf3 100644
--- a/sbin/rt-setup-fulltext-index.in
+++ b/sbin/rt-setup-fulltext-index.in
@@ -118,7 +118,6 @@ GetOptions(
     'h|help!'        => \$OPT{'help'},
     'ask!'           => \$OPT{'ask'},
     'dry-run!'       => \$OPT{'dryrun'},
-    'binary!'        => \$OPT{'binary'},
     'attachments!'   => \$OPT{'attachments'},
 
     'table=s'        => \$OPT{'table'},
@@ -502,7 +501,6 @@ sub ora_create_format_column {
                 WHEN fname IS NOT NULL THEN 'ignore'
         };
     }
-    my $binary = $OPT{'binary'} ? 'binary' : 'ignore';
     $detect_format .= qq{
                 WHEN type = 'text' THEN 'text'
                 WHEN type = 'text/rtf' THEN '$binary'
@@ -518,7 +516,7 @@ sub ora_create_format_column {
                 WHEN type LIKE '%zip%' THEN 'ignore'
                 WHEN type LIKE '%tar%' THEN 'ignore'
                 WHEN type LIKE '%/octet-stream' THEN 'ignore'
-                ELSE '$binary'
+                ELSE 'ignore'
             END;
             RETURN format;
         END;
@@ -711,11 +709,10 @@ To test what will happen without running any DDL, pass the C<--dryrun>
 flag.
 
 The Oracle index determines which content-types it will index at
-creation time.  By default, unknown content-types are ignored; to
-instead index unknown content-types as binary data, pass the C<--binary>
-flag when the index is created.  By default, uploaded attachments
-(attachments with filenames) are indexed; to ignore these instead, pass
-the C<--no-attachments> flag when the index is create.
+creation time. By default, uploaded attachments (attachments with
+filenames) are indexed; to ignore these instead, pass the
+C<--no-attachments> flag when the index is create.
+
 
 =head1 AUTHOR
 

-----------------------------------------------------------------------