[Rt-commit] rt branch, 4.2/remove-externalauthinfo-stub-block, created. rt-4.0.1-401-ga240275

[Alex Vandiver]

The branch, 4.2/remove-externalauthinfo-stub-block has been created
        at  a24027525c03a78275210567c051e7313e65bfaf (commit)

- Log -----------------------------------------------------------------
commit c9c7e7601e88aaa713a621805295a37ba813061f
Merge: 83e64c8 1a26475
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Fri Aug 5 16:01:40 2011 -0400

    Merge branch '4.2/improve-subject-parsing'


commit 2bd35abf567a55223122cedc01c18337685f47be
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Fri Aug 12 03:29:52 2011 -0400

    Remove an empty WebExternalAutoInfo block which could never run
    
    Not only do we not support running under Windows, and the block is
    empty, but there has never been a Net::AdminMisc module released,
    anywhere -- most probably it was meant to be Win32::AdminMisc.

diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
index cb22847..ae6b8a3 100644
--- a/lib/RT/Interface/Web.pm
+++ b/lib/RT/Interface/Web.pm
@@ -188,9 +188,6 @@ sub WebExternalAutoInfo {
         my ( $comments, $realname ) = ( getpwnam($user) )[ 5, 6 ];
         $user_info{'Comments'} = $comments if defined $comments;
         $user_info{'RealName'} = $realname if defined $realname;
-    } elsif ( $^O eq 'MSWin32' and eval 'use Net::AdminMisc; 1' ) {
-
-        # Populate fields with information from NT domain controller
     }
 
     # and return the wad of stuff

commit a24027525c03a78275210567c051e7313e65bfaf
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Fri Aug 12 14:04:44 2011 -0400

    Remove conditional around code that should always be run
    
    All of the OSes which we run on implement getpwnam.

diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
index ae6b8a3..a119f57 100644
--- a/lib/RT/Interface/Web.pm
+++ b/lib/RT/Interface/Web.pm
@@ -181,14 +181,10 @@ sub WebExternalAutoInfo {
         $user_info{'Privileged'} = 1;
     }
 
-    if ( $^O !~ /^(?:riscos|MacOS|MSWin32|dos|os2)$/ ) {
-
-        # Populate fields with information from Unix /etc/passwd
-
-        my ( $comments, $realname ) = ( getpwnam($user) )[ 5, 6 ];
-        $user_info{'Comments'} = $comments if defined $comments;
-        $user_info{'RealName'} = $realname if defined $realname;
-    }
+    # Populate fields with information from Unix /etc/passwd
+    my ( $comments, $realname ) = ( getpwnam($user) )[ 5, 6 ];
+    $user_info{'Comments'} = $comments if defined $comments;
+    $user_info{'RealName'} = $realname if defined $realname;
 
     # and return the wad of stuff
     return {%user_info};

-----------------------------------------------------------------------