[Rt-commit] rt branch, 3.8/perlcritic, updated. rt-3.8.10-207-g5cecfff

[Alex Vandiver]

The branch, 3.8/perlcritic has been updated
       via  5cecfffca6994a5dd8f6dc6bab81d317e60e674e (commit)
      from  8cbdb875383758285298f4bcf1d8282b4d04667c (commit)

Summary of changes:
 bin/rt-crontool.in                  |    1 +
 etc/upgrade/upgrade-mysql-schema.pl |    6 +++++-
 2 files changed, 6 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 5cecfffca6994a5dd8f6dc6bab81d317e60e674e
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Aug 22 12:58:27 2011 -0400

    Add return statements to the end of the few subs still missing them

diff --git a/bin/rt-crontool.in b/bin/rt-crontool.in
index 345899f..3c20e19 100755
--- a/bin/rt-crontool.in
+++ b/bin/rt-crontool.in
@@ -308,6 +308,7 @@ sub load_module {
     my $modname = shift;
     $modname->require
         or die loc( "Failed to load module [_1]. ([_2])", $modname, $@ );
+    return 1;
 }
 
 # }}}
diff --git a/etc/upgrade/upgrade-mysql-schema.pl b/etc/upgrade/upgrade-mysql-schema.pl
index 703b855..5ed45f9 100755
--- a/etc/upgrade/upgrade-mysql-schema.pl
+++ b/etc/upgrade/upgrade-mysql-schema.pl
@@ -293,6 +293,7 @@ sub convert_table {
         push @sql_commands, qq{ALTER TABLE $table\n   }.
             join(",\n   ",@{$alter_aggregator{$conversiontype}});
     }
+    return;
 }
 
 sub convert_column {
@@ -322,6 +323,7 @@ sub convert_column {
     } else {
         char_to_char( $required_charset, %info);
     }
+    return;
 }
 
 sub char_to_binary {
@@ -332,7 +334,7 @@ sub char_to_binary {
     my $new_type = calc_suitable_binary_type(%info);
     push @{$alter_aggregator{char_to_binary}},
         "MODIFY $column $new_type ".build_column_definition(%info);
-
+    return;
 }
 
 sub binary_to_char {
@@ -351,6 +353,7 @@ sub binary_to_char {
     push @{$alter_aggregator{binary_to_char}},
         "MODIFY $column ". uc($new_type) ." CHARACTER SET ". $charset
         ." ". build_column_definition(%info);
+    return;
 }
 
 sub char_to_char {
@@ -364,6 +367,7 @@ sub char_to_char {
     push @{$alter_aggregator{binary_to_char}},
         "MODIFY $column ". uc($new_type)." CHARACTER SET ". $charset
         ." ". build_column_definition(%info);
+    return;
 }
 
 sub calc_suitable_binary_type {

-----------------------------------------------------------------------