[Rt-commit] rt branch, 3.8/perlcritic, updated. rt-3.8.10-219-g6ed8c4a
Alex Vandiver
alexmv at bestpractical.com
Tue Aug 30 21:18:04 EDT 2011
The branch, 3.8/perlcritic has been updated
via 6ed8c4aa2310ac4a6813490bc807ce0e83024875 (commit)
via 2686c100b216390fb0913077e1cf72c1c0b56264 (commit)
from d50b9156360fecf2ede8314fde193a2064a45f14 (commit)
Summary of changes:
.../AnyTransaction.pm => Dashboard/MockRequest.pm} | 21 +++-----
lib/RT/Shredder/POD.pm | 55 +-------------------
lib/RT/Shredder/{POD.pm => POD/HTML.pm} | 38 +-------------
sbin/rt-email-dashboards.in | 13 +----
4 files changed, 13 insertions(+), 114 deletions(-)
copy lib/RT/{Condition/AnyTransaction.pm => Dashboard/MockRequest.pm} (89%)
mode change 100755 => 100644
copy lib/RT/Shredder/{POD.pm => POD/HTML.pm} (78%)
- Log -----------------------------------------------------------------
commit 2686c100b216390fb0913077e1cf72c1c0b56264
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Aug 30 19:58:46 2011 -0400
Split RT::Shredder::POD::HTML into its own file
diff --git a/lib/RT/Shredder/POD.pm b/lib/RT/Shredder/POD.pm
index 3c1787c..fbc5b50 100644
--- a/lib/RT/Shredder/POD.pm
+++ b/lib/RT/Shredder/POD.pm
@@ -50,7 +50,8 @@ package RT::Shredder::POD;
use strict;
use warnings;
-use Pod::Select;
+use Pod::PlainText;
+use RT::Shredder::POD::HTML;
sub plugin_html
{
@@ -64,7 +65,6 @@ sub plugin_html
sub plugin_cli
{
my ($file, $out_fh, $no_name) = @_;
- use Pod::PlainText;
local @Pod::PlainText::ISA = ('Pod::Select', @Pod::PlainText::ISA);
my $parser = Pod::PlainText->new;
$parser->select('SYNOPSIS', 'ARGUMENTS', 'USAGE');
@@ -76,7 +76,6 @@ sub plugin_cli
sub shredder_cli
{
my ($file, $out_fh) = @_;
- use Pod::PlainText;
local @Pod::PlainText::ISA = ('Pod::Select', @Pod::PlainText::ISA);
my $parser = Pod::PlainText->new;
$parser->select('NAME', 'SYNOPSIS', 'USAGE', 'OPTIONS');
@@ -84,54 +83,4 @@ sub shredder_cli
return;
}
-package RT::Shredder::POD::HTML;
-use base qw(Pod::Select);
-
-sub command
-{
- my( $self, $command, $paragraph, $line_num ) = @_;
-
- my $tag;
- if ($command =~ /^head(\d+)$/) { $tag = "h$1" }
- my $out_fh = $self->output_handle();
- my $expansion = $self->interpolate($paragraph, $line_num);
- $expansion =~ s/^\s+|\s+$//;
-
- print $out_fh "<$tag>" if $tag;
- print $out_fh $expansion;
- print $out_fh "</$tag>" if $tag;
- print $out_fh "\n";
- return;
-}
-
-sub verbatim
-{
- my ($self, $paragraph, $line_num) = @_;
- my $out_fh = $self->output_handle();
- print $out_fh "<pre>";
- print $out_fh $paragraph;
- print $out_fh "</pre>";
- print $out_fh "\n";
- return;
-}
-
-sub textblock {
- my ($self, $paragraph, $line_num) = @_;
- my $out_fh = $self->output_handle();
- my $expansion = $self->interpolate($paragraph, $line_num);
- $expansion =~ s/^\s+|\s+$//;
- print $out_fh "<p>";
- print $out_fh $expansion;
- print $out_fh "</p>";
- print $out_fh "\n";
- return;
-}
-
-sub interior_sequence {
- my ($self, $seq_command, $seq_argument) = @_;
- ## Expand an interior sequence; sample actions might be:
- return "<b>$seq_argument</b>" if $seq_command eq 'B';
- return "<i>$seq_argument</i>" if $seq_command eq 'I';
- return "<span class=\"pod-sequence-$seq_command\">$seq_argument</span>";
-}
1;
diff --git a/lib/RT/Shredder/POD.pm b/lib/RT/Shredder/POD/HTML.pm
similarity index 78%
copy from lib/RT/Shredder/POD.pm
copy to lib/RT/Shredder/POD/HTML.pm
index 3c1787c..0681524 100644
--- a/lib/RT/Shredder/POD.pm
+++ b/lib/RT/Shredder/POD/HTML.pm
@@ -46,45 +46,10 @@
#
# END BPS TAGGED BLOCK }}}
-package RT::Shredder::POD;
+package RT::Shredder::POD::HTML;
use strict;
use warnings;
-use Pod::Select;
-
-sub plugin_html
-{
- my ($file, $out_fh) = @_;
- my $parser = RT::Shredder::POD::HTML->new;
- $parser->select('ARGUMENTS', 'USAGE');
- $parser->parse_from_file( $file, $out_fh );
- return;
-}
-
-sub plugin_cli
-{
- my ($file, $out_fh, $no_name) = @_;
- use Pod::PlainText;
- local @Pod::PlainText::ISA = ('Pod::Select', @Pod::PlainText::ISA);
- my $parser = Pod::PlainText->new;
- $parser->select('SYNOPSIS', 'ARGUMENTS', 'USAGE');
- $parser->add_selection('NAME') unless $no_name;
- $parser->parse_from_file( $file, $out_fh );
- return;
-}
-
-sub shredder_cli
-{
- my ($file, $out_fh) = @_;
- use Pod::PlainText;
- local @Pod::PlainText::ISA = ('Pod::Select', @Pod::PlainText::ISA);
- my $parser = Pod::PlainText->new;
- $parser->select('NAME', 'SYNOPSIS', 'USAGE', 'OPTIONS');
- $parser->parse_from_file( $file, $out_fh );
- return;
-}
-
-package RT::Shredder::POD::HTML;
use base qw(Pod::Select);
sub command
@@ -134,4 +99,5 @@ sub interior_sequence {
return "<i>$seq_argument</i>" if $seq_command eq 'I';
return "<span class=\"pod-sequence-$seq_command\">$seq_argument</span>";
}
+
1;
commit 6ed8c4aa2310ac4a6813490bc807ce0e83024875
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Aug 30 20:26:45 2011 -0400
Split RT::Dashboard::FakeRequest out into its own file, rename to MockRequest
diff --git a/lib/RT/Dashboard/MockRequest.pm b/lib/RT/Dashboard/MockRequest.pm
new file mode 100644
index 0000000..5dcb712
--- /dev/null
+++ b/lib/RT/Dashboard/MockRequest.pm
@@ -0,0 +1,62 @@
+# BEGIN BPS TAGGED BLOCK {{{
+#
+# COPYRIGHT:
+#
+# This software is Copyright (c) 1996-2011 Best Practical Solutions, LLC
+# <sales at bestpractical.com>
+#
+# (Except where explicitly superseded by other copyright notices)
+#
+#
+# LICENSE:
+#
+# This work is made available to you under the terms of Version 2 of
+# the GNU General Public License. A copy of that license should have
+# been provided with this software, but in any event can be snarfed
+# from www.gnu.org.
+#
+# This work is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+# 02110-1301 or visit their web page on the internet at
+# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
+#
+#
+# CONTRIBUTION SUBMISSION POLICY:
+#
+# (The following paragraph is not intended to limit the rights granted
+# to you to modify and distribute this software under the terms of
+# the GNU General Public License and is only of importance to you if
+# you choose to contribute your changes and enhancements to the
+# community by submitting them to Best Practical Solutions, LLC.)
+#
+# By intentionally submitting any modifications, corrections or
+# derivatives to this work, or any other work intended for use with
+# Request Tracker, to Best Practical Solutions, LLC, you confirm that
+# you are the copyright holder for those contributions and you grant
+# Best Practical Solutions, LLC a nonexclusive, worldwide, irrevocable,
+# royalty-free, perpetual, license to use, copy, create derivative
+# works based on those contributions, and sublicense and distribute
+# those contributions and any derivatives thereof.
+#
+# END BPS TAGGED BLOCK }}}
+
+package RT::Dashboard::FakeRequest;
+use strict;
+use warnings;
+
+sub new { return bless {}, shift }
+sub header_out { return shift }
+sub headers_out { return shift }
+sub content_type {
+ my $self = shift;
+ $self->{content_type} = shift if @_;
+ return $self->{content_type};
+}
+
+1;
diff --git a/sbin/rt-email-dashboards.in b/sbin/rt-email-dashboards.in
index db21ed4..2edcf24 100644
--- a/sbin/rt-email-dashboards.in
+++ b/sbin/rt-email-dashboards.in
@@ -96,7 +96,8 @@ RT::Init();
require RT::Interface::Web;
require RT::Interface::Web::Handler;
require RT::Dashboard;
-$HTML::Mason::Commands::r = RT::Dashboard::FakeRequest->new;
+require RT::Dashboard::MockRequest;
+$HTML::Mason::Commands::r = RT::Dashboard::MockRequest->new;
# Read in the options
my %opts;
@@ -492,16 +493,6 @@ sub get_resource {
return ($content, $filename, $mimetype, $encoding);
}
-package RT::Dashboard::FakeRequest;
-sub new { return bless {}, shift }
-sub header_out { return shift }
-sub headers_out { return shift }
-sub content_type {
- my $self = shift;
- $self->{content_type} = shift if @_;
- return $self->{content_type};
-}
-
=head1 NAME
rt-email-dashboards - Send email dashboards
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list