[Rt-commit] rt branch, 4.0/dashboard-titles, updated. rt-4.0.4-109-g94d3e28

Thomas Sibley trs at bestpractical.com
Thu Dec 1 12:44:02 EST 2011


The branch, 4.0/dashboard-titles has been updated
       via  94d3e288c36d2b0400cba6c80b5fa47e38d84212 (commit)
      from  0d3ad45c2611344e2ade8927f88703b08646cb4f (commit)

Summary of changes:
 share/html/Dashboards/Render.html |    2 +-
 t/mail/dashboards.t               |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 94d3e288c36d2b0400cba6c80b5fa47e38d84212
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Thu Dec 1 12:39:54 2011 -0500

    Move the dashboard name to the beginning of the page title
    
    This makes the page titles much more useful when all you can see are the
    first few letters.  (Front-loading information)++

diff --git a/share/html/Dashboards/Render.html b/share/html/Dashboards/Render.html
index 73113d8..de90cca 100644
--- a/share/html/Dashboards/Render.html
+++ b/share/html/Dashboards/Render.html
@@ -116,7 +116,7 @@ unless (defined($rows)) {
     $rows = defined($prefs->{'RowsPerPage'}) ? $prefs->{'RowsPerPage'} : 50;
 }
 
-my $title = loc 'Dashboard [_1]', $Dashboard->Name;
+my $title = loc '[_1] Dashboard', $Dashboard->Name;
 
 my $show_cb = sub {
     my $pane = shift;
diff --git a/t/mail/dashboards.t b/t/mail/dashboards.t
index 3306708..7a7a54c 100644
--- a/t/mail/dashboards.t
+++ b/t/mail/dashboards.t
@@ -31,7 +31,7 @@ sub create_dashboard {
     $m->content_contains('Dashboard updated');
 
     $m->follow_link_ok({text => 'Show'});
-    $m->title_is('Dashboard Testing!');
+    $m->title_is('Testing! Dashboard');
     $m->content_contains('My dashboards');
     $m->content_like(qr{<a href="/Dashboards/\d+/Testing!">Testing!</a>});
 

-----------------------------------------------------------------------


More information about the Rt-commit mailing list