[Rt-commit] rt branch, 4.0-trunk, updated. rt-3.9.7-1190-g60198df

Kevin Falcone falcone at bestpractical.com
Tue Jan 18 18:24:45 EST 2011


The branch, 4.0-trunk has been updated
       via  60198df2a74e63eb51b4f6d691d5f56132cb4172 (commit)
       via  21e34468e5c07708ab9618158e9784960d9dba43 (commit)
       via  79955e1c11be91a8f81cab78a4ebfada99f30d2d (commit)
      from  7ed81c02d5c3217ece819c7a632c73329763dae0 (commit)

Summary of changes:
 docs/UPGRADING-4.0            |    8 ++++
 etc/constraints.mysql         |   85 -----------------------------------------
 share/html/NoAuth/Logout.html |    7 +++-
 3 files changed, 14 insertions(+), 86 deletions(-)
 delete mode 100755 etc/constraints.mysql
 delete mode 100644 share/html/Elements/Logout

- Log -----------------------------------------------------------------
commit 79955e1c11be91a8f81cab78a4ebfada99f30d2d
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Tue Jan 11 11:57:34 2011 -0500

    Document our sessions table upgrade on mysql

diff --git a/docs/UPGRADING-4.0 b/docs/UPGRADING-4.0
index 70cdf2e..b1cba9a 100644
--- a/docs/UPGRADING-4.0
+++ b/docs/UPGRADING-4.0
@@ -20,6 +20,14 @@ server configuration.  You need to review docs/web_deployment.pod for current
 instructions
 
 *******
+Upgrading sessions on MySQL
+
+In 4.0.0rc2, RT began shipping an updated schema for the sesions table
+that specificies a character set as well as making the table InnoDB.  As
+part of the upgrade process, your sessions table will be dropped and
+recreated with the new schema.
+
+*******
 UPGRADING FROM RT 3.8.x and RTFM 2.1 or greater
 
 RT4 now includes an Articles functionality, merged from RTFM.

commit 21e34468e5c07708ab9618158e9784960d9dba43
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Wed Jan 12 10:39:03 2011 -0500

    Remove old unused mysql sample constraints

diff --git a/etc/constraints.mysql b/etc/constraints.mysql
deleted file mode 100755
index 355d2c5..0000000
--- a/etc/constraints.mysql
+++ /dev/null
@@ -1,85 +0,0 @@
-
-  ALTER TABLE Links ADD INDEX(LocalBase);
-  ALTER TABLE Links ADD FOREIGN KEY (LocalBase) REFERENCES Tickets(id);
-  ALTER TABLE Links ADD INDEX(LocalTarget);
-  ALTER TABLE Links ADD FOREIGN KEY (LocalTarget) REFERENCES Tickets(id);
-  ALTER TABLE Tickets ADD INDEX(Queue);
-  ALTER TABLE Tickets ADD FOREIGN KEY (Queue) REFERENCES Queues(id);
-  ALTER TABLE Tickets ADD INDEX(EffectiveId);
-  ALTER TABLE Tickets ADD FOREIGN KEY (EffectiveId) REFERENCES Tickets(id);
-  ALTER TABLE Tickets ADD INDEX(Owner);
-  ALTER TABLE Tickets ADD FOREIGN KEY (Owner) REFERENCES Principals(id);
-  ALTER TABLE Tickets ADD INDEX(Creator);
-  ALTER TABLE Tickets ADD INDEX(LastUpdatedBy);
-  ALTER TABLE Tickets ADD FOREIGN KEY (Creator) REFERENCES Users(id);
-  ALTER TABLE Tickets ADD FOREIGN KEY (LastUpdatedBy) REFERENCES Users(id);
-  ALTER TABLE Transactions ADD INDEX(Creator);
-  ALTER TABLE Transactions ADD INDEX (Ticket) ;
-  ALTER TABLE Transactions ADD INDEX (EffectiveTicket) ;
-  ALTER TABLE Transactions ADD FOREIGN KEY (Creator) REFERENCES Users(id);
-  ALTER TABLE Transactions ADD FOREIGN KEY (Ticket) REFERENCES Tickets(id);
-  ALTER TABLE Transactions ADD FOREIGN KEY (EffectiveTicket) REFERENCES Tickets(id);
-  ALTER TABLE Attachments ADD INDEX (TransactionId) ;
-  ALTER TABLE Attachments ADD INDEX (Parent) ;
-  ALTER TABLE Attachments ADD FOREIGN KEY (TransactionId) REFERENCES Transactions(id);
-  ALTER TABLE Attachments ADD FOREIGN KEY (Parent) REFERENCES Attachments(id);
-  ALTER TABLE Scrips ADD INDEX (ScripCondition) ;
-  ALTER TABLE Scrips ADD INDEX (ScripAction) ;
-  ALTER TABLE Scrips ADD INDEX (Template) ;
-  ALTER TABLE Scrips ADD INDEX (Queue) ;
-  ALTER TABLE Scrips ADD INDEX (Creator) ;
-  ALTER TABLE Scrips ADD INDEX (LastUpdatedBy) ;
-  ALTER TABLE Scrips ADD FOREIGN KEY (ScripCondition) REFERENCES ScripConditions(id);
-  ALTER TABLE Scrips ADD FOREIGN KEY (ScripAction) REFERENCES ScripActions(id);
-  ALTER TABLE Scrips ADD FOREIGN KEY (Template) REFERENCES Templates(id);
-  ALTER TABLE Scrips ADD FOREIGN KEY (Queue) REFERENCES Queues(id);
-  ALTER TABLE Scrips ADD FOREIGN KEY (Creator) REFERENCES Users(id);
-  ALTER TABLE Scrips ADD FOREIGN KEY (LastUpdatedBy) REFERENCES Users(id);
-  ALTER TABLE ACL ADD INDEX (PrincipalId) ;
-  ALTER TABLE ACL ADD INDEX (DelegatedBy) ;
-  ALTER TABLE ACL ADD INDEX (DelegatedFrom) ;
-  ALTER TABLE ACL ADD FOREIGN KEY (PrincipalId) REFERENCES Principals(id);
-  ALTER TABLE ACL ADD FOREIGN KEY (DelegatedBy) REFERENCES Principals(id);
-  ALTER TABLE ACL ADD FOREIGN KEY (DelegatedFrom) REFERENCES ACL(id);
-  ALTER TABLE GroupMembers ADD INDEX (MemberId); 
-  ALTER TABLE GroupMembers ADD INDEX (GroupId); 
-  ALTER TABLE GroupMembers ADD FOREIGN KEY (GroupId) REFERENCES Groups(id);
-  ALTER TABLE GroupMembers ADD FOREIGN KEY (MemberId) REFERENCES Principals(id);
-  ALTER TABLE CachedGroupMembers ADD INDEX (ImmediateParentId) ;
-  ALTER TABLE CachedGroupMembers ADD INDEX (GroupId) ;
-  ALTER TABLE CachedGroupMembers ADD INDEX (MemberId) ;
-  ALTER TABLE CachedGroupMembers ADD INDEX (Via) ;
-  ALTER TABLE CachedGroupMembers ADD FOREIGN KEY (ImmediateParentId) REFERENCES Principals(id);
-  ALTER TABLE CachedGroupMembers ADD FOREIGN KEY (GroupId) REFERENCES Principals(id);
-  ALTER TABLE CachedGroupMembers ADD FOREIGN KEY (MemberId) REFERENCES Principals(id);
-  ALTER TABLE CachedGroupMembers ADD FOREIGN KEY (Via) REFERENCES CachedGroupMembers(id);
-  ALTER TABLE ScripActions ADD INDEX(Creator);
-  ALTER TABLE ScripActions ADD INDEX(LastUpdatedBy);
-  ALTER TABLE ScripActions ADD FOREIGN KEY (Creator) REFERENCES Users(id);
-  ALTER TABLE ScripActions ADD FOREIGN KEY (LastUpdatedBy) REFERENCES Users(id);
-  ALTER TABLE Templates ADD INDEX(Queue);
-  ALTER TABLE Templates ADD INDEX(Creator);
-  ALTER TABLE Templates ADD INDEX(LastUpdatedBy);
-  ALTER TABLE Templates ADD FOREIGN KEY (Queue) REFERENCES Queues(id);
-  ALTER TABLE Templates ADD FOREIGN KEY (Creator) REFERENCES Users(id);
-  ALTER TABLE Templates ADD FOREIGN KEY (LastUpdatedBy) REFERENCES Users(id);
-  ALTER TABLE CustomFields ADD INDEX(Queue);
-  ALTER TABLE CustomFields ADD INDEX(Creator);
-  ALTER TABLE CustomFields ADD INDEX(LastUpdatedBy);
-  ALTER TABLE CustomFields ADD FOREIGN KEY (Queue) REFERENCES Queues(id);
-  ALTER TABLE CustomFields ADD FOREIGN KEY (Creator) REFERENCES Users(id);
-  ALTER TABLE CustomFields ADD FOREIGN KEY (LastUpdatedBy) REFERENCES Users(id);
-  ALTER TABLE TicketCustomFieldValues ADD INDEX(Ticket);
-  ALTER TABLE TicketCustomFieldValues ADD INDEX(CustomField);
-  ALTER TABLE TicketCustomFieldValues ADD INDEX(Creator);
-  ALTER TABLE TicketCustomFieldValues ADD INDEX(LastUpdatedBy);
-  ALTER TABLE TicketCustomFieldValues ADD FOREIGN KEY (Ticket) REFERENCES Tickets(id);
-  ALTER TABLE TicketCustomFieldValues ADD FOREIGN KEY (CustomField) REFERENCES CustomFields(id);
-  ALTER TABLE TicketCustomFieldValues ADD FOREIGN KEY (Creator) REFERENCES Users(id);
-  ALTER TABLE TicketCustomFieldValues ADD FOREIGN KEY (LastUpdatedBy) REFERENCES Users(id);
-  ALTER TABLE CustomFieldValues ADD INDEX(CustomField);
-  ALTER TABLE CustomFieldValues ADD INDEX(Creator);
-  ALTER TABLE CustomFieldValues ADD INDEX(LastUpdatedBy);
-  ALTER TABLE CustomFieldValues ADD FOREIGN KEY (CustomField) REFERENCES CustomFields(id);
-  ALTER TABLE CustomFieldValues ADD FOREIGN KEY (Creator) REFERENCES Users(id);
-  ALTER TABLE CustomFieldValues ADD FOREIGN KEY (LastUpdatedBy) REFERENCES Users(id);

commit 60198df2a74e63eb51b4f6d691d5f56132cb4172
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Jan 7 11:26:40 2011 -0500

    Rearrange callbacks to provide a means for sending the user to a URL on Logout
    
    ce8a0fc98d2a69246fb7cf30e1763afe9d1cdace removed the URL parameter to
    /NoAuth/Logout.html that Elements/Logout's callback relied upon.  Moving
    the callback to /NoAuth/Logout.html means that there's an easy place to
    override the URL redirected to.  Users don't lose session deletion
    like they do when they naively override Elements/Logout instead.
    
    See also #16403.
    
    Cherrypick of the relevant parts of 2ba267bd4f9dbca142e5fd4f20eb4e0a706ed3f9
    applied (share/html/Elements/Logout no longer exists so the cleanup
    there has been dropped).

diff --git a/share/html/Elements/Logout b/share/html/Elements/Logout
deleted file mode 100644
index e69de29..0000000
diff --git a/share/html/NoAuth/Logout.html b/share/html/NoAuth/Logout.html
index 81a5978..e334d60 100755
--- a/share/html/NoAuth/Logout.html
+++ b/share/html/NoAuth/Logout.html
@@ -56,7 +56,7 @@
 
 <br />
 <br />
-<a href="<%$URL%>"><&|/l&>You're welcome to login again</&></a>.
+<a href="<% RT->Config->Get('WebPath') %>/"><&|/l&>You're welcome to login again</&></a>.
 </&>
 
 % $m->callback( %ARGS );
@@ -68,6 +68,11 @@
 
 <%INIT>
 my $URL = RT->Config->Get('WebPath')."/";
+
+# Allow a callback to modify the URL we redirect to, which is useful for
+# external webauth systems
+$m->callback( %ARGS, URL => \$URL );
+
 $m->callback( %ARGS, CallbackName => 'BeforeSessionDelete' );
 
 if (keys %session) {

-----------------------------------------------------------------------


More information about the Rt-commit mailing list