[Rt-commit] rt branch, 4.0/test-race-conditions, updated. rt-4.0.0rc4-27-gb151804

Ruslan Zakirov ruz at bestpractical.com
Mon Jan 31 07:24:38 EST 2011


The branch, 4.0/test-race-conditions has been updated
       via  b151804a474a0b88f28cf551f3934cf6a3238f75 (commit)
      from  6d51aa7291506ef1c2796348d0157f4ba45b6dcc (commit)

Summary of changes:
 lib/RT/Test.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit b151804a474a0b88f28cf551f3934cf6a3238f75
Author: Ruslan Zakirov <ruz at bestpractical.com>
Date:   Mon Jan 31 15:23:12 2011 +0300

    localizing sighandler wouldn't do harm, %SIG stays clean

diff --git a/lib/RT/Test.pm b/lib/RT/Test.pm
index 1e4ca7c..5c81228 100644
--- a/lib/RT/Test.pm
+++ b/lib/RT/Test.pm
@@ -1212,7 +1212,7 @@ sub start_plack_server {
     # to listen.  We set this up _before_ we fork to avoid race
     # conditions.
     my $handled;
-    $SIG{USR1} = sub { $handled = 1};
+    local $SIG{USR1} = sub { $handled = 1};
 
     my $pid = fork();
     die "failed to fork" unless defined $pid;

-----------------------------------------------------------------------


More information about the Rt-commit mailing list