[Rt-commit] rtir branch, 2.6/perlcritic, updated. 2.6.0-30-g95f8acb
Alex Vandiver
alexmv at bestpractical.com
Tue Jul 5 13:59:42 EDT 2011
The branch, 2.6/perlcritic has been updated
via 95f8acbb168afa67999c1f4dd3229a43e43aaa5b (commit)
from befbbdd1ddc55a8ef361f1747b1487d9ce099c86 (commit)
Summary of changes:
etc/upgrade/upgrade.pl | 2 +-
.../RTIR/Elements/RT__Ticket/ColumnMap/Once | 2 +-
html/RTIR/Create.html | 2 +-
html/RTIR/Display.html | 4 ++--
html/RTIR/Elements/AddWatchers | 2 +-
html/RTIR/Elements/ShowIncidents | 4 ++--
html/RTIR/Incident/BulkAbandon.html | 4 ++--
html/RTIR/Incident/Display.html | 2 +-
html/RTIR/Report/BulkReject.html | 2 +-
html/RTIR/Reporting/Report.html | 6 +++---
html/RTIR/Reporting/index.html | 8 ++++----
html/RTIR/Split.html | 2 +-
html/RTIR/Tools/ScriptedAction.html | 8 ++++----
html/RTIR/index.html | 2 +-
lib/RT/Action/RTIR.pm | 2 +-
lib/RT/Action/RTIR_ChangeChildOwnership.pm | 2 +-
lib/RT/Action/RTIR_ChangeParentOwnership.pm | 2 +-
lib/RT/Action/RTIR_OpenParent.pm | 2 +-
lib/RT/Action/RTIR_ResolveChildren.pm | 2 +-
lib/RT/Action/RTIR_SetDueIncident.pm | 6 +++---
lib/RT/IR.pm | 2 +-
lib/RT/IR/Test.pm | 2 +-
lib/RT/IR/Ticket.pm | 2 +-
t/000-mason-syntax.t | 2 +-
24 files changed, 37 insertions(+), 37 deletions(-)
- Log -----------------------------------------------------------------
commit 95f8acbb168afa67999c1f4dd3229a43e43aaa5b
Author: Alex Vandiver <alexmv at bestpractical.com>
Date: Tue Jul 5 13:59:34 2011 -0400
Remove indirect object notation
diff --git a/etc/upgrade/upgrade.pl b/etc/upgrade/upgrade.pl
index 6937847..2cee638 100644
--- a/etc/upgrade/upgrade.pl
+++ b/etc/upgrade/upgrade.pl
@@ -44,7 +44,7 @@ print "Base query for children: $base_query\n\n";
my $children = RT::Tickets->new( $current_user );
require File::Temp;
-my $tmp = new File::Temp; # croak on error
+my $tmp = File::Temp->new; # croak on error
FetchNext( $incidents, 1 );
while ( my $inc = FetchNext( $incidents ) ) {
diff --git a/html/Callbacks/RTIR/Elements/RT__Ticket/ColumnMap/Once b/html/Callbacks/RTIR/Elements/RT__Ticket/ColumnMap/Once
index b1912af..89abfa2 100644
--- a/html/Callbacks/RTIR/Elements/RT__Ticket/ColumnMap/Once
+++ b/html/Callbacks/RTIR/Elements/RT__Ticket/ColumnMap/Once
@@ -31,7 +31,7 @@ $COLUMN_MAP->{'HasIncident'} = {
my $yesno;
my $query = "Queue = 'Incidents' AND HasMember = " . $t->Id . " AND CF.{State} != 'rejected'";
- my $incidents = new RT::Tickets($session{'CurrentUser'});
+ my $incidents = RT::Tickets->new($session{'CurrentUser'});
$incidents->FromSQL($query);
if ($incidents->Count > 0) {
diff --git a/html/RTIR/Create.html b/html/RTIR/Create.html
index 4094f3f..a19b027 100644
--- a/html/RTIR/Create.html
+++ b/html/RTIR/Create.html
@@ -257,7 +257,7 @@ $m->callback(
ARGSRef => \%ARGS,
);
-my $QueueObj = new RT::Queue( $session{'CurrentUser'} );
+my $QueueObj = RT::Queue->new( $session{'CurrentUser'} );
$QueueObj->Load( $Queue ) || Abort( loc("Queue could not be loaded.") );
diff --git a/html/RTIR/Display.html b/html/RTIR/Display.html
index 49ab129..d9b2831 100644
--- a/html/RTIR/Display.html
+++ b/html/RTIR/Display.html
@@ -126,7 +126,7 @@
&>
<%INIT>
my ($name);
-my $Ticket = new RT::Ticket( $session{'CurrentUser'} );
+my $Ticket = RT::Ticket->new( $session{'CurrentUser'} );
my $QueueObj;
unless ( $id eq 'new' ) {
@@ -136,7 +136,7 @@ unless ( $id eq 'new' ) {
}
$QueueObj = $Ticket->QueueObj;
} else {
- $QueueObj = new RT::Queue( $session{'CurrentUser'} );
+ $QueueObj = RT::Queue->new( $session{'CurrentUser'} );
$QueueObj->Load($Queue) || Abort(loc("Queue could not be loaded."));
}
diff --git a/html/RTIR/Elements/AddWatchers b/html/RTIR/Elements/AddWatchers
index b6389a5..b33efd5 100644
--- a/html/RTIR/Elements/AddWatchers
+++ b/html/RTIR/Elements/AddWatchers
@@ -67,7 +67,7 @@ if ( $UserString ) {
);
}
-$Groups = new RT::Groups( $session{'CurrentUser'} );
+$Groups = RT::Groups->new( $session{'CurrentUser'} );
$Groups->LimitToUserDefinedGroups;
</%INIT>
diff --git a/html/RTIR/Elements/ShowIncidents b/html/RTIR/Elements/ShowIncidents
index a67ad36..7d3aa76 100644
--- a/html/RTIR/Elements/ShowIncidents
+++ b/html/RTIR/Elements/ShowIncidents
@@ -55,7 +55,7 @@
my $count = 0;
my $query = "Queue = 'Incidents' AND HasMember = " . $Ticket->Id . " AND CF.{State} != 'rejected'";
-my $incidents = new RT::Tickets($session{'CurrentUser'});
+my $incidents = RT::Tickets->new($session{'CurrentUser'});
$incidents->FromSQL($query);
my $action = '';
@@ -77,7 +77,7 @@ if ( $Ticket->Owner != $session{'CurrentUser'}->Id ) {
my $show_unlink = !$action;
if ( $show_unlink && $Ticket->QueueObj->Name eq 'Blocks' ) {
my $query = "Queue = 'Incidents' AND HasMember = " . $Ticket->Id;
- my $incidents = new RT::Tickets( $session{'CurrentUser'} );
+ my $incidents = RT::Tickets->new( $session{'CurrentUser'} );
$incidents->FromSQL( $query );
$show_unlink = 0 unless $incidents->Count > 1;
}
diff --git a/html/RTIR/Incident/BulkAbandon.html b/html/RTIR/Incident/BulkAbandon.html
index 71edf36..7dc79a9 100644
--- a/html/RTIR/Incident/BulkAbandon.html
+++ b/html/RTIR/Incident/BulkAbandon.html
@@ -115,7 +115,7 @@ if ( $ARGS{'BulkAbandon'} ) {
# XXX: why do we limit to open?
my $query = "CF.{State} = 'open' AND MemberOf = $id";
$query .= " AND (". join(' OR ', map "Queue = '$_'", @ReplyToAll) .")";
- my $members = new RT::Tickets( $t->CurrentUser );
+ my $members = RT::Tickets->new( $t->CurrentUser );
$members->FromSQL( $query );
while( my $member = $members->Next ) {
$ARGS{'UpdateAttachments'} = delete $session{'Attachments'} if $session{'Attachments'};
@@ -130,7 +130,7 @@ if ( $ARGS{'BulkAbandon'} ) {
." AND ( ". join(" OR ", map "Status = '$_'", RT->Config->Get('ActiveStatus') ) ." )"
." AND ( Queue = 'Incident Reports' OR Queue = 'Blocks' OR Queue = 'Investigations' )";
- my $members = new RT::Tickets( $t->CurrentUser );
+ my $members = RT::Tickets->new( $t->CurrentUser );
$members->FromSQL( $query );
while( my $member = $members->Next ) {
next if RT::IR::Ticket::IsLinkedToActiveIncidents( $member, $t );
diff --git a/html/RTIR/Incident/Display.html b/html/RTIR/Incident/Display.html
index c1ef72c..438af3c 100644
--- a/html/RTIR/Incident/Display.html
+++ b/html/RTIR/Incident/Display.html
@@ -294,7 +294,7 @@ if ( defined $TicketObj->TimeLeft && $TicketObj->TimeLeft > 0 ) {
# If we deleted any links, check if what we deleted from still has children
if ( $deleted_links ) {
# XXX: Can we ever get here?
- my $children = new RT::Tickets( $session{'CurrentUser'} );
+ my $children = RT::Tickets->new( $session{'CurrentUser'} );
$children->LimitQueue( VALUE => 'Incident Reports' );
$children->LimitQueue( VALUE => 'Investigations' );
$children->LimitQueue( VALUE => 'Blocks' );
diff --git a/html/RTIR/Report/BulkReject.html b/html/RTIR/Report/BulkReject.html
index 707a421..94e53dc 100644
--- a/html/RTIR/Report/BulkReject.html
+++ b/html/RTIR/Report/BulkReject.html
@@ -106,7 +106,7 @@ if ( $BulkReject ) {
# warn if this IR has any incidents
my $query = "Queue = 'Incidents' AND HasMember = " . $t->Id . " AND CF.{State} != 'rejected'";
- my $incidents = new RT::Tickets($session{'CurrentUser'});
+ my $incidents = RT::Tickets->new($session{'CurrentUser'});
$incidents->FromSQL($query);
if ($incidents->Count > 0) {
push( @tempresults, [ $id, loc("Warning: already has incident") ] );
diff --git a/html/RTIR/Reporting/Report.html b/html/RTIR/Reporting/Report.html
index 411fcfd..67e3212 100644
--- a/html/RTIR/Reporting/Report.html
+++ b/html/RTIR/Reporting/Report.html
@@ -122,7 +122,7 @@ my $get_incident_field = sub {
# find the parent incident
my $query = "Queue = 'Incidents' AND HasMember = ". $t->Id;
- my $incidents = new RT::Tickets( $session{'CurrentUser'} );
+ my $incidents = RT::Tickets->new( $session{'CurrentUser'} );
$incidents->FromSQL( $query );
my $parent = $incidents->First;
@@ -153,9 +153,9 @@ $ReportAs = 'TSV' if $SpreadsheetReport;
my $start = ParseDateToISO( $StartDate );
my $end = ParseDateToISO( $EndDate );
-my $rtstart = new RT::Date( $session{'CurrentUser'} );
+my $rtstart = RT::Date->new( $session{'CurrentUser'} );
$rtstart->Set( Format => 'ISO', Value => $start );
-my $rtend = new RT::Date( $session{'CurrentUser'} );
+my $rtend = RT::Date->new( $session{'CurrentUser'} );
$rtend->Set( Format => 'ISO', Value => $end );
# of new reports created during the period broken down by function
diff --git a/html/RTIR/Reporting/index.html b/html/RTIR/Reporting/index.html
index 89d5055..70540ea 100644
--- a/html/RTIR/Reporting/index.html
+++ b/html/RTIR/Reporting/index.html
@@ -87,14 +87,14 @@ if ( $ARGS{'HTMLReport'} || $ARGS{'TextReport'} || $ARGS{'SpreadsheetReport'} )
$m->redirect($url);
}
-my $QueueObj = new RT::Queue($session{'CurrentUser'});
+my $QueueObj = RT::Queue->new($session{'CurrentUser'});
$QueueObj->Load('Incidents');
-my $now = new RT::Date($RT::SystemUser);
+my $now = RT::Date->new($RT::SystemUser);
$now->SetToNow();
-my $end = new RT::Date($RT::SystemUser);
+my $end = RT::Date->new($RT::SystemUser);
$end->SetToNow();
-my $start = new RT::Date($RT::SystemUser);
+my $start = RT::Date->new($RT::SystemUser);
$start->SetToNow();
$start->AddDays(0-30);
diff --git a/html/RTIR/Split.html b/html/RTIR/Split.html
index f5d05af..3570176 100644
--- a/html/RTIR/Split.html
+++ b/html/RTIR/Split.html
@@ -54,7 +54,7 @@ if ( $m->comp_exists("/RTIR/$Type/Split.html") ) {
}
my $query = "Queue = 'Incidents' AND HasMember = " . $TicketObj->Id;
-my $incidents = new RT::Tickets( $session{'CurrentUser'} );
+my $incidents = RT::Tickets->new( $session{'CurrentUser'} );
$incidents->FromSQL( $query );
my $Incident;
diff --git a/html/RTIR/Tools/ScriptedAction.html b/html/RTIR/Tools/ScriptedAction.html
index 2e702cd..8ac3e19 100644
--- a/html/RTIR/Tools/ScriptedAction.html
+++ b/html/RTIR/Tools/ScriptedAction.html
@@ -206,7 +206,7 @@ foreach my $arg (keys %ARGS) {
}
if ($incidentid) {
- $Incident = new RT::Ticket($session{'CurrentUser'});
+ $Incident = RT::Ticket->new($session{'CurrentUser'});
$Incident->Load($incidentid);
if (!exists $ARGS{Content}) {
@@ -242,19 +242,19 @@ unless ( $server ) {
}
# Load the Incidents Queue
-my $incidentq = new RT::Queue($session{'CurrentUser'});
+my $incidentq = RT::Queue->new($session{'CurrentUser'});
unless ( $incidentq->Load('Incidents') ) {
Abort('Queue not found');
}
# Load the Investigations Queue
-my $investigationq = new RT::Queue($session{'CurrentUser'});
+my $investigationq = RT::Queue->new($session{'CurrentUser'});
unless ($investigationq->Load('Investigations')) {
Abort('Queue not found');
}
# Load the Incident Reports Queue
-my $reportq = new RT::Queue($session{'CurrentUser'});
+my $reportq = RT::Queue->new($session{'CurrentUser'});
unless ($reportq->Load('Incident Reports')) {
Abort('Queue not found');
}
diff --git a/html/RTIR/index.html b/html/RTIR/index.html
index b1c58c9..c11ca0a 100644
--- a/html/RTIR/index.html
+++ b/html/RTIR/index.html
@@ -55,7 +55,7 @@ if ( $ARGS{'q'} ) {
# Incidents don't have requestors, but children do
if ( $query =~ m/\@/ ) {
- my $children = new RT::Tickets($session{'CurrentUser'});
+ my $children = RT::Tickets->new($session{'CurrentUser'});
$children->FromSQL( "( Queue = 'Incident Reports' OR
Queue = 'Investigations' OR
Queue = 'Blocks'
diff --git a/lib/RT/Action/RTIR.pm b/lib/RT/Action/RTIR.pm
index 58bd3a0..0f6a976 100644
--- a/lib/RT/Action/RTIR.pm
+++ b/lib/RT/Action/RTIR.pm
@@ -8,7 +8,7 @@ use base 'RT::Action::Generic';
sub CreatorCurrentUser {
my $self = shift;
- my $user = new RT::CurrentUser($self->TransactionObj->CurrentUser);
+ my $user = RT::CurrentUser->new($self->TransactionObj->CurrentUser);
$user->Load($self->TransactionObj->Creator);
return $user;
}
diff --git a/lib/RT/Action/RTIR_ChangeChildOwnership.pm b/lib/RT/Action/RTIR_ChangeChildOwnership.pm
index c5eea04..3cdd534 100644
--- a/lib/RT/Action/RTIR_ChangeChildOwnership.pm
+++ b/lib/RT/Action/RTIR_ChangeChildOwnership.pm
@@ -91,7 +91,7 @@ sub Commit {
." OR Queue = 'Blocks'"
.") AND MemberOf = ". $self->TicketObj->Id
." AND Owner != ". $transaction->NewValue;
- my $members = new RT::Tickets( $actor );
+ my $members = RT::Tickets->new( $actor );
$members->FromSQL( $query );
while ( my $member = $members->Next ) {
diff --git a/lib/RT/Action/RTIR_ChangeParentOwnership.pm b/lib/RT/Action/RTIR_ChangeParentOwnership.pm
index f47691a..7fd0fac 100644
--- a/lib/RT/Action/RTIR_ChangeParentOwnership.pm
+++ b/lib/RT/Action/RTIR_ChangeParentOwnership.pm
@@ -76,7 +76,7 @@ sub Commit {
my $query = "Queue = 'Incidents'"
." AND HasMember = " . $self->TicketObj->Id
." AND Owner != ". $self->TransactionObj->NewValue;
- my $parents = new RT::Tickets( $self->CreatorCurrentUser );
+ my $parents = RT::Tickets->new( $self->CreatorCurrentUser );
$parents->FromSQL($query);
while ( my $incident = $parents->Next ) {
diff --git a/lib/RT/Action/RTIR_OpenParent.pm b/lib/RT/Action/RTIR_OpenParent.pm
index dddfe05..78d2e29 100644
--- a/lib/RT/Action/RTIR_OpenParent.pm
+++ b/lib/RT/Action/RTIR_OpenParent.pm
@@ -83,7 +83,7 @@ sub Commit {
." AND HasMember = " . $self->TicketObj->Id
." AND (Status = 'rejected' OR Status = 'resolved')";
- my $parents = new RT::Tickets($self->TransactionObj->CurrentUser);
+ my $parents = RT::Tickets->new($self->TransactionObj->CurrentUser);
$parents->FromSQL($query);
while (my $member = $parents->Next) {
my ($res, $msg) = $member->Open;
diff --git a/lib/RT/Action/RTIR_ResolveChildren.pm b/lib/RT/Action/RTIR_ResolveChildren.pm
index ada2064..203facb 100644
--- a/lib/RT/Action/RTIR_ResolveChildren.pm
+++ b/lib/RT/Action/RTIR_ResolveChildren.pm
@@ -87,7 +87,7 @@ sub Commit {
. join(" AND ", map "Status != '$_'", RT->Config->Get('InactiveStatus') )
.")";
- my $members = new RT::Tickets( $self->TransactionObj->CurrentUser );
+ my $members = RT::Tickets->new( $self->TransactionObj->CurrentUser );
$members->FromSQL( $query );
while ( my $member = $members->Next ) {
if ( RT::IR::Ticket::IsLinkedToActiveIncidents( $member, $self->TicketObj ) ) {
diff --git a/lib/RT/Action/RTIR_SetDueIncident.pm b/lib/RT/Action/RTIR_SetDueIncident.pm
index 1208ae3..fc0426b 100644
--- a/lib/RT/Action/RTIR_SetDueIncident.pm
+++ b/lib/RT/Action/RTIR_SetDueIncident.pm
@@ -77,12 +77,12 @@ sub Commit {
my $type = $self->TransactionObj->Type;
if ( $type eq 'DeleteLink' ) {
- my $uri = new RT::URI( $self->CurrentUser );
+ my $uri = RT::URI->new( $self->CurrentUser );
$uri->FromURI( $self->TransactionObj->OldValue );
return $self->UpdateDue( $uri->Object );
}
- my $incidents = new RT::Tickets( $self->CurrentUser );
+ my $incidents = RT::Tickets->new( $self->CurrentUser );
$incidents->FromSQL( "Queue = 'Incidents' AND HasMember = " . $self->TicketObj->id );
while ( my $incident = $incidents->Next ) {
$self->UpdateDue( $incident );
@@ -104,7 +104,7 @@ sub UpdateDue {
." AND ("
. join( " OR ", map "Status = '$_'", RT->Config->Get('ActiveStatus') )
.")";
- my $children = new RT::Tickets($self->CurrentUser);
+ my $children = RT::Tickets->new($self->CurrentUser);
$children->FromSQL( $query );
$children->OrderBy( FIELD => 'Due', ORDER => 'ASC' );
$children->RowsPerPage(1);
diff --git a/lib/RT/IR.pm b/lib/RT/IR.pm
index 0328486..aa3b4e1 100644
--- a/lib/RT/IR.pm
+++ b/lib/RT/IR.pm
@@ -92,7 +92,7 @@ the config file. See option 'BusinessHours'.
=cut
sub BusinessHours {
- my $bizhours = new Business::Hours;
+ my $bizhours = Business::Hours->new;
if ( RT->Config->Get('BusinessHours') ) {
$bizhours->business_hours( %{ RT->Config->Get('BusinessHours') } );
}
diff --git a/lib/RT/IR/Test.pm b/lib/RT/IR/Test.pm
index 3a93ef8..82ad2be 100644
--- a/lib/RT/IR/Test.pm
+++ b/lib/RT/IR/Test.pm
@@ -50,7 +50,7 @@ our $RTIR_TEST_USER = "rtir_test_user";
our $RTIR_TEST_PASS = "rtir_test_pass";
sub default_agent {
- my $agent = new RT::IR::Test::Web;
+ my $agent = RT::IR::Test::Web->new;
require HTTP::Cookies;
$agent->cookie_jar( HTTP::Cookies->new );
rtir_user();
diff --git a/lib/RT/IR/Ticket.pm b/lib/RT/IR/Ticket.pm
index 693e6e6..6f6210e 100644
--- a/lib/RT/IR/Ticket.pm
+++ b/lib/RT/IR/Ticket.pm
@@ -45,7 +45,7 @@ sub IsLinkedToActiveIncidents {
$query .= " AND id != ". $parent->Id if $parent;
- my $tickets = new RT::Tickets( $child->CurrentUser );
+ my $tickets = RT::Tickets->new( $child->CurrentUser );
$tickets->FromSQL( $query );
return $tickets->Count;
}
diff --git a/t/000-mason-syntax.t b/t/000-mason-syntax.t
index d235636..a3849f6 100644
--- a/t/000-mason-syntax.t
+++ b/t/000-mason-syntax.t
@@ -33,7 +33,7 @@ sub compile_file {
my $text = do { local $/; <$fh> };
close $fh or die "couldn't close '$file': $!";
- my $compiler = new HTML::Mason::Compiler::ToObject;
+ my $compiler = HTML::Mason::Compiler::ToObject->new;
$compiler->compile(
comp_source => $text,
name => 'my',
-----------------------------------------------------------------------
More information about the Rt-commit
mailing list