[Rt-commit] rtfm branch, 2.4/perlcritic, updated. 2.4.3-12-g5bbc6d9

[Alex Vandiver]

The branch, 2.4/perlcritic has been updated
       via  5bbc6d9f62748bdc20391f1e6094e06dc4d97307 (commit)
      from  617fd323283f90dc76301d1140f87df12627cd1c (commit)

Summary of changes:
 lib/RT/FM/Article.pm               |    2 +-
 lib/RT/FM/ArticleCollection.pm     |    2 +-
 lib/RT/FM/Class.pm                 |    2 +-
 lib/RT/FM/ClassCollection.pm       |    2 +-
 lib/RT/FM/ObjectTopic.pm           |    2 +-
 lib/RT/FM/ObjectTopicCollection.pm |    2 +-
 lib/RT/FM/Record.pm                |    2 +-
 lib/RT/FM/SearchBuilder.pm         |    2 +-
 lib/RT/FM/System.pm                |    4 ++--
 lib/RT/FM/Topic.pm                 |    2 +-
 lib/RT/URI/fsck_com_rtfm.pm        |    1 -
 11 files changed, 11 insertions(+), 12 deletions(-)

- Log -----------------------------------------------------------------
commit 5bbc6d9f62748bdc20391f1e6094e06dc4d97307
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Jul 6 18:45:26 2011 -0400

    Remove some unnecessary "no warnings 'redefine'"; transform many into "use warnings"

diff --git a/lib/RT/FM/Article.pm b/lib/RT/FM/Article.pm
index 345358b..0148b4b 100644
--- a/lib/RT/FM/Article.pm
+++ b/lib/RT/FM/Article.pm
@@ -66,7 +66,7 @@ RT::FM::Article
 =cut
 
 use strict;
-no warnings 'redefine';
+use warnings;
 package RT::FM::Article;
 use RT::FM::Record; 
 use RT::FM::Class;
diff --git a/lib/RT/FM/ArticleCollection.pm b/lib/RT/FM/ArticleCollection.pm
index 1685342..a0515a1 100644
--- a/lib/RT/FM/ArticleCollection.pm
+++ b/lib/RT/FM/ArticleCollection.pm
@@ -68,7 +68,7 @@
 =cut
 
 use strict;
-no warnings 'redefine';
+use warnings;
 package RT::FM::ArticleCollection;
 
 use RT::FM::SearchBuilder;
diff --git a/lib/RT/FM/Class.pm b/lib/RT/FM/Class.pm
index e0af88a..53a2994 100644
--- a/lib/RT/FM/Class.pm
+++ b/lib/RT/FM/Class.pm
@@ -66,7 +66,7 @@ RT::FM::Class
 =cut
 
 use strict;
-no warnings 'redefine';
+use warnings;
 package RT::FM::Class;
 use RT::FM::Record; 
 
diff --git a/lib/RT/FM/ClassCollection.pm b/lib/RT/FM/ClassCollection.pm
index 2f34057..3c92ddc 100644
--- a/lib/RT/FM/ClassCollection.pm
+++ b/lib/RT/FM/ClassCollection.pm
@@ -68,7 +68,7 @@
 =cut
 
 use strict;
-no warnings 'redefine';
+use warnings;
 package RT::FM::ClassCollection;
 
 use RT::FM::SearchBuilder;
diff --git a/lib/RT/FM/ObjectTopic.pm b/lib/RT/FM/ObjectTopic.pm
index 1b72af8..e54d127 100644
--- a/lib/RT/FM/ObjectTopic.pm
+++ b/lib/RT/FM/ObjectTopic.pm
@@ -66,7 +66,7 @@ RT::FM::ObjectTopic
 =cut
 
 use strict;
-no warnings 'redefine';
+use warnings;
 package RT::FM::ObjectTopic;
 use RT::FM::Record; 
 use RT::FM::Topic;
diff --git a/lib/RT/FM/ObjectTopicCollection.pm b/lib/RT/FM/ObjectTopicCollection.pm
index ec39814..63724a9 100644
--- a/lib/RT/FM/ObjectTopicCollection.pm
+++ b/lib/RT/FM/ObjectTopicCollection.pm
@@ -68,7 +68,7 @@
 =cut
 
 use strict;
-no warnings 'redefine';
+use warnings;
 package RT::FM::ObjectTopicCollection;
 
 use RT::FM::SearchBuilder;
diff --git a/lib/RT/FM/Record.pm b/lib/RT/FM/Record.pm
index 0beb983..4ef9331 100644
--- a/lib/RT/FM/Record.pm
+++ b/lib/RT/FM/Record.pm
@@ -61,7 +61,7 @@
 
 
 use strict;
-no warnings 'redefine';
+use warnings;
 package RT::FM::Record;
 use  base qw(RT::Record);
 use RT::FM;
diff --git a/lib/RT/FM/SearchBuilder.pm b/lib/RT/FM/SearchBuilder.pm
index 240ae63..1d179af 100644
--- a/lib/RT/FM/SearchBuilder.pm
+++ b/lib/RT/FM/SearchBuilder.pm
@@ -59,7 +59,7 @@
 =cut
 
 use strict;
-no warnings 'redefine';
+use warnings;
 package RT::FM::SearchBuilder;
 use base qw(RT::SearchBuilder);
 use RT::FM;
diff --git a/lib/RT/FM/System.pm b/lib/RT/FM/System.pm
index ae674b0..e7510af 100644
--- a/lib/RT/FM/System.pm
+++ b/lib/RT/FM/System.pm
@@ -64,11 +64,11 @@ In the future, there will probably be other API goodness encapsulated here.
 =cut
 
 
-no warnings 'redefine';
+use strict;
+use warnings;
 package RT::FM::System;
 use RT::ACL;
 use base qw /RT::Base/;
-use strict;
 use vars qw/ $RIGHTS/;
 
 
diff --git a/lib/RT/FM/Topic.pm b/lib/RT/FM/Topic.pm
index 2e6b885..c79c825 100644
--- a/lib/RT/FM/Topic.pm
+++ b/lib/RT/FM/Topic.pm
@@ -66,7 +66,7 @@ RT::FM::Topic
 =cut
 
 use strict;
-no warnings 'redefine';
+use warnings;
 package RT::FM::Topic;
 use RT::FM::Record; 
 
diff --git a/lib/RT/URI/fsck_com_rtfm.pm b/lib/RT/URI/fsck_com_rtfm.pm
index bee7ee7..548d75e 100644
--- a/lib/RT/URI/fsck_com_rtfm.pm
+++ b/lib/RT/URI/fsck_com_rtfm.pm
@@ -49,7 +49,6 @@ package RT::URI::fsck_com_rtfm;
 
 use strict;
 use warnings;
-no warnings 'redefine';
 
 use RT::FM::Article;
 use base qw/RT::URI::base/;

-----------------------------------------------------------------------